- Issue created by @penyaskito
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ made their first commit to this issueโs fork.
- last update
7 months ago 5 pass - last update
7 months ago 5 pass - Status changed to Needs review
7 months ago 5:31pm 9 May 2024 Hi, I checked for phpcs issues using the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sam/
Found few warnings.FILE: C:\sam\sam.module
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
20 | WARNING | [ ] Global constants should not be used, move it to a class or interface
57 | WARNING | [ ] Unused variable $should_simplify.
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------ Status changed to Needs work
7 months ago 7:30am 10 May 2024 - last update
7 months ago 5 pass - Status changed to Needs review
7 months ago 7:42am 10 May 2024 - ๐ฎ๐ณIndia dev16.addweb
Hi, I have fixed Global constants warning issue and removed Unused variable $should_simplify, Please review.
- ๐ฌ๐งUnited Kingdom aaron.ferris
Curious as to why those aren't picked up in the pipeline job, which was green (and didn't flag them previously).
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Retroactively tagging Portland2024.
- last update
6 months ago 5 pass