Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Also, the report should not be a screenshot.

Latest patch doesn't apply to dev branch.
Needs work.

Issue summary updated.

I am planning to contribute on this, but i am focussing on drupal 10, is it possible to create a dev branch to be able to apply coding standards there?

I didn't see this fix in the last patch, but the error is in the phpcs output in the original post. The same error arrises from what's we're running (to confirm PHP8.1 compatibility) phpcs --runtime-set testVersion 8.1- --standard=PHPCompatibility.

-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
88 | ERROR | The behaviour of hexadecimal numeric strings was inconsistent prior to PHP 7 and support has been removed in PHP 7. Found: '0x0'
-----------------------------------------------------------------------------------------------------------------------------------------------

bindu r → made their first commit to this issue’s fork.

Switching to 2.0.x branch as 8.x is deprecated.

VladimirAus → changed the visibility of the branch 2.0.x to hidden.

fix unit tests errors

There are two issues in this issue: coding standards and adding gitlab.ci. Most of the friction here is coming from the coding standards. Should we create a separate issue just for the gitlab work (which is complete) and at least be able to get that ported into any active branches? That will _really_ help any new merge requests in gitlab while the code style issues get hashed out. I understand that this will lead to failing tests until the phpcs issues are fixed, but we can set those failing tests to ignore in the meantime. Happy to lead on this if desired.

Should we create a separate issue just for the gitlab work (which is complete) and at least be able to get that ported into any active branches?

Yes, this is good idea to create separate issue.
And separate issue to fix phpunit tests can be created as well.

I hide patch files, because MR workflow is used.

Should we create a separate issue just for the gitlab work (which is complete) and at least be able to get that ported into any active branches?

Yes, this is good idea to create separate issue.
And separate issue to fix phpunit tests can be created as well.

@nikolay-shapovalov I have created a separate issue 📌 Add gitlab.ci Needs work just for the gitlab-ci.yml starter file, so we can get that in and start getting feedback on merge requests, even if tests are allowed to fail.

https://www.drupal.org/project/dfp/issues/3416546 📌 Add gitlab.ci Needs work

And as you said, moving the test fixes into a separate issue would also be good to do... Thank you.

Updated title to reflect focus on this issue being the coding standards and letting the initial addition of gitlab-ci work be addressed separately https://www.drupal.org/project/dfp/issues/3416546 📌 Add gitlab.ci Needs work

I

Hello, checked out to the branch '2833962-fix-the-issues-d10' and ran the command phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js, found no errors or warnings remaining.

VladimirAus → changed the visibility of the branch 2833962-fix-the-issues to hidden.

outstanding failed CI items are created as separate tasks

Thank you! Committed! 🥂

Automatically closed - issue fixed for 2 weeks with no activity.