Patch provided in #2 applied successfully, the twitter icon is updated now, attaching the screenshot. RTBC+1
I applied patch in #2 and it got applied successfully.
But I'm still seeing only "DEFAULT" and "ADMIN" in the select, attaching screenshot.
I'm encountering the same problem as well. When I attempt to filter submissions based on their created or submitted dates, the output isn't consistent and tends to vary each time.
I ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml and found no issues.
I
I ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml command and found the following errors:
FILE: /home/sites/prod_check/src/Form/SettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
21 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------
FILE: /home/sites/prod_check/src/CheckPluginCollection.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
23 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------
FILE: /home/sites/prod_check/src/ProdCheck.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
14 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------------------------------------------------------------
FILE: /home/sites/prod_check/src/ProcessorPluginCollection.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
23 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------
FILE: /home/sites/prod_check/src/Entity/ProdCheckProcessorConfigInterface.php
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
24 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------
FILE: /home/sites/prod_check/src/Plugin/ProdCheck/ProdCheckBase.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
165 | WARNING | Only string literals should be passed to t() where possible
201 | WARNING | Code after the RETURN statement on line 199 cannot be executed
205 | WARNING | Code after the RETURN statement on line 203 cannot be executed
208 | WARNING | Code after the RETURN statement on line 207 cannot be executed
--------------------------------------------------------------------------------
FILE: /home/sites/prod_check/src/Plugin/ProdCheck/Modules/ModuleList.php
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
39 | WARNING | Line exceeds 80 characters; contains 85 characters
------------------------------------------------------------------------
FILE: /home/sites/prod_check/src/Plugin/ProdCheckProcessor/ConfigurableProdCheckProcessorBase.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
12 | WARNING | Line exceeds 80 characters; contains 87 characters
-------------------------------------------------------------------------------------------------
FILE: /home/sites/prod_check/prod_check.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
44 | WARNING | Line exceeds 80 characters; contains 81 characters
114 | WARNING | Line exceeds 80 characters; contains 117 characters
115 | WARNING | Line exceeds 80 characters; contains 118 characters
148 | WARNING | Line exceeds 80 characters; contains 117 characters
149 | WARNING | Line exceeds 80 characters; contains 118 characters
----------------------------------------------------------------------
I applied the patch provided in #8 and found one warning:
FILE: /home/sites/decoupled_domain/src/DomainConfigPluginCollection.php
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
44 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------Shank115 → made their first commit to this issue’s fork.
I ran this command phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml single_page_site/ and found no issues or warnings.
I ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_openai and found these errors:
FILE: /home/sites/tmgmt_openai/src/Plugin/tmgmt/Translator/OpenAiTranslator.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 17 LINES
-----------------------------------------------------------------------------------------------------------------------
37 | ERROR | [x] Additional blank lines found at end of doc comment
43 | ERROR | [x] Additional blank lines found at end of doc comment
131 | ERROR | [ ] Missing parameter comment
132 | ERROR | [ ] Missing parameter comment
133 | ERROR | [x] Separate the @param and @return sections by a blank line.
133 | ERROR | [ ] Description for the @return value must be on the next line
165 | ERROR | [ ] Missing parameter comment
166 | ERROR | [ ] Missing parameter comment
167 | ERROR | [x] Separate the @param and @return sections by a blank line.
167 | ERROR | [ ] Description for the @return value must be on the next line
197 | ERROR | [x] Missing function doc comment
210 | ERROR | [x] Missing function doc comment
214 | ERROR | [x] Missing function doc comment
221 | ERROR | [ ] Description for the @return value must be on the next line
236 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
249 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
276 | ERROR | [x] Parameter comment must end with a full stop
287 | ERROR | [ ] @throws tag comment must end with a full stop
415 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /home/sites/tmgmt_openai/src/OpenAiTranslatorUi.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
16 | ERROR | [x] Do not append variable name "$models" to the type declaration in a member variable comment
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: /home/sites/tmgmt_openai/tmgmt_openai.install
------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] The open comment tag must be the only content on the line
4 | ERROR | [x] The second line in the file doc comment must be "@file"
4 | ERROR | [x] Function comment short description must start with exactly one space
5 | ERROR | [ ] Wrong function doc comment end; expected "*/", found "**/"
7 | WARNING | [x] Unused use statement
11 | ERROR | [x] There must be no blank lines after the function comment
14 | ERROR | [x] Opening brace should be on the same line as the declaration
17 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
17 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /home/sites/tmgmt_openai/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
47 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------
I applied patch provided in #16, applies cleanly. Ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_cumulative_field/, found no phpcs errors.
Checking patch src/Plugin/views/field/CumulativeField.php...
Checking patch views_cumulative_field.views.inc...
Applied patch src/Plugin/views/field/CumulativeField.php cleanly.
Applied patch views_cumulative_field.views.inc cleanly.Please review this patch.
Found these issues, hopefully we can ignore them:
FILE: /home/sites/search_logs/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 15 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 290 characters
7 | WARNING | Line exceeds 80 characters; contains 81 characters
11 | WARNING | Line exceeds 80 characters; contains 160 characters
15 | WARNING | Line exceeds 80 characters; contains 137 characters
19 | WARNING | Line exceeds 80 characters; contains 97 characters
21 | WARNING | Line exceeds 80 characters; contains 110 characters
23 | WARNING | Line exceeds 80 characters; contains 81 characters
25 | WARNING | Line exceeds 80 characters; contains 95 characters
31 | WARNING | Line exceeds 80 characters; contains 235 characters
39 | WARNING | Line exceeds 80 characters; contains 89 characters
41 | WARNING | Line exceeds 80 characters; contains 164 characters
45 | WARNING | Line exceeds 80 characters; contains 204 characters
49 | WARNING | Line exceeds 80 characters; contains 189 characters
53 | WARNING | Line exceeds 80 characters; contains 120 characters
57 | WARNING | Line exceeds 80 characters; contains 306 characters
----------------------------------------------------------------------Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
These are remaining issues.
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonapi_resources/
FILE: /home/sites/jsonapi_resources/src/Unstable/Controller/JsonapiResourceController.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
66 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/sites/jsonapi_resources/src/Unstable/DocumentExtractor.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
124 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/sites/jsonapi_resources/tests/src/Unit/Routing/ResourceRoutesTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
38 | ERROR | The array declaration extends to column 149 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
I applied patch in #22 and it applied cleanly
I applied the patch provided in #13 and it applied successfully.
I tested the patch, it applies cleanly.
Checking patch README.txt...
Checking patch css/memcache-storage.css...
Checking patch memcache_storage.install...
Checking patch memcache_storage.links.menu.yml...
Checking patch memcache_storage.module...
Checking patch src/Controller/MemcachedStatistics.php...
Checking patch src/DrupalMemcache.php...
Checking patch src/DrupalMemcached.php...
Checking patch src/DrupalMemcachedBase.php...
Checking patch src/DrupalMemcachedDebug.php...
Checking patch src/DrupalMemcachedFactory.php...
Checking patch src/DrupalMemcachedInterface.php...
Checking patch src/DrupalMemcachedUtils.php...
Checking patch src/MemcachedBackend.php...
Checking patch src/MemcachedBackendFactory.php...
Applied patch README.txt cleanly.
Applied patch css/memcache-storage.css cleanly.
Applied patch memcache_storage.install cleanly.
Applied patch memcache_storage.links.menu.yml cleanly.
Applied patch memcache_storage.module cleanly.
Applied patch src/Controller/MemcachedStatistics.php cleanly.
Applied patch src/DrupalMemcache.php cleanly.
Applied patch src/DrupalMemcached.php cleanly.
Applied patch src/DrupalMemcachedBase.php cleanly.
Applied patch src/DrupalMemcachedDebug.php cleanly.
Applied patch src/DrupalMemcachedFactory.php cleanly.
Applied patch src/DrupalMemcachedInterface.php cleanly.
Applied patch src/DrupalMemcachedUtils.php cleanly.
Applied patch src/MemcachedBackend.php cleanly.
Applied patch src/MemcachedBackendFactory.php cleanly.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Changed the sentence please review.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Fixed some of phpcs issues, please review
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
Shank115 → made their first commit to this issue’s fork.
There are still some phpcs issues need to be fixed
Shank115 → made their first commit to this issue’s fork.
Rebased with the latest changes, and resolved phpcs except the warnings in the screenshot.
Shank115 → made their first commit to this issue’s fork.