- Status changed to Needs work
almost 2 years ago 4:03pm 2 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- list($id, $vid, $bundle) = entity_extract_ids($entity_type, $entity); + [$id, $vid, $bundle] = entity_extract_ids($entity_type, $entity);The minimum PHP version required by Drupal 7 is PHP 5.3, which cannot use the short array syntax.
- // drupal_add_http_header('Content-Length', filesize($pdf), TRUE); + // drupal_add_http_header('Content-Length', filesize($pdf), TRUE);.Periods are not added at the end of commented out code.
- $coupon_code = isset($form_state['values']['coupon_code']) ? $form_state['values']['coupon_code'] : NULL; + $coupon_code = $form_state['values']['coupon_code'] ?? NULL;The null coalescing operator cannot be used on PHP 5.3.
- <?php if ($line_item['end_date']): ?>- <?php print $line_item['end_date']; ?><?php endif; ?></td> + <?php if ($line_item['end_date']): ?>- <?php print $line_item['end_date']; ?><?php + endif; ?></td>The existing code is correctly formatted.
<?php endif; ?>is written on a single line.* The label to use for the base table or entity type, such as - * 'Recurly account.' + * 'Recurly account.'.In those cases, only a period is used, even if that is inside a quoted phrase.
+/** + * + */ class recurly_entity_owner_handler extends views_handler_relationship {A documentation comment must be not empty.
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India zkhan.aamir
Hi,
patch #21 applied successfully but 1 file rejected.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/recurly (7.x-3.x) $ curl https://www.drupal.org/files/issues/2024-02-09/phpcs_fix_0.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 26302 100 26302 0 0 58506 0 --:--:-- --:--:-- --:--:-- 58709 patching file css/recurly.css Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file css/recurly.css.rej patching file includes/recurly.admin.inc patching file includes/recurly.pages.inc patching file modules/recurly_hosted/recurly_hosted.module patching file modules/recurlyjs/css/recurlyjs.css patching file modules/recurlyjs/includes/recurlyjs.pages.inc patching file modules/recurlyjs/recurlyjs.module patching file recurly.module patching file templates/recurly-invoice.tpl.php patching file templates/recurly-subscription-summary.tpl.php patching file views/recurly.views.inc patching file views/recurly_account_code_handler.inc patching file views/recurly_entity_owner_handler.inc patching file views/recurly_entity_owner_reverse_handler.incStill errors remaining
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml recurly/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\includes\recurly.admin.inc ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 340 | WARNING | Unused variable $plans. 479 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 522 | ERROR | The array declaration extends to column 122 (the limit is 80). The array content should be split up over multiple lines 527 | ERROR | The array declaration extends to column 174 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\includes\recurly.pages.inc ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 17 ERRORS AND 36 WARNINGS AFFECTING 35 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 34 | WARNING | Unused variable $vid. 34 | WARNING | Unused variable $bundle. 35 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines 39 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines 96 | ERROR | The array declaration extends to column 121 (the limit is 80). The array content should be split up over multiple lines 217 | ERROR | The array declaration extends to column 221 (the limit is 80). The array content should be split up over multiple lines 309 | WARNING | Unused variable $vid. 309 | WARNING | Unused variable $bundle. 310 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines 335 | WARNING | Unused variable $vid. 335 | WARNING | Unused variable $bundle. 336 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines 416 | WARNING | Unused variable $vid. 416 | WARNING | Unused variable $bundle. 459 | WARNING | Unused variable $vid. 459 | WARNING | Unused variable $bundle. 460 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines 563 | WARNING | Unused variable $vid. 563 | WARNING | Unused variable $bundle. 581 | WARNING | Unused variable $vid. 581 | WARNING | Unused variable $bundle. 617 | WARNING | Unused variable $vid. 617 | WARNING | Unused variable $bundle. 618 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines 726 | WARNING | Unused variable $vid. 726 | WARNING | Unused variable $bundle. 744 | WARNING | Unused variable $vid. 744 | WARNING | Unused variable $bundle. 749 | ERROR | The array declaration extends to column 190 (the limit is 80). The array content should be split up over multiple lines 802 | WARNING | Unused variable $vid. 802 | WARNING | Unused variable $bundle. 803 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines 817 | WARNING | Unused variable $vid. 817 | WARNING | Unused variable $bundle. 821 | ERROR | The array declaration extends to column 203 (the limit is 80). The array content should be split up over multiple lines 842 | WARNING | Unused variable $vid. 842 | WARNING | Unused variable $bundle. 843 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines 866 | WARNING | Unused variable $vid. 866 | WARNING | Unused variable $bundle. 908 | WARNING | Unused variable $vid. 908 | WARNING | Unused variable $bundle. 909 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines 944 | WARNING | Unused variable $vid. 944 | WARNING | Unused variable $bundle. 947 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines 999 | ERROR | The array declaration extends to column 117 (the limit is 80). The array content should be split up over multiple lines 1020 | ERROR | The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines 1070 | WARNING | Unused variable $vid. 1070 | WARNING | Unused variable $bundle. 1143 | WARNING | Unused variable $vid. 1143 | WARNING | Unused variable $bundle. 1144 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\modules\recurlyjs\includes\recurlyjs.pages.inc ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 8 WARNINGS AFFECTING 11 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 83 | WARNING | Unused variable $vid. 83 | WARNING | Unused variable $bundle. 84 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines 232 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 237 | ERROR | The array declaration extends to column 168 (the limit is 80). The array content should be split up over multiple lines 268 | WARNING | Unused variable $vid. 268 | WARNING | Unused variable $bundle. 269 | ERROR | The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines 369 | WARNING | Unused variable $vid. 369 | WARNING | Unused variable $bundle. 370 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines 443 | WARNING | Unused variable $vid. 443 | WARNING | Unused variable $bundle. 444 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines 702 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\modules\recurlyjs\recurlyjs.api.php ---------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 22 | WARNING | Line exceeds 80 characters; contains 81 characters ---------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\modules\recurlyjs\recurlyjs.module --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------- 17 | WARNING | Unused variable $entity_info. 61 | WARNING | Unused variable $vid. 61 | WARNING | Unused variable $bundle. --------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\modules\recurly_hosted\recurly_hosted.module ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 20 | WARNING | Unused variable $entity_info. 50 | WARNING | Unused variable $vid. 50 | WARNING | Unused variable $bundle. 58 | ERROR | The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines 73 | WARNING | Unused global variable $user. 74 | WARNING | Unused variable $vid. 74 | WARNING | Unused variable $bundle. 75 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\recurly.api.php ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 102 | ERROR | Function return type is not void, but function is returning void here ------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\recurly.module ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 14 ERRORS AND 15 WARNINGS AFFECTING 25 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 19 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 25 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 61 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction 352 | WARNING | Unused variable $vid. 352 | WARNING | Unused variable $bundle. 353 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines 364 | ERROR | The array declaration extends to column 145 (the limit is 80). The array content should be split up over multiple lines 365 | ERROR | The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines 373 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines 430 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines 432 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines 449 | WARNING | Unused variable $vid. 449 | WARNING | Unused variable $bundle. 450 | ERROR | The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines 452 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines 552 | ERROR | is_integer() is a function name alias, use is_int() instead 552 | WARNING | Unused variable $entity. 556 | WARNING | Unused variable $entity. 597 | WARNING | Unused variable $client. 616 | WARNING | Line exceeds 80 characters; contains 81 characters 729 | WARNING | Unused variable $remote_account. 796 | ERROR | The array declaration extends to column 156 (the limit is 80). The array content should be split up over multiple lines 800 | ERROR | The array declaration extends to column 152 (the limit is 80). The array content should be split up over multiple lines 812 | ERROR | The array declaration extends to column 245 (the limit is 80). The array content should be split up over multiple lines 879 | WARNING | Unused variable $vid. 912 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines 1129 | WARNING | Unused variable $vid. 1129 | WARNING | Unused variable $bundle. ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\templates\recurly-invoice-list.tpl.php ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 6 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph ----------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\templates\recurly-invoice.tpl.php ----------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 6 | ERROR | Doc comment short description must end with a full stop 6 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph ----------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\views\recurly.views.inc --------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------- 95 | ERROR | The array declaration extends to column 131 (the limit is 80). The array content should be split up over multiple lines 126 | ERROR | The array declaration extends to column 130 (the limit is 80). The array content should be split up over multiple lines 132 | ERROR | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\views\recurly_account_code_handler.inc --------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty 11 | ERROR | Class name must begin with a capital letter 11 | ERROR | Class name must use UpperCamel naming without underscores 26 | ERROR | Public method name "recurly_account_code_handler::options_form" is not in lowerCamel format 39 | ERROR | Public method name "recurly_account_code_handler::option_definition" is not in lowerCamel format 64 | ERROR | Public method name "recurly_account_code_handler::render_link" is not in lowerCamel format --------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\views\recurly_entity_owner_handler.inc ------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------- 16 | ERROR | Doc comment is empty 19 | ERROR | Class name must begin with a capital letter 19 | ERROR | Class name must use UpperCamel naming without underscores ------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\recurly\views\recurly_entity_owner_reverse_handler.inc --------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------- 14 | ERROR | Doc comment is empty 17 | ERROR | Class name must begin with a capital letter 17 | ERROR | Class name must use UpperCamel naming without underscores --------------------------------------------------------------------------------------------------------------- Time: 968ms; Memory: 22MB - Assigned to amit.rawat777
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Drupal 7 and the 7.x-3.x branch of this project are no longer supported.