- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 3:47am 27 February 2023 - Assigned to omkar_yewale
- Issue was unassigned.
- Status changed to RTBC
about 2 years ago 4:45am 27 February 2023 - š®š³India omkar_yewale Mumbai
Thanks for the patch. Cleanly applied and all issues have been resolved.
Moving RTBC. - First commit to issue fork.
- š®š³India urvashi_vora Madhya Pradesh, India
Tested patch provided in #2.
Steps performed:-
1. Took clone of the issue
2. Execute command :- "phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig admin_toolbar_tasks-3344598/"
3. There were several issues found:-urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal8/web/modules/contrib$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig admin_toolbar_tasks-3344598/ FILE: ...dules/contrib/admin_toolbar_tasks-3344598/src/AdminToolbarTasksBuilder.php -------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 8 LINES -------------------------------------------------------------------------------- 13 | ERROR | [x] Missing class doc comment 15 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [x] Missing function doc comment 24 | ERROR | [x] Missing function doc comment 31 | ERROR | [x] Missing function doc comment 35 | ERROR | [x] Missing function doc comment 48 | ERROR | [x] Missing function doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...web/modules/contrib/admin_toolbar_tasks-3344598/admin_toolbar_tasks.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 19 | ERROR | The array declaration extends to column 102 (the limit is 80). | | The array content should be split up over multiple lines -------------------------------------------------------------------------------- Time: 525ms; Memory: 10MB
4. Applied the patch
5. Re-executed the command:- "phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig admin_toolbar_tasks-3344598/"
6. All issues resolvedurvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal8/web/modules/contrib$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig admin_toolbar_tasks-3344598/ urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/drupal8/web/modules/contrib$
Test Result:- Patch applied successfully. Commiting the changes.
Thanks for the work.
- @urvashi_vora opened merge request.
- Status changed to Needs work
about 2 years ago 3:43pm 3 March 2023 - š®š¹Italy apaderno Brescia, š®š¹
+/** + * The AdminToolbarTasksBuilder class. + */
A documentation comment should say the purpose of the class not its name, which is already shown in the code.
+ /** + * Constructs a new AdminToolbarTasksBuilder instance. + * + * @param \Drupal\Core\Menu\LocalTaskManagerInterface $local_task_manager + * The local task manager service. + * @param \Drupal\Core\Routing\RouteMatchInterface $route_match + * The route match object to be checked.
The class name needs to include its namespace.
+ /** + * The build function. + */
That is the method name, not its purpose. The return value is not documented.
+ /** + * The getAdminTasks function. + */ private function getAdminTasks(CacheableMetadata $cacheability): array {
Neither the parameters nor the return value are documented.
- First commit to issue fork.
- Open on Drupal.org āCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 10:13am 27 December 2023 - š®š³India nitin_lama India
No remaining issues left on MR3. Please review.
- Status changed to RTBC
over 1 year ago 9:52am 8 January 2024 - šµšPhilippines clarkssquared
Hi
I applied MR !3 and I confirmed that it fixes all the PHPCS issues
ā admin_toolbar_tasks git:(1.0.x) curl https://git.drupalcode.org/project/admin_toolbar_tasks/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3529 0 3529 0 0 7061 0 --:--:-- --:--:-- --:--:-- 7172 patching file admin_toolbar_tasks.module patching file 'src/AdminToolbarTasksBuilder.php' ā admin_toolbar_tasks git:(1.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml admin_toolbar_tasks ā contrib git:(master) ā