Fix the issues reported by phpcs

C:\xampp\htdocs\backendassignment\web\modules\custom>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig yusaopeny_ymca360 FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\src\Form\SettingsForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 57 | ERROR | [x] Expected 1 blank line after function; 0 found 58 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\src\syncer\Extractor.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\src\syncer\Loader.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\src\syncer\Transformer.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\yusaopeny_ymca360_instudio.install -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_instudio\yusaopeny_ymca360_instudio.module ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\Form\SettingsForm.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 64 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead 105 | ERROR | [x] Expected 1 blank line after function; 0 found 106 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\syncer\Extractor.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\syncer\Loader.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 23 | WARNING | [ ] Possible useless method overriding detected ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\syncer\Transformer.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\yusaopeny_ymca360_livestreams.install -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\yusaopeny_ymca360_livestreams.module ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\yusaopeny_ymca360_livestreams.routing.yml ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\README.md -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------- 50 | WARNING | Line exceeds 80 characters; contains 82 characters 80 | WARNING | Line exceeds 80 characters; contains 81 characters 88 | WARNING | Line exceeds 80 characters; contains 88 characters -------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Entity\Y360Mapping.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Form\LocationsMappingForm.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 72 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Form\SettingsForm.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 31 | ERROR | [ ] Class property $module_handler should use lowerCamel naming without underscores 49 | ERROR | [x] Opening brace should be on the same line as the declaration 49 | ERROR | [x] The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line 158 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 197 | WARNING | [x] A comma should follow the last multiline array item. Found: ) --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\MappingListBuilder.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\DataWrapper.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\DataWrapperInterface.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\ExtractorBase.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\ExtractorInterface.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\LoaderBase.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 9 ERRORS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 92 | ERROR | [x] Opening brace should be on the same line as the declaration 92 | ERROR | [x] The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line 125 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 144 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 163 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 286 | ERROR | [ ] The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 355 | ERROR | [x] Expected 1 blank line after function; 2 found 479 | ERROR | [ ] Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\LoaderInterface.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\TransformerBase.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\syncer\TransformerInterface.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Y360Client.php ------------------------------------------------------------------------------------------------------------ FOUND 9 ERRORS AND 1 WARNING AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 8 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 21 | ERROR | [ ] Class property $api_url should use lowerCamel naming without underscores 57 | ERROR | [x] Expected "bool|array" but found "boolean|array" for function return type 57 | ERROR | [ ] Description for the @return value is missing 75 | ERROR | [ ] Description for the @return value is missing 135 | ERROR | [ ] Parameter $options is not described in comment 154 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead 155 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 183 | ERROR | [x] Expected "arraystring" but found "array<string>" for function return type ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Y360MappingRepository.php ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\src\Y360MappingViewBuilder.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\yusaopeny_ymca360.api.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\yusaopeny_ymca360\yusaopeny_ymca360.module ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- Time: 3.87 secs; Memory: 6MB

Comments & Activities

Issue created by @sidharth_soman
Issue was unassigned.
Comment 12 months ago →
🇮🇳India sidharth_soman Bangalore
All issues fixed except for the dependency injection and errors involving naming conventions and documentation.

Leaving it in 'Needs Work' for now.
Status changed to Needs review 12 months ago10:17am 11 July 2023
Comment 12 months ago →
🇮🇳India mrinalini9 New Delhi
Updated patch #2 by fixing the remaining dependency injection and other errors/warnings issues, please review it.

Thanks & Regards,
Mrinalini
Assigned to sidharth_soman
Status changed to Needs work 12 months ago10:29am 11 July 2023
Comment 12 months ago →
🇮🇳India sidharth_soman Bangalore
Patch #3 all of the errors. However, there are two left regarding the sorting of use statements in alphabetical order in files: yusaopeny_ymca360\src\Form\SettingsForm.php and yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\Form\SettingsForm.php.

PHPCS Report:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig yusaopeny_ymca360

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\yusaopeny_ymca360\modules\yusaopeny_ymca360_livestreams\src\Form\SettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\yusaopeny_ymca360\src\Form\SettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------
I'll fix them and provide an MR with all the changes together.
Merge request !6Fixed phpcs issues. → (Open) created by sidharth_soman
Issue was unassigned.
Status changed to Needs review 12 months ago10:34am 11 July 2023
Comment 12 months ago →
🇮🇳India sidharth_soman Bangalore
Status changed to Needs work 11 months ago5:24pm 18 July 2023
Comment 11 months ago →
🇵🇭Philippines clarkssquared
Hi sidharth_soman

I applied your MR !6 to my local and I confirmed that your Merge Request fixed all the PHPCS errors/issues. However, there is a whitespace error in your MR !6 please fix the whitespace error and all will be good.

Please look at the screenshot I attached for your reference.

Thank you
First commit to issue fork.
Comment 9 months ago →
🇮🇳India Shank115
Rebased with the latest changes, and resolved phpcs except the warnings in the screenshot.
First commit to issue fork.
Status changed to Needs review 9 months ago2:51pm 27 September 2023
Comment 9 months ago →
🇮🇳India sakthi_dev
Please review.
Status changed to Needs work 5 months ago5:54pm 19 January 2024
Comment 5 months ago →
🇷🇺Russia zniki.ru
Please update Issue summary, update command and phpcs report.

phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme

Please remove changes that is not a part of phpcs report.
Please fix conflicts.
First commit to issue fork.
Comment 5 months ago →
🇮🇳India sakthi_dev
Rebased.
Status changed to Needs review 5 months ago7:35am 8 February 2024
Comment 5 months ago →
🇮🇳India Yashaswi18
Comment 4 months ago →
🇮🇳India Preethy_ray
Hi,
I have reviewed MR!6 and did not find any errors or warnings reported by PHPCS.
Thank you!!
Comment 4 months ago →
🇮🇳India __i.am.prashant__
Hi, MR !6 seems to be resolving phpcs issues. I am attaching the screenshot for reference. Please review
Marking this ticket as RTBC!! and thank you
Status changed to RTBC 4 months ago6:39am 15 February 2024
Comment 4 months ago →
🇮🇳India __i.am.prashant__

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!6Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!6Fix the issues reported by phpcsOpen

Comments & Activities

!6Fix the issues reported by phpcs
Open