๐Ÿ‡ฎ๐Ÿ‡ณIndia @__i.am.prashant__

Account created on 4 January 2023, over 1 year ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

MR !11 removed the warning and works fine for me. I mark this issue ready for review and wait for test by other community members.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

MR !2 removed all the phpcs issues. I mark it needs review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @ptmkenny, can you please provide steps to reproduce the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ changed the visibility of the branch 3425090-undefined-function to active.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ changed the visibility of the branch 3425090-undefined-function to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@gordonio, I applied the patch provided by you but it seems to like the issue is still not solved.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@adriancid, Yes I tried this with dev version and the issue is still present there.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I have review the MR !2 and it fixed all the issue of phpcs so I am marking it !RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@Aakansha, I have reviewed the changes you made in anchor tags css and I see you removed text-decoration from those tags and now all the rows value looks same. here it is difficult to understand which cell value is clickable and linked with something. if you will made anchor tags bit different from normal cell values it will defiantly helpful for users.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @KurtTrowbridge, the changes you made looks fine.
I am going to marking this ticket as RTBC!!

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@chaitanyadessai, I have reviewed your MR !4 and it removed all the issue/warnings you mentioned above.
Marking this ticket as RTBC!! thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @stefank,

none of the patch worked well even after when I apply patch and then go for add
Entity Reference Exposed Filter is still throw warning messages. Please see attached screenshot. thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@shweta__sharma,

MR !22 is not merge-able for target branch. need to be rework.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I have review the issue and the MR !2 fixed the issue.
Marking this ticket as RTBC!! and thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi, MR !6 seems to be resolving phpcs issues. I am attaching the screenshot for reference. Please review
Marking this ticket as RTBC!! and thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I reviewed the changes done in the quick_node_clone module looks fine and useful for community it makes ease of use. Improving ease of use is always a priority, and it's rewarding to see these enhancements making a positive impact. Thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@Hamid.ali,

I have reviewed the patch on to my drupal website having version 10 and php version 8.1. The patch has been successfully applied.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@jrockowitz,

I reviewed the MR and it looks fine for me. @Sandeep_k please apply MR for target branch 1.0.x. and after apply MR you should need to run updatedb command.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

@StryKaizer,

The patch provided by @chaitanyadessai works well and successfully removes the cancel button from all webforms. However, I believe the module is intended to display the cancel button on all types of forms, so there's no need to remove the button from webforms.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hello @sd123,
I attempted to replicate the problem using PHP 8.2 and Drupal 10.2.3, but I was unable to do so. Could you kindly explain in brief how I can replicate the problem? If it's feasible, please include a gif or image.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hello Gautam_105,

I've gone through the modifications you made, and everything appears to be in order. The Twitter logo has been successfully updated.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ changed the visibility of the branch 3412527-paragrah-custom-date to active.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ changed the visibility of the branch 3412527-paragrah-custom-date to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @medienverbinder,
MR !11 changes looks fine so I just Open Merge Request as new MR !12 for the config link changes. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I tried MR !6034 but it still show the same issue. the issue is not only comes with Full HTML but also Basic html.
Please see below attachments that how looks ckeditor toolbar after apply MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @dineshkumarbollu,

your patch is looks fine for use that module in Drupal 10 but This project is not covered by Drupalโ€™s security advisory policy and not available on drupal.org for use.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @kevinfunk,

I've attempted to apply your patch to the selected version "8.x-1.x-dev" of the module. However, I encountered challenges in applying it successfully. While I did manage to get the select and checkbox selection field, the transformation of the schema from a select list to checkboxes did not occur as expected.

I kindly request your assistance in creating a Merge Request (MR) for this patch.

Thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @kenrbnsn,

I created MR for make this module drupal 10 compatible please review it. Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

__i.am.prashant__ โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @Harshita, I applied your patch and it updated Pirate.php file and replace t() to $this->t() now it looks fine for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @Harshita, I reviewed and applied your patch that removed core : '8.x' from info.yml file and now it looks fine.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi nitin, I review and applied MR that replace README.txt file with README.md file and it look fine.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I am able to enable and use the module in my Drupal 10 site after the patch is applied. Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @Liam thanks for the patch it works fine for me.
see attached screenshot that was taken before apply patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I applied patch and it works fine for me with drupal 9.5 and php version 8.1.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

MR !5 works fine for me. It updates README file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I applied MR !1 on drupal 9.5 with php version 8.1 and it works fine for me.
please refer to the attachment.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I applied patch #4 on Drupal version 9.5.2 with PHP 8.1.10, it's works fine for me. Please refer to the attachments.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Tested on Drupal 9.5 with Environment Indicator 4.0.14
MR !20 worked for me.

Refer to attached screenshots. Thank you!

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

MR !1 works fine in drupa 9.5 with php version 8.1.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi Kamlesh Kishor Jha,
I have tested the MR !1 in drupa 9.5 it works fine for me.
But Could you please create a patch file and submit it on this issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

I applied the MR !8 on Drupal version 9.5.2 with PHP 8.1.10, it's works fine for me. Please check attachments.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

MR !19 Works fine for me on Drupal 9.5 .

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @noorulshameera,
patch on comment #2 works fine for me on drupal 9.5.

๐Ÿ‡ฎ๐Ÿ‡ณIndia __i.am.prashant__

Hi @Jay The Merge request was fine for me in Drupal 9.5
Here I attached the screenshot of before and after MR apply.

Production build 0.69.0 2024