MR !11 removed the warning and works fine for me. I mark this issue ready for review and wait for test by other community members.
MR !2 removed all the phpcs issues. I mark it needs review.
__i.am.prashant__ โ made their first commit to this issueโs fork.
Hi @ptmkenny, can you please provide steps to reproduce the issue.
__i.am.prashant__ โ changed the visibility of the branch 3425090-undefined-function to active.
__i.am.prashant__ โ changed the visibility of the branch 3425090-undefined-function to hidden.
__i.am.prashant__ โ made their first commit to this issueโs fork.
@gordonio, I applied the patch provided by you but it seems to like the issue is still not solved.
@adriancid, Yes I tried this with dev version and the issue is still present there.
__i.am.prashant__ โ made their first commit to this issueโs fork.
I have review the MR !2 and it fixed all the issue of phpcs so I am marking it !RTBC.
__i.am.prashant__ โ made their first commit to this issueโs fork.
@Aakansha, I have reviewed the changes you made in anchor tags css and I see you removed text-decoration from those tags and now all the rows value looks same. here it is difficult to understand which cell value is clickable and linked with something. if you will made anchor tags bit different from normal cell values it will defiantly helpful for users.
Hi @KurtTrowbridge, the changes you made looks fine.
I am going to marking this ticket as RTBC!!
@chaitanyadessai, I have reviewed your MR !4 and it removed all the issue/warnings you mentioned above.
Marking this ticket as RTBC!! thank you
Hi @stefank,
none of the patch worked well even after when I apply patch and then go for add
Entity Reference Exposed Filter is still throw warning messages. Please see attached screenshot. thanks
@shweta__sharma,
MR !22 is not merge-able for target branch. need to be rework.
I have review the issue and the MR !2 fixed the issue.
Marking this ticket as RTBC!! and thank you
Hi, MR !6 seems to be resolving phpcs issues. I am attaching the screenshot for reference. Please review
Marking this ticket as RTBC!! and thank you
I reviewed the changes done in the quick_node_clone module looks fine and useful for community it makes ease of use. Improving ease of use is always a priority, and it's rewarding to see these enhancements making a positive impact. Thank you
@Hamid.ali,
I have reviewed the patch on to my drupal website having version 10 and php version 8.1. The patch has been successfully applied.
@jrockowitz,
I reviewed the MR and it looks fine for me. @Sandeep_k please apply MR for target branch 1.0.x. and after apply MR you should need to run updatedb command.
@StryKaizer,
The patch provided by @chaitanyadessai works well and successfully removes the cancel button from all webforms. However, I believe the module is intended to display the cancel button on all types of forms, so there's no need to remove the button from webforms.
Hello @sd123,
I attempted to replicate the problem using PHP 8.2 and Drupal 10.2.3, but I was unable to do so. Could you kindly explain in brief how I can replicate the problem? If it's feasible, please include a gif or image.
Hello Gautam_105,
I've gone through the modifications you made, and everything appears to be in order. The Twitter logo has been successfully updated.
__i.am.prashant__ โ made their first commit to this issueโs fork.
__i.am.prashant__ โ made their first commit to this issueโs fork.
__i.am.prashant__ โ changed the visibility of the branch 3412527-paragrah-custom-date to active.
__i.am.prashant__ โ changed the visibility of the branch 3412527-paragrah-custom-date to hidden.
__i.am.prashant__ โ made their first commit to this issueโs fork.
Hi @medienverbinder,
MR !11 changes looks fine so I just Open Merge Request as new MR !12 for the config link changes. Please review.
I tried MR !6034 but it still show the same issue. the issue is not only comes with Full HTML but also Basic html.
Please see below attachments that how looks ckeditor toolbar after apply MR.
Hi @dineshkumarbollu,
your patch is looks fine for use that module in Drupal 10 but This project is not covered by Drupalโs security advisory policy and not available on drupal.org for use.
Hi @kevinfunk,
I've attempted to apply your patch to the selected version "8.x-1.x-dev" of the module. However, I encountered challenges in applying it successfully. While I did manage to get the select and checkbox selection field, the transformation of the schema from a select list to checkboxes did not occur as expected.
I kindly request your assistance in creating a Merge Request (MR) for this patch.
Thank you
Hi @kenrbnsn,
I created MR for make this module drupal 10 compatible please review it. Thanks
__i.am.prashant__ โ made their first commit to this issueโs fork.
Hi @Harshita, I applied your patch and it updated Pirate.php file and replace t() to $this->t() now it looks fine for me.
Hi @Harshita, I reviewed and applied your patch that removed core : '8.x' from info.yml file and now it looks fine.
Hi nitin, I review and applied MR that replace README.txt file with README.md file and it look fine.
I am able to enable and use the module in my Drupal 10 site after the patch is applied. Thank you.
Hi @Liam thanks for the patch it works fine for me.
see attached screenshot that was taken before apply patch.
__i.am.prashant__ โ made their first commit to this issueโs fork.
I applied patch and it works fine for me with drupal 9.5 and php version 8.1.
MR !5 works fine for me. It updates README file.
I applied MR !1 on drupal 9.5 with php version 8.1 and it works fine for me.
please refer to the attachment.
I applied patch #4 on Drupal version 9.5.2 with PHP 8.1.10, it's works fine for me. Please refer to the attachments.
Tested on Drupal 9.5 with Environment Indicator 4.0.14
MR !20 worked for me.
Refer to attached screenshots. Thank you!
MR !1 works fine in drupa 9.5 with php version 8.1.
Hi Kamlesh Kishor Jha,
I have tested the MR !1 in drupa 9.5 it works fine for me.
But Could you please create a patch file and submit it on this issue?
I applied the MR !8 on Drupal version 9.5.2 with PHP 8.1.10, it's works fine for me. Please check attachments.
MR !19 Works fine for me on Drupal 9.5 .
Hi @noorulshameera,
patch on comment #2 works fine for me on drupal 9.5.
Hi @Jay The Merge request was fine for me in Drupal 9.5
Here I attached the screenshot of before and after MR apply.