Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 6 July 2023, over 1 year ago
Updated 19 September 2024, 3 months ago

Problem/Motivation

FILE: /home/system/Documents/contribution/config_policy/src/Policy/ConfigPolicyService.php
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
  93 | ERROR   | Expected type hint "bool"; found "ConfigPolicyInterface" for $target_policy
  93 | ERROR   | Expected type hint "bool"; found "ConfigRuleInterface" for $target_rule
 262 | WARNING | The use of function fnmatch() is discouraged
---------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/config_policy/tests/src/Kernel/KernelConfigPolicyBase.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 54 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------

Time: 354ms; Memory: 10MB

FILE: /home/system/Documents/contribution/config_policy/tests/src/Functional/UiConfigRuleTest.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 10 | WARNING | Class name must be prefixed with the project name "ConfigPolicy"
-------------------------------------------------------------------------------------------------

Time: 276ms; Memory: 8MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_policy/

Remaining tasks

Fix remaining issue if valid, review the patch.

📌 Task
Status

Needs work

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India urvashi_vora Madhya Pradesh, India

    Marking it to Needs Review, so that the initial patch could be reviewed.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India Ashutosh Ahirwal India

    Provided patch applied cleanly but still there are phpcs error found.

    Command used:-
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/config_policy

    Remaining errors
    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/tests/src/Functional/UiConfigRuleTest.php
    --------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
    --------------------------------------------------------------------------------------------------------------------------------
    10 | WARNING | Class name must be prefixed with the project name "ConfigPolicy"
    12 | ERROR | Missing member variable doc comment
    13 | ERROR | Missing member variable doc comment
    14 | ERROR | Missing member variable doc comment
    --------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/tests/src/Kernel/KernelConfigPolicyBase.php
    -------------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    -------------------------------------------------------------------------------------------------------------------------------------
    21 | ERROR | Missing member variable doc comment
    23 | ERROR | Missing member variable doc comment
    24 | ERROR | Missing member variable doc comment
    26 | ERROR | Missing member variable doc comment
    33 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
    -------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Rule/ConfigRuleFormBase.php
    ---------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    ---------------------------------------------------------------------------------------------------------------------------
    22 | ERROR | Missing member variable doc comment
    23 | ERROR | Missing member variable doc comment
    50 | ERROR | Missing parameter comment
    51 | ERROR | Missing parameter comment
    ---------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Rule/ConfigRuleConfirmFormBase.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Entity\ConfigPolicyInterface.
    -------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Rule/ConfigRuleEditForm.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------
    6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Entity\ConfigPolicyInterface.
    -------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Rule/ConfigRuleAddForm.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------
    7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Rule\ConfigRulePluginManager.
    -------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Rule/ConfigRuleDeleteForm.php
    -------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------
    21 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
    -------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Policy/ConfigPolicyEditForm.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -------------------------------------------------------------------------------------------------------------------------------
    92 | ERROR | [x] Array indentation error, expected 14 spaces but found 12
    93 | ERROR | [x] Array indentation error, expected 14 spaces but found 12
    -------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Policy/ConfigPolicyDeleteForm.php
    ---------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------------------
    9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
    ---------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Policy/ConfigPolicyValidateForm.php
    -----------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    -----------------------------------------------------------------------------------------------------------------------------------
    25 | ERROR | Missing member variable doc comment
    26 | ERROR | Missing member variable doc comment
    27 | ERROR | Missing member variable doc comment
    28 | ERROR | Missing member variable doc comment
    29 | ERROR | Missing member variable doc comment
    -----------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Form/Policy/ConfigPolicyFormBase.php
    --------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    --------------------------------------------------------------------------------------------------------------------------------------------
    10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Entity\ConfigPolicyInterface.
    17 | ERROR | [ ] Missing member variable doc comment
    18 | ERROR | [ ] Missing member variable doc comment
    19 | ERROR | [ ] Missing member variable doc comment
    --------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ValidationResultInterface.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/FixResultInterface.php
    ------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    10 | ERROR | Doc comment is empty
    ------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultItem/ResultItemBase.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    -------------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | Doc comment is empty
    13 | ERROR | Missing member variable doc comment
    14 | ERROR | Missing member variable doc comment
    15 | ERROR | Missing member variable doc comment
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultItem/WarningResultItem.php
    ----------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    10 | ERROR | Missing member variable doc comment
    11 | ERROR | Missing member variable doc comment
    ----------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultItem/ErrorResultItem.php
    --------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    --------------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    10 | ERROR | Missing member variable doc comment
    11 | ERROR | Missing member variable doc comment
    --------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultItem/OkResultItem.php
    -----------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    10 | ERROR | Missing member variable doc comment
    11 | ERROR | Missing member variable doc comment
    -----------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultItem/ResultItemInterface.php
    ------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | Doc comment is empty
    ------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultBase.php
    ----------------------------------------------------------------------------------------------------------------
    FOUND 6 ERRORS AFFECTING 6 LINES
    ----------------------------------------------------------------------------------------------------------------
    7 | ERROR | Doc comment is empty
    12 | ERROR | Missing short description in doc comment
    24 | ERROR | Missing short description in doc comment
    25 | ERROR | Description for the @return value is missing
    31 | ERROR | Missing short description in doc comment
    32 | ERROR | Description for the @return value is missing
    ----------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Result/ResultInterface.php
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ---------------------------------------------------------------------------------------------------------------------
    7 | ERROR | Doc comment is empty
    17 | ERROR | Missing short description in doc comment
    18 | ERROR | Description for the @return value is missing
    22 | ERROR | Missing short description in doc comment
    23 | ERROR | Description for the @return value is missing
    ---------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Entity/ConfigPolicy.php
    ------------------------------------------------------------------------------------------------------------------
    FOUND 11 ERRORS AFFECTING 11 LINES
    ------------------------------------------------------------------------------------------------------------------
    53 | ERROR | Missing member variable doc comment
    54 | ERROR | Missing member variable doc comment
    55 | ERROR | Missing member variable doc comment
    56 | ERROR | Missing member variable doc comment
    57 | ERROR | Missing member variable doc comment
    58 | ERROR | Missing member variable doc comment
    59 | ERROR | Missing member variable doc comment
    127 | ERROR | Doc comment for parameter $rule does not match actual variable name
    153 | ERROR | Parameter $config_rule is not described in comment
    156 | ERROR | Doc comment for parameter $configuration does not match actual variable name $config_rule
    171 | ERROR | Doc comment for parameter $config_rule does not match actual variable name
    ------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Plugin/ConfigPolicyRule/EmptyEntityViewDisplay.php
    ------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------------
    9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Result\ResultItem\ErrorResultItem.
    ------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Controller/ConfigPolicyListBuilder.php
    ---------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------
    11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Entity\ConfigPolicyInterface.
    53 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
    54 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
    88 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
    101 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
    ---------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/ConfigRulePluginManager.php
    ---------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------------------------------
    10 | ERROR | Doc comment is empty
    14 | ERROR | Missing member variable doc comment
    ---------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/FixableRuleInterface.php
    ------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | Doc comment is empty
    ------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/ConfigRuleInterface.php
    -----------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------
    11 | ERROR | Doc comment is empty
    -----------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/WeightedRuleInterface.php
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    -------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/ConditionalRuleInterface.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------
    7 | ERROR | Doc comment is empty
    ----------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/WeightedConfigRuleBase.php
    --------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    --------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/ConfigRuleBase.php
    ------------------------------------------------------------------------------------------------------------------
    FOUND 7 ERRORS AFFECTING 7 LINES
    ------------------------------------------------------------------------------------------------------------------
    14 | ERROR | Doc comment is empty
    19 | ERROR | Missing member variable doc comment
    21 | ERROR | Missing member variable doc comment
    23 | ERROR | Missing member variable doc comment
    25 | ERROR | Missing member variable doc comment
    27 | ERROR | Missing member variable doc comment
    29 | ERROR | Missing member variable doc comment
    ------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/ValidatableRuleInterface.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | Doc comment is empty
    ----------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Rule/PreventableRuleInterface.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------
    7 | ERROR | Doc comment is empty
    ----------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/EventSubscriber/ConfigEventsSubscriber.php
    -------------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------------------------------------------
    18 | ERROR | Missing member variable doc comment
    19 | ERROR | Missing member variable doc comment
    20 | ERROR | Missing member variable doc comment
    -------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Drush/Commands/ValidateCommand.php
    --------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    --------------------------------------------------------------------------------------------------------------------------------------
    17 | ERROR | Missing member variable doc comment
    30 | ERROR | Parameter $options is not described in comment
    33 | ERROR | Missing parameter type
    56 | ERROR | The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines
    --------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Policy/ConfigPolicyService.php
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 12 ERRORS AND 1 WARNING AFFECTING 10 LINES
    -------------------------------------------------------------------------------------------------------------------------
    26 | ERROR | Doc comment is empty
    31 | ERROR | Missing member variable doc comment
    32 | ERROR | Missing member variable doc comment
    33 | ERROR | Missing member variable doc comment
    59 | ERROR | Missing short description in doc comment
    59 | ERROR | Parameter $on_import is not described in comment
    59 | ERROR | Parameter $target_policy is not described in comment
    59 | ERROR | Parameter $target_rule is not described in comment
    60 | ERROR | Missing parameter comment
    61 | ERROR | Missing parameter comment
    63 | ERROR | Description for the @return value is missing
    234 | WARNING | The use of function fnmatch() is discouraged
    255 | ERROR | Missing short description in doc comment
    -------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Policy/ConfigPolicyServiceInterface.php
    ----------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------
    12 | ERROR | Doc comment is empty
    ----------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Policy/ConfigPolicyRepositoryInterface.php
    -------------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------------------------------------------
    5 | ERROR | Doc comment is empty
    13 | ERROR | Description for the @return value is missing
    20 | ERROR | Description for the @return value is missing
    -------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/config_policy/src/Policy/ConfigPolicyRepository.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ----------------------------------------------------------------------------------------------------------------------------
    9 | ERROR | Doc comment is empty
    14 | ERROR | Missing member variable doc comment
    15 | ERROR | Missing member variable doc comment
    28 | ERROR | Description for the @return value is missing
    39 | ERROR | Description for the @return value is missing
    ----------------------------------------------------------------------------------------------------------------------------

    Time: 1.21 secs; Memory: 14MB

  • Assigned to shiv_yadav
  • Comment about 1 year ago →
    🇮🇳India shiv_yadav
  • Issue was unassigned.
  • Comment about 1 year ago →
    🇮🇳India shiv_yadav
  • Assigned to gaurav gupta
  • Comment about 1 year ago →
    gaurav gupta Jaipur, Rajasthsan
  • Issue was unassigned.
  • Comment about 1 year ago →
    gaurav gupta Jaipur, Rajasthsan
  • First commit to issue fork.
  • Comment about 1 year ago →
    bindu r

    bindu r → made their first commit to this issue’s fork.

  • First commit to issue fork.
  • Comment 12 months ago →
    🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan

    As Per The #3 issue list and CMD i solved the issues reported by PHPCS.
    just one issue is not resolved. listed below..

    9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\config_policy\Result\ResultItem\ErrorResultItem.
  • Assigned to nitin_lama
  • Comment 12 months ago →
    🇮🇳India nitin_lama India
  • Comment 12 months ago →
    🇮🇳India nitin_lama India

    Providing the updated patch. Updating IS with remaining issues.

  • Comment 12 months ago →
    🇮🇳India nitin_lama India

    Please review.

  • Issue was unassigned.
  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇮🇳India nitin_lama India
  • Comment 12 months ago →
    🇮🇳India chandansha

    As Per The #13 issue list and CMD i solved the issues reported by PHPCS.
    listed below issue is not resolved.

    262 | WARNING | The use of function fnmatch() is discouraged

    10 | WARNING | Class name must be prefixed with the project name "ConfigPolicy"

    please review

  • Comment 9 months ago →
    🇮🇳India Yashaswi18

    The patch provided in #16 applied cleanly without checking out to any branch, found these errors remaining :

    phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml config_policy/

FILE: /home/yashaswi/contribs/config_policy/src/Policy/ConfigPolicyService.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------
 262 | WARNING | The use of function fnmatch() is discouraged
------------------------------------------------------------------------------


FILE: /home/yashaswi/contribs/config_policy/tests/src/Kernel/KernelConfigPolicyBase.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 54 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over
    |       | multiple lines
------------------------------------------------------------------------------------------------------------------------
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    a.aaronjake

    Hi @everyone,

    The patch that was provided on the comment #16 can be applied successfully, but it still throws multiple errors, mostly 'Multi-line function declarations'. Please see below:

    ➜  config_policy git:(master) ✗ curl https://www.drupal.org/files/issues/2023-12-20/3372877-16.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  102k  100  102k    0     0   241k      0 --:--:-- --:--:-- --:--:--  246k
patching file README.md
patching file config_policy.module
patching file drush.services.yml
patching file src/Annotation/ConfigPolicyRule.php
patching file src/Controller/ConfigPolicyController.php
patching file src/Controller/ConfigPolicyListBuilder.php
patching file src/Drush/Commands/ValidateCommand.php
patching file src/Entity/ConfigPolicy.php
patching file src/Entity/ConfigPolicyInterface.php
patching file src/EventSubscriber/ConfigEventsSubscriber.php
patching file src/Form/Policy/ConfigPolicyDeleteForm.php
patching file src/Form/Policy/ConfigPolicyEditForm.php
patching file src/Form/Policy/ConfigPolicyFormBase.php
patching file src/Form/Policy/ConfigPolicyValidateForm.php
patching file src/Form/Rule/ConfigRuleAddForm.php
patching file src/Form/Rule/ConfigRuleConfirmFormBase.php
patching file src/Form/Rule/ConfigRuleDeleteForm.php
patching file src/Form/Rule/ConfigRuleEditForm.php
patching file src/Form/Rule/ConfigRuleFormBase.php
patching file src/Plugin/ConfigPolicyRule/EmptyEntityViewDisplay.php
patching file src/Plugin/ConfigPolicyRule/EntityViewDisplayWeight.php
patching file src/Plugin/ConfigPolicyRule/ModulesDisallowedRule.php
patching file src/Plugin/ConfigPolicyRule/NonReusableField.php
patching file src/Plugin/ConfigPolicyRule/RequiredField.php
patching file src/Policy/ConfigPolicyRepository.php
patching file src/Policy/ConfigPolicyRepositoryInterface.php
patching file src/Policy/ConfigPolicyService.php
patching file src/Policy/ConfigPolicyServiceInterface.php
patching file src/Result/FixResult.php
patching file src/Result/FixResultInterface.php
patching file src/Result/ResultBase.php
patching file src/Result/ResultInterface.php
patching file src/Result/ResultItem/ErrorResultItem.php
patching file src/Result/ResultItem/OkResultItem.php
patching file src/Result/ResultItem/ResultItemBase.php
patching file src/Result/ResultItem/ResultItemInterface.php
patching file src/Result/ResultItem/WarningResultItem.php
patching file src/Result/ValidationResult.php
patching file src/Result/ValidationResultInterface.php
patching file src/Rule/ConditionalRuleInterface.php
patching file src/Rule/ConfigRuleBase.php
patching file src/Rule/ConfigRuleInterface.php
patching file src/Rule/ConfigRulePluginCollection.php
patching file src/Rule/ConfigRulePluginManager.php
patching file src/Rule/FixableRuleInterface.php
patching file src/Rule/PreventableRuleInterface.php
patching file src/Rule/ValidatableRuleInterface.php
patching file src/Rule/WeightedConfigRuleBase.php
patching file src/Rule/WeightedRuleInterface.php
patching file tests/src/Functional/UiConfigPolicyBase.php
patching file tests/src/Functional/UiConfigPolicyTest.php
patching file tests/src/Functional/UiConfigPolicyValidateTest.php
patching file tests/src/Functional/UiConfigRuleTest.php
patching file tests/src/Kernel/KernelConfigPolicyBase.php
patching file tests/src/Kernel/KernelConfigPolicyRepositoryTest.php
patching file tests/src/Kernel/KernelConfigPolicyServiceTest.php
➜  config_policy git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig config_policy

FILE: ...eb/modules/contrib/config_policy/tests/src/Functional/UiConfigRuleTest.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | WARNING | Class name must be prefixed with the project name
    |         | "ConfigPolicy"
--------------------------------------------------------------------------------


FILE: .../modules/contrib/config_policy/src/Form/Rule/ConfigRuleConfirmFormBase.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 46 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/config_policy/src/Form/Rule/ConfigRuleEditForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...e-v9/web/modules/contrib/config_policy/src/Form/Rule/ConfigRuleAddForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 30 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/config_policy/src/Rule/ConfigRulePluginManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 28 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...9/web/modules/contrib/config_policy/src/Drush/Commands/ValidateCommand.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 63 | ERROR | [x] The first parameter of a multi-line function declaration must
    |       |     be on the line after the opening bracket
 64 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 64 | ERROR | [x] The closing parenthesis of a multi-line function declaration
    |       |     must be on a new line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ue-v9/web/modules/contrib/config_policy/src/Policy/ConfigPolicyService.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
  60 | ERROR   | [x] Multi-line function declarations must have a trailing
     |         |     comma after the last parameter
 262 | WARNING | [ ] The use of function fnmatch() is discouraged
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.5 secs; Memory: 14MB

    Kindly check

    Thanks,
    Jake

  • Assigned to priyanka_chauhan31
  • Comment 3 months ago →
    🇮🇳India priyanka_chauhan31 Noida
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024