- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:17am 21 March 2023 The last submitted patch, 2: 3349232-2.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 4:54am 21 March 2023 - First commit to issue fork.
- Assigned to sagarTiwari
- Issue was unassigned.
- @shivam_tiwari opened merge request.
- Status changed to Needs review
over 1 year ago 8:07am 21 March 2023 - Status changed to Needs work
over 1 year ago 8:56am 21 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The tests are failing for a reason. See the plain diff of the latest MR created.
- Status changed to Needs review
over 1 year ago 10:38am 30 May 2023 - last update
over 1 year ago 2 pass, 2 fail The last submitted patch, 11: fix_coding_standard-3349232-11.patch, failed testing. View results →
- Status changed to Needs work
9 months ago 4:21am 8 February 2024 - 🇮🇳India Shank115
I applied the patch provided in #13 and it applied successfully.
- 🇮🇳India zkhan.aamir
Remaining issues after patch #13.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml representative_image/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\Field\FieldFormatter\EntityReferenceRepresentativeImage.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\representative_image\src\Plugin\migrate\source\FieldConfig.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 42 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ------------------------------------------------------------------------------------------------------------------------------------------- Time: 421ms; Memory: 12MB - Assigned to nitin_lama
- last update
9 months ago 2 pass, 2 fail - last update
9 months ago 2 pass, 2 fail - Issue was unassigned.
- Status changed to Needs review
9 months ago 12:25pm 29 February 2024 The last submitted patch, 13: phpcs_fix.patch, failed testing. View results →
The last submitted patch, 18: 3349232-18.patch, failed testing. View results →