- Issue created by @sahil.goyal
- Status changed to Needs review
almost 2 years ago 7:21am 6 February 2023 - ๐ฎ๐ณIndia sahil.goyal
Fixing all the php coding standard issues and warnings in this patch. Please Review.
- Assigned to Charchil Khandelwal
- Merge request !9Issue #3339496: Drupal Coding Standards Issues | phpcs โ (Open) created by Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
Patch #2 tested and applied successfully, all errors and warnings are fixed now.
Created MR !9 for this issue.
Please review.Thanks.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 8:20pm 1 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** * @file - * Describes hooks and plugins provided by the Corresponding entities references module. + * Corresponding entities module offers hooks & plugins for references. */
The correct short description for those files is Describes hooks provided by the [module name] module.
- * Differences arrary calculated by CorrespondingReference::calculateDifferences() + * Diff. arrary calculated by CorrespondingReference::calculateDifferences()
The existing description is correct, except for a typo.
function hook_cer_differences_alter(\Drupal\Core\Entity\ContentEntityInterface $entity, - array &$differences, $correspondingField) { + array &$differences, + $correspondingField) {
As per Drupal coding standards, function declarations are written in a single line.
+ /** + * Builds the header row for the entity listing. + */ public function buildHeader() {
The return value is not documented.
+ /** + * Builds the row for the entity listing. + */ public function buildRow(EntityInterface $entity) {
Parameters and return value descriptions are missing.
- First commit to issue fork.
- First commit to issue fork.
- last update
10 months ago 2 pass - Status changed to Needs review
10 months ago 2:59pm 28 February 2024 - Status changed to Needs work
5 months ago 7:32am 11 July 2024 Hi @sakthi_dev,
Your changes on the MR !9 was applied not-so successfully and errors were reported. Please see below:
cer git:(5.x) curl https://git.drupalcode.org/project/cer/-/merge_requests/9.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 21604 0 21604 0 0 45057 0 --:--:-- --:--:-- --:--:-- 46560 patching file README.md patching file cer.api.php patching file cer.module patching file src/CorrespondingReferenceListBuilder.php patching file src/CorrespondingReferenceOperations.php patching file src/CorrespondingReferenceStorage.php patching file src/CorrespondingReferenceStorageInterface.php patching file src/Entity/CorrespondingReference.php patching file src/Entity/CorrespondingReferenceInterface.php patching file src/EventSubscriber/CerSubscriber.php patching file src/Form/CorrespondingReferenceDeleteForm.php patching file src/Form/CorrespondingReferenceForm.php Hunk #7 succeeded at 186 (offset 1 line). Hunk #8 succeeded at 206 (offset 1 line). Hunk #9 succeeded at 245 (offset 1 line). Hunk #10 succeeded at 268 (offset 1 line). Hunk #11 succeeded at 279 (offset 1 line). Hunk #12 succeeded at 306 (offset 1 line). Hunk #13 succeeded at 315 (offset 1 line). patching file src/Form/CorrespondingReferenceSyncForm.php โ cer git:(5.x) โ cd .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cer FILE: ...etInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/cer/cer.api.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 83 characters -------------------------------------------------------------------------------- FILE: ...-orgissue-v9/web/modules/contrib/cer/src/Entity/CorrespondingReference.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\cer\CorrespondingReferenceOperations. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...issue-v9/web/modules/contrib/cer/src/CorrespondingReferenceListBuilder.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\cer\Entity\CorrespondingReferenceInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 545ms; Memory: 12MB
Kindly check
Thanks,
Jake- First commit to issue fork.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3339496-drupal-coding-standards to hidden.
- Status changed to RTBC
5 months ago 10:10am 11 July 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
MR !9 did not fix all the reported warnings/errors, contrarily to MR !16.