- 🇮🇹Italy apaderno Brescia, 🇮🇹
+/** + * The IntervalItemInterface interface. + */ interface IntervalItemInterface {
That description just repeats the interface name without saying what the interface does.
/** + * Set the default field storage backend for fields created during tests. + * * @inheritDoc */
Since that comment is edited,
@inheritDoc
must be replaced by{@inheritdoc}
. - Assigned to nitin_lama
- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Issues should be assigned to somebody who creates a patch or a MR in the next hours, not after more than four hours. This means blocking an issue for which somebody else could have worked on.
- Assigned to nitin_lama
- last update
over 1 year ago 2 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:34am 15 May 2023 - Status changed to Needs work
over 1 year ago 12:32pm 15 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
* @param \Traversable $namespaces * An object that implements \Traversable which contains the root paths - * keyed by the corresponding namespace to look for plugin implementations, + * keyed by the corresponding namespace to look for plugin implementations,.
In English, a comma is not used before a period.
/** * Profile to use. + * + * @var string */ protected $profile = 'testing'; /** * Theme to use. + * + * @var string */ protected $defaultTheme = 'stark';
Since those comments are edited, the definite article that is missing in each description should be added too.
* @var \Drupal\field\Entity\FieldStorageConfig + * The FieldStorageConfig. */ protected $fieldStorage;
The description must not repeat the class/interface name.
/** - * @inheritDoc + * Set the default field storage backend for fields created during tests.
The first verb must use the third person singular.
- // Verify initial field value + // Verify initial field value.
There is a missing definite article.
- First commit to issue fork.
- last update
over 1 year ago 2 pass - Status changed to Needs review
over 1 year ago 1:32pm 15 May 2023 - Status changed to Needs work
over 1 year ago 7:27am 30 May 2023 - First commit to issue fork.
- Assigned to nitin_lama
- last update
11 months ago 1 pass, 2 fail - First commit to issue fork.
- last update
10 months ago 1 pass, 2 fail - Status changed to Closed: duplicate
5 months ago 10:07pm 26 July 2024