add gitlabci

larowlan → credited anoopsingh92 → .

larowlan → credited nitin_lama → .

larowlan → credited sakthi_dev → .

larowlan → credited samit.310@gmail.com → .

Crediting folks from 📌 Fix the issues reported by phpcs Needs work

Fixed failed phpunit test cases.

Thanks
Samit K.

d11 here we come, 21 modules down, 38 to go

This change does a lot more than just add gitlabci. :)

This commit breaks sites running 9.x and 10.x prior to 10.3, since it uses the new Base classes introduced in 10.3.

Since the deprecated classes won't actually be removed until D12, seems those changes should reverted.

Specifically:

-use Drupal\Core\Render\Element\FormElement;
+use Drupal\Core\Render\Element\FormElementBase;

and

-class Interval extends FormElement {
+class Interval extends FormElementBase {

Then, a new version that only supports 10.3 or later can be created with these changes.

Thanks, can do - are you able to create an MR?

@larowlan

I can create an MR, yes.

Thanks @TomTech - I'm tagging 8.x-1.14 now

https://www.drupal.org/project/interval/releases/8.x-1.14 → is packaging now 💪 🏎️

Automatically closed - issue fixed for 2 weeks with no activity.