Coding standards

Uploading file with latest PHPCS review and generated patch #29 → .

I read notes from #28 several times and those are some considerations while creating this patch:

1. Drush Commands vs Dependecy Injection: I added Ignore Flags on all so we don't need to go trough this discussion again.
2. Drupal t(): Also did the same: using Ignore Flags to remove it.
3. Voting API file: In the end of it there is a abstract example of Storage changing. I tried to fill all "Todo" flags there but also Ignoring that file made sense to me.
4. VoteTypeAccessControlHandler.php: DID NOTHING AT ALL. My honest opinion is that this should be deleted, so I prefer to investigate it in a new issue instead of this one.

TR said:

Yes, the CS warning will remain, and that's OK.

He did not suggest to add @codingStandardsIgnoreLine to all the lines that must not be changed. He said to ignore the warnings/errors for those lines that should not be changed, or that should be changed in a different issue.

diff --git a/entity.module b/entity.module
index b1a72ef..562e322 100644
--- a/entity.module
+++ b/entity.module

The last patch is not for this project, since there is any entity.module file in this project.

+/**
+ * @file
+ */
+
 use Drupal\Core\Entity\ContentEntityInterface;

Leaving out the patch is not for this project, TR already explained that is the wrong type of changes to do. That documentation comment requires a short description, after the line containing @file; adding just the line containing @file to avoid a PHP_CodeSniffer warning/error is not the type of changes he will accept.

Please review patch.

The last submitted patch, 38: 3003096-38.patch, failed testing. View results →

Please ignore #38.

The last submitted patch, 40: 3003096-39.patch, failed testing. View results →

Please review patch.

No, and I really don't feel like repeating myself.

 /**
- * Voting API's vote storage can be overridden by setting the
- * 'votingapi_vote_storage' state variable to an alternative class.
+ * Voting API's.
  */
-\Drupal::state()->set('votingapi_vote_storage', 'Mongodb_VoteStorage');
+// Vote storage can be overridden by .
+// setting the 'votingapi_vote_storage'state variable to an alternative class.
+\Drupal::state()->set('votingapi_vote_storage', 'VotingApi');

Replacing a full sentence with Voting API's is not a correct change, as it is not correct to split a sentence in a phrase and a sentence.
Furthermore, why is the class name changed?

+   * @param int $vote
    *   instance of VotingApi_Vote.
    */
   public function addVote(&$vote) {

If $vote is an object, it cannot be an integer.