🇧🇷Brazil @Diego_Mow

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Following @diegors sugestion at #6, I made the following changes to MR !37:

• Added a tab called Iframes
• Moved both video link and external page fields inside it
• Create a form validation to avoid both fields being filled
• Create a states conditional to prevent this on clientside

Diego_Mow → made their first commit to this issue’s fork.

Tested this with Drupal 10.1.x and result is that I cannot edit an existing form:

The website encountered an unexpected error. Please try again later.

TypeError: strlen(): Argument #1 ($string) must be of type string, array given in strlen() (line 395 of core/lib/Drupal/Component/Utility/Unicode.php).
Drupal\Component\Utility\Unicode::validateUtf8(Array) (Line: 65)
Drupal\Component\Utility\Xss::filter(Array, Array) (Line: 70)
Drupal\editor\EditorXssFilter\Standard::filterXss(Array, Object, NULL) (Line: 349)
editor_filter_xss(Array, Object) (Line: 109)
Drupal\editor\Element->preRenderTextFormat(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 231)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 168)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Good cache alexpott. This was mistakenly changed.

Adding patch 103 without this change.

smustgrave → credited Diego_Mow → .

Fixed Coding Standards on test file.

Patch #100 goes with followed suggestion: use key #inline_form_errors_summary

Note: we also have #disable_inline_form_errors, so consistency about naming here is really broken.
My honest suggestion is that we have this issue solved since this feature is really overtime and open a task to discuss only consistency of naming for those keys.

Diego_Mow → made their first commit to this issue’s fork.

Diego_Mow → created an issue.

If possible, I would like to rise issue #2985887 📌 Make core's structure descriptions more consistent Closed: won't fix .
It looks pretty solid and quite good to go for the next release.

Diego_Mow → made their first commit to this issue’s fork.

Uploading file with latest PHPCS review and generated patch #29 → .

I read notes from #28 several times and those are some considerations while creating this patch:

1. Drush Commands vs Dependecy Injection: I added Ignore Flags on all so we don't need to go trough this discussion again.
2. Drupal t(): Also did the same: using Ignore Flags to remove it.
3. Voting API file: In the end of it there is a abstract example of Storage changing. I tried to fill all "Todo" flags there but also Ignoring that file made sense to me.
4. VoteTypeAccessControlHandler.php: DID NOTHING AT ALL. My honest opinion is that this should be deleted, so I prefer to investigate it in a new issue instead of this one.

Patch 92 worked in both 9.5 and 10.1.
I'm moving it to RTBC.

About AI generated summary, I reviewed it and looks pretty similar to initial summary.
It looks fine for me.

Both issues are RTBC.
I'd suggest we get them merged ASAP as they are blockers for future of this module.

IF it's a feature that was not ported yet, I'd suggest to create a separated task for it and remove unused statements on code.
It might improve module performance and security a lot!

About the patch, I reviewed and it's working fine, there are other issues in community solving it. (see related)

Suggestion is to close it as duplicated OR use this task to talk about D7 portability of this.

I fixed the rebase in MR 10 and also tested this branch.
Everything is working, so I'm moving to RTBC.

Diego_Mow → made their first commit to this issue’s fork.

Diego_Mow → made their first commit to this issue’s fork.

MR 50 fixes same code from MR 49 + Comments on #13.

Diego_Mow → made their first commit to this issue’s fork.

Diego_Mow → created an issue.

Thank you!
Opened 3 tasks for fixing those items.
Let's wait them to be fixed than we circle back with a new round of review.

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Diego_Mow → created an issue.

Diego_Mow → created an issue. See original summary → .

Diego_Mow → created an issue. See original summary → .

Fixed Patch apply.

Fixed Patch apply.

TBH, I see not wrong with description here.
However, Vertical Tab BG color is too light for the theme.

I will let this open to review after merging all pending patches.

Fix patch apply now.

After merge of #3321478 📌 Views dropdown label and text is not proper visible. Fixed this issue was solved as well.

Closing as Duplicated.

Using MR from #3 and it is working fine with several options.

Merge request from #15 worked fine for me!
https://git.drupalcode.org/issue/easy_breadcrumb-3323769/-/commit/c23485...