Create way to render external URL inside of Modal (iframe / embedded)

Created on 7 December 2022, about 2 years ago
Updated 5 May 2023, over 1 year ago

Problem/Motivation

Create way to render external URL inside of Modal (iframe / embedded)

Proposed resolution

We can use the same idea of YouTube. One field to put an "embedded" page.

Is optional, if the user put a link there, example google maps, so when this Modal is displayed we need to display the Google Maps inside of Modal using embed tag of HTML or iframe

📌 Task
Status

Needs work

Version

5.0

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @diego_mow opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇧🇷Brazil Diego_Mow

    Following @diegors sugestion at #6, I made the following changes to MR !37:

    • Added a tab called Iframes
    • Moved both video link and external page fields inside it
    • Create a form validation to avoid both fields being filled
    • Create a states conditional to prevent this on clientside

  • Status changed to Needs work over 1 year ago
  • 🇧🇷Brazil renatog Campinas

    Awesome! Definitely are valid updates, thanks a lot team

    I saw that the MR #37 can't be merged and is asking a rebase with the target branch. From GitLab:

    Merge blocked: fast-forward merge is not possible. To merge this request, first rebase locally.

    So I'm marking as "Needs work" to track this, ok?

  • @zeeshan_khan opened merge request.
  • First commit to issue fork.
  • First commit to issue fork.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India zeeshan_khan

    @kaustab700 - Changing status to needs review.

  • Assigned to sharayurajput
  • 🇮🇳India sharayurajput

    I will review this issue

  • 🇮🇳India sharayurajput

    Here iframe tab is added, and external links field and video link field is added to iframe tab but after submitting value modal is not visible in site

  • Issue was unassigned.
  • Status changed to Needs work over 1 year ago
  • 🇧🇷Brazil renatog Campinas

    after submitting value modal is not visible in site

    Based on that, I'm moving to "Needs work" ok?

Production build 0.71.5 2024