[1.0.x] Darcula Theme

Created on 22 April 2023, about 1 year ago
Updated 6 March 2024, 4 months ago

The objective of the Claro Darcula Theme is to get all Claro layout and give us the option to be a Dark Layout.
Darcula base colors were used for that.
This theme has only Admin Purposes, so it only works when used as an Admin theme.

Project link

https://www.drupal.org/project/darcula →

📌 Task
Status

Closed: won't fix

Component

theme

Created by

🇧🇷Brazil Diego_Mow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Diego_Mow
  • 🇮🇳India Rashmisoni Bangalore

    Please check PHPCS issues:

    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml darcula 
    
    FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/views-ui.css
    ------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ------------------------------------------------------
     180 | ERROR | [x] Multiple selectors should each be on a single line
     184 | ERROR | [x] Multiple selectors should each be on a single line
    ------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------
    
    
    FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/fieldset.css
    ------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------
     59 | ERROR | [x] Expected 1 space before opening brace of class definition; 2 found
    ------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------
    
    
    FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/action-link.css
    ---------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------
     27 | ERROR | [x] Expected 1 newline at end of file; 0 found
    ---------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------
    
    Time: 157ms; Memory: 10MB
    
    
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Thank you for applying!

    Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

    The important notes are the following.

    • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
    • For the time this application is open, only your commits are allowed.
    • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
    • We only accept an application per user. If you change your mind about the project to use for this application, please update the issue summary to give the link to the correct project link and the issue title to contain that project name.

    To the reviewers

    Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
    Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

    Remember to change status, since Active means the project is not yet ready for review. Needs review is the status used when the project is ready for review.

  • Status changed to Needs work about 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

    Have you made any other project (module, theme, distribution) that we could instead review?

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    I am changing priority as per Issue priorities → .

  • Status changed to Closed: won't fix 4 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

    If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.

    In this case, it is also necessary to use a different project for the application, as per my previous comments.

Production build 0.69.0 2024