- Issue created by @shashank5563
- last update
almost 2 years ago Custom Commands Failed - Status changed to Needs review
almost 2 years ago 1:50pm 21 April 2023 - last update
almost 2 years ago 29,300 pass - Status changed to Needs work
almost 2 years ago 11:14pm 22 April 2023 - 🇺🇸United States smustgrave
Seems like a valid feature request.
Should be simple to get in but could we add a small assertion to an existing test checking the title. Won't need it's own function or anything.
- 🇮🇳India shashank5563 New Delhi
@smustgrave, I have added an assertion to test the vocabulary title while updating the vocabulary.
Please see the Patch.
$this->assertSession()->pageTextContains('Edit vocabulary ' . $this->randomMachineName());
- last update
almost 2 years ago Custom Commands Failed - last update
almost 2 years ago 29,299 pass, 2 fail - 🇮🇳India shashank5563 New Delhi
Fix PHPCS issue.
vendor/bin/phpcbf --standard="Drupal,DrupalPractice" -n --extensions="php,module,inc,install,test,profile,theme" web/core/modules/taxonomy/tests/src/Functional/VocabularyUiTest.php
FILE: .../core/modules/taxonomy/tests/src/Functional/VocabularyUiTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
62 | ERROR | [x] Concat operator must be surrounded by a single
| | space
| | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------- - last update
almost 2 years ago 29,299 pass, 2 fail - last update
almost 2 years ago 29,300 pass, 2 fail - last update
almost 2 years ago Custom Commands Failed - Status changed to Needs review
almost 2 years ago 12:00pm 24 April 2023 - last update
almost 2 years ago 29,304 pass - last update
almost 2 years ago 29,304 pass - 🇳🇱Netherlands idebr
There is an earlier issue available at 📌 More specific titles for term and vocabulary edit forms Needs work that includes this change. The earlier issue contains test coverage and core committer feedback, so I suggest closing this issue as a duplicate.
- Status changed to Closed: duplicate
almost 2 years ago 10:22pm 24 April 2023 - 🇺🇸United States smustgrave
Agree the other ticket seems the better route to get the Edit Term name also.
Also @Diego_Mow and @shashank5563 for next time please include interdiffs with patches.