- Issue created by @hardikpandya
- @hardikpandya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:54am 14 March 2023 - Status changed to Needs work
over 1 year ago 8:03am 14 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** + * Set ReflectionClass object. + */
That does not describe what the method does. Then, parameters are not documented, nor is the return value.
- First commit to issue fork.
- @kkalashnikov opened merge request.
- Status changed to Needs review
over 1 year ago 3:58pm 17 April 2023 - First commit to issue fork.
- Status changed to Needs work
over 1 year ago 1:41pm 18 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- public function setProtectedProperty($object, $property, $value) { - $reflection = new \ReflectionClass($object); - $reflection_property = $reflection->getProperty($property); - $reflection_property->setAccessible(true); - $reflection_property->setValue($object, $value); - }
What reported by PHP_CodeSniffer and shown in the issue summary does not say that method must be removed.
- First commit to issue fork.
- @sakthi_dev opened merge request.
- Status changed to Needs review
over 1 year ago 11:56am 20 April 2023 - Status changed to Needs work
over 1 year ago 8:39pm 20 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ * @param $object + * The object variable. + * @param $property + * The property variable. + * @param $value. + * The variable of value.
Parameters are not described that way. It is not a helpful description, since it repeats the parameter names, adding variable. (Yes, a parameter is a local variable accessible from the function/method. That is how PHP works.)
+ * @return NULL + * Returns Null. + */
If a method/function does not return anything,
@return
does not need to be added. - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 6:18pm 22 April 2023 - ๐ง๐ทBrazil Diego_Mow
MR 50 fixes same code from MR 49 + Comments on #13.
- ๐ฌ๐งUnited Kingdom Alina Basarabeanu
I applied the changes from MR 50 to Drupal Version 9.5.10 and Password Policy 4.0.0 but I still get a lot of phpcs errors.
I will list just a few.FILE: /docroot/modules/contrib/password_policy/password_policy_delay/src/Plugin/PasswordConstraint/PasswordDelay.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Password\PasswordInterface.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------FILE: /docroot/modules/contrib/password_policy/PATCHES.txt
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
5 | ERROR | [x] Expected 1 newline at end of file; 3 found
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------FILE: /docroot/modules/contrib/password_policy/password_policy.module
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLYFILE: /docroot/modules/contrib/password_policy/password_policy_history/tests/src/Unit/PasswordHistoryTest.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Password\PasswordInterface.
22 | ERROR | [x] Data types in @var tags need to be fully namespaced
129 | ERROR | [x] Expected 1 blank line after function; 0 found
130 | ERROR | [ ] Parameter $value is not described in comment
137 | ERROR | [x] Doc comment parameter name "$value." must not end with a dot
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------- - Status changed to Needs work
9 months ago 3:55am 5 February 2024 - ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 5:21am 5 February 2024 - Assigned to Kristen Pol
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Assigning to myself for review.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Duplicate issue found. I'll need to close one of these.
๐ Fix the issues reported by phpcs Needs work
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3347789-phpcs to hidden.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch phpcs-3347789 to hidden.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
apaderno โ changed the visibility of the branch 3347789-fix-phpcs-issues to hidden.
- Issue was unassigned.
- Status changed to Needs work
9 months ago 10:46pm 22 February 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Merge conflict needs fixing.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Copying issue credits for people who worked on duplicate issue:
๐ Fix the issues reported by phpcs Needs work
- Status changed to Closed: outdated
3 months ago 3:41pm 11 August 2024 - ๐ฎ๐ณIndia vishalkhode
Closing as this is fixed in ๐ Fix Validate pipeline Fixed .