- Issue created by @arti_parmar
- Assigned to arti_parmar
- Status changed to Needs review
over 1 year ago 1:51pm 15 June 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 3:30pm 15 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
-- Externally authenticated users (via `externalauth` module) are excluded from validation and time-based expiration +- Externally authenticated users (via `externalauth` module) are excluded +from validation and time-based expiration
Since that text is part of a list, the last line must be indented.
function _password_policy_history_insert_password_hash(AccountInterface $account) { - if (empty($_POST['pass']['pass1']) || empty($_POST['pass']['pass2'])) { + $request = \Drupal::service('request_stack')->getCurrentRequest(); + $pass = $request->get('pass'); + if (empty($pass['pass1']) || empty($pass['pass2'])) { return; }
_password_policy_history_insert_password_hash()
is called bypassword_policy_history_user_update()
, which is ahook_ENTITY_TYPE_update()
implementation. It should not assume the password is contained in$_POST['pass']['pass1']
nor$request->get('pass')
, as it is not necessarily called after a user form is submitted. - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:30am 22 June 2023 - Status changed to Needs work
over 1 year ago 8:19am 22 June 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Duplicate issue found. I'll need to close one of these.
📌 Fix the issues reported by phpcs Needs review
- Issue was unassigned.
- Status changed to Closed: duplicate
9 months ago 10:47pm 22 February 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Closing this as duplicate of another issue that has had more work. I'll copy issue credits over.
📌 Fix the issues reported by phpcs Needs review