Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Attached patch for fix phpcs errors.

Hi Rajan Kumar,

I applied your patch #3 to Label Help module version 2.0.x-dev and confirmed that the PHPCS errors relating to label_help.module were fixed. However, I noticed a warning as I applied your patch, I ran the PHPCS command to the entire label_help module and an error below has been flagged.

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/label_help/config/schema/label_help.schema.yml
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/label_help/README.txt
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
62 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

Time: 247ms; Memory: 12MB

Please also look at the screenshots attached for your reference.

Thank you

Attached another patch for fix above phpcs errors.

Hi @Rajan Kumar,

I applied your patch #6 and confirmed that it applies cleanly and fixed all the PHPCS errors.

Please look at the screenshots attached for your reference

Thank you

The status is also for the issue summary that needs to be updated.

Rajan Kumar → closed merge request !3

Issue summary updated.

Hello, checked out to the branch '2.0.x' and ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml label_help/. Found no errors or warnings remaining.

I ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml and found no issues.

fixed the phpcs issues. please review.

It should be better to keep using MR!4, instead of creating a new merge request.

I agree with @apaderno. Once someone opens an MR, work must continue there.

apaderno → changed the visibility of the branch 3358092-fix-the-issues to hidden.

jwilson3 → closed merge request !6

Thanks to everyone who has contributed, working on fixes and running the tests manually. Also thank you for expanding scope to start using the .gitlab-ci.yaml file. I will be expanding upon that in a follow-up issue to included tests on older versions as well as newer versions of Drupal.

Finally, I've added a .ddev folder to the codebase to make setting up and running analysis tools like phpcs, and phpstan, as well as automated fix tools like phpcbf a no-brainer. See 📌 Add Ddev Drupal Contrib for ease-of-maintenance Fixed for details.

My apologies that I messed up the merge and forgot to get everyone's name into the commit message. I've credited everyone who's participated here via issue credit system.

Onward and upward.

Thanks again!

Automatically closed - issue fixed for 2 weeks with no activity.