Fix the issues reported by phpcs

FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/imageapi_optimize.install ---------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------- 60 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 61 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 67 | ERROR | [x] Expected newline after closing brace 67 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements ---------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php ---------------------------------------- FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES ---------------------------------------- 16 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 19 | ERROR | [x] The text '@deprecated in Drupal 8.0.x, will be removed before Drupal 9.0.x. Use | | \Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId() instead.' does not match the standard format: @deprecated in | | %deprecation-version% and is removed from %removal-version%. %extra-info%. 20 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters 22 | WARNING | [ ] The @see url '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n 24 | ERROR | [ ] Public method name "ImageAPIOptimizePipelineInterface::getReplacementID" is not in lowerCamel format 105 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeHookImplementations.php ---------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ---------------------------------------- 29 | ERROR | [ ] Public method name "ImageAPIOptimizeHookImplementations::entity_type_alter" is not in lowerCamel format 30 | WARNING | [x] The variable name should be defined after the type 44 | ERROR | [ ] Public method name "ImageAPIOptimizeHookImplementations::form_image_style_edit_form_alter" is not in lowerCamel format 59 | ERROR | [ ] Public method name "ImageAPIOptimizeHookImplementations::config_schema_info_alter" is not in lowerCamel format ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorBase.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 159 | ERROR | Doc comment is empty ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorInterface.php ---------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------- 22 | WARNING | Line exceeds 80 characters; contains 90 characters 49 | WARNING | Line exceeds 80 characters; contains 85 characters ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineStorageInterface.php ---------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------- 6 | WARNING | Line exceeds 80 characters; contains 92 characters 14 | WARNING | Line exceeds 80 characters; contains 93 characters 34 | WARNING | Line exceeds 80 characters; contains 90 characters ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineStorage.php ---------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------- 8 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 16 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters 36 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Exception/PluginNotFoundException.php ---------------------------------------- FOUND 7 ERRORS AFFECTING 6 LINES ---------------------------------------- 8 | ERROR | [x] Doc comment short description must end with a full stop 16 | ERROR | [ ] Missing member variable doc comment 18 | ERROR | [ ] Missing short description in doc comment 26 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [ ] Description for the @return value is missing 32 | ERROR | [x] Expected 1 newline at end of file; 0 found 32 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorPluginCollection.php ---------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------- 15 | ERROR | Description for the @return value is missing 17 | WARNING | Possible useless method overriding detected ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Annotation/ImageAPIOptimizeProcessor.php ---------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------- 39 | ERROR | The @var tag must be the first tag in a member variable comment 46 | WARNING | Line exceeds 80 characters; contains 81 characters 50 | ERROR | The @var tag must be the first tag in a member variable comment ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineListBuilder.php ---------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ---------------------------------------- 41 | ERROR | [ ] Missing parameter comment 42 | ERROR | [ ] Missing parameter comment 43 | ERROR | [ ] Missing parameter comment 79 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 80 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 ---------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Entity/ImageAPIOptimizePipeline.php ---------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES ---------------------------------------- 74 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters 82 | ERROR | [ ] Missing @var tag in member variable comment 136 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::replaceImageAPIOptimizePipeline" is not in lowerCamel format 180 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4 181 | ERROR | [x] Expected one space after the comma, 0 found 181 | ERROR | [x] Expected one space after the comma, 0 found 264 | ERROR | [ ] Public method name "ImageAPIOptimizePipeline::getReplacementID" is not in lowerCamel format 291 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::getImageAPIOptimizeProcessorPluginManager" is not in lowerCamel format ---------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Entity/ImageStyleWithPipeline.php ---------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES ---------------------------------------- 7 | ERROR | [ ] Doc comment is empty 12 | ERROR | [ ] Missing short description in doc comment 13 | WARNING | [x] '@TODO: maybe this should be something other than a 'random' string.' should match the format '@todo Fix problem X here.' 14 | ERROR | [ ] Missing @var tag in member variable comment 34 | ERROR | [ ] Doc comment is empty 41 | ERROR | [ ] Missing short description in doc comment 42 | ERROR | [ ] Description for the @return value is missing 61 | ERROR | [ ] Doc comment is empty ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/ImageStyleWithPipelineListBuilder.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 38 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizePipelineEditForm.php ---------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------- 56 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 74 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 132 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 143 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorDeleteForm.php ---------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------- 15 | WARNING | Line exceeds 80 characters; contains 87 characters 32 | ERROR | The array declaration extends to column 225 (the limit is 80). The array content should be split up over multiple lines ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorAddForm.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 56 | ERROR | Protected method name "ImageAPIOptimizeProcessorAddForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizePipelineDeleteForm.php ------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------- 61 | WARNING | Line exceeds 80 characters; contains 90 characters ------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorFormBase.php ---------------------------------------------------- FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ---------------------------------------------------- 39 | ERROR | Parameter $form is not described in comment 39 | ERROR | Parameter $form_state is not described in comment 81 | WARNING | Line exceeds 80 characters; contains 92 characters 105 | WARNING | Line exceeds 80 characters; contains 90 characters 116 | WARNING | Line exceeds 80 characters; contains 90 characters 139 | ERROR | Protected method name "ImageAPIOptimizeProcessorFormBase::prepareImageAPIOptimizeProcessor" is not in lowerCamel format ---------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeDefaultPipelineConfigForm.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 8 | ERROR | Doc comment is empty ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorEditForm.php ------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------- 28 | ERROR | Protected method name "ImageAPIOptimizeProcessorEditForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format ------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/imageapi_optimize.module ---------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------- 3 | ERROR | Missing short description in doc comment 13 | ERROR | Missing parameter type 16 | ERROR | Return type missing for @return tag in function comment ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/README.md ---------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------- 59 | WARNING | Line exceeds 80 characters; contains 96 characters ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/imageapi_optimize.api.php ----------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ----------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 100 characters 16 | ERROR | Missing parameter type 17 | WARNING | Line exceeds 80 characters; contains 90 characters ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageStyleFlushTest.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/QuickEditImageControllerTest.php ------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageDimensionsTest.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageOnTranslatedEntityTest.php ------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageFieldDisplayTest.php ------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageStylesPathAndUrlTest.php ---------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageFieldDefaultImagesTest.php ------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageFieldValidateTest.php ------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageAdminStylesTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageStyleDeleteTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/ImageFieldWidgetTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Functional/FileMoveTest.php ----------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/FunctionalJavascript/QuickEditImageTest.php ------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------- 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/FunctionalJavascript/ImageFieldValidateTest.php ------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/FunctionalJavascript/ImageAdminStylesTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageEffectsTest.php ----------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageFormatterTest.php ------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageOptimizePipelineTest.php --------------------------------------------------------- FOUND 19 ERRORS AND 2 WARNINGS AFFECTING 17 LINES --------------------------------------------------------- 18 | ERROR | [ ] The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines 21 | ERROR | [x] Doc comment short description must end with a full stop 137 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 139 | ERROR | [ ] Missing parameter comment 140 | ERROR | [ ] Missing parameter comment 141 | ERROR | [ ] Missing parameter comment 142 | ERROR | [ ] Missing parameter comment 142 | ERROR | [x] Expected 1 spaces after parameter type; 3 found 143 | ERROR | [ ] Missing parameter comment 143 | ERROR | [x] Expected 1 spaces after parameter type; 3 found 145 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 148 | ERROR | [x] Opening brace should be on the same line as the declaration 165 | ERROR | [ ] Missing parameter type 168 | ERROR | [ ] Missing parameter type 171 | ERROR | [ ] Missing parameter type 174 | ERROR | [x] Separate the @param and @return sections by a blank line. 174 | ERROR | [ ] Return type missing for @return tag in function comment 193 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 204 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead --------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageStyleIntegrationTest.php ------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageImportTest.php ---------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageItemTest.php -------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/Views/RelationshipUserImageDataTest.php ------------------------------------------ FOUND 4 ERRORS AFFECTING 3 LINES ------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Empty array declaration must have no space between the parentheses ------------------------------------------ PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/Views/ImageViewsDataTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageStyleCustomStreamWrappersTest.php ----------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/Migrate/d7/MigrateImageSettingsTest.php ------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------ FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/Migrate/d7/MigrateImageStylesTest.php ---------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/Migrate/d6/MigrateImageCacheTest.php ------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/src/Kernel/ImageThemeFunctionTest.php ----------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------- FILE: /var/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/module/imageapi_optimize_module_test/imageapi_optimize_module_test.info.yml ----------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ----------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ----------------------------------------------- FILE: ...r/www/html/contribution/web/modules/contrib/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorBlackPNG.php ------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------ 23 | ERROR | [x] Expected 1 blank line after function; 0 found 24 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------ FILE: ...ml/contribution/web/modules/contrib/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorAppendCharacters.php ------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------ 23 | ERROR | [x] Expected 1 blank line after function; 0 found 24 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------ FILE: ...html/contribution/web/modules/contrib/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorFailedGreenPNG.php ------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------ 26 | ERROR | [x] Expected 1 blank line after function; 0 found 27 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------

Comments & Activities

Issue created by @himanshu_jhaloya
Status changed to Needs work about 1 year ago10:44am 29 March 2023
Comment about 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
Merge request !5fixed-some-issue → (Open) created by himanshu_jhaloya
Issue was unassigned.
Comment about 1 year ago →
🇮🇳India himanshu_jhaloya Mandsaur
Comment about 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
To make it clearer, the issue summary does not show which arguments were passed to phpcs to get the quoted report.
First commit to issue fork.
Comment about 1 year ago →
🇮🇳India _pratik_ Banglore
There are some errors and warning left that need to be fixed, related to Drupal practice.
Comment about 1 year ago →
🇮🇳India Rashmisoni Bangalore
Comment about 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment 5 months ago →
🇮🇳India Preethy_ray
pray_12 → made their first commit to this issue’s fork.
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 5 months ago
Not currently mergeable.
Assigned to PrabuEla
Comment 5 months ago →
🇮🇳India PrabuEla chennai
Issue was unassigned.
Comment 5 months ago →
🇮🇳India PrabuEla chennai
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 5 months ago
56 fail
Comment 5 months ago →
🇮🇳India PrabuEla chennai
I have rebased the branch and fixed the conflict in README.md file
Comment 5 months ago →
🇮🇳India PrabuEla chennai
hey ,
There are still some error. please find it below.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/imageapi_optimize

FILE: /Users/prabue/Desktop/Projects/drupal-9/web/modules/contrib/imageapi_optimize/imageapi_optimize.api.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
22 | ERROR | Type hint "array" missing for $processors
-------------------------------------------------------------------------------------------------------------

FILE: /Users/prabue/Desktop/Projects/drupal-9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorPluginCollection.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/prabue/Desktop/Projects/drupal-9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | The @see url '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()' does not match the standard: http(s)://www.drupal.org/node/n or
| | http(s)://www.drupal.org/project/aaa/issues/n
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 806ms; Memory: 12MB
Comment 5 months ago →
🇮🇳India PrabuEla chennai
First commit to issue fork.

Comment 5 months ago →

🇮🇳India Yashaswi18

These issues are remaining

FILE: ...esktop\Contrib\imageapi_optimize\src\ImageAPIOptimizePipelineInterface.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | WARNING | The @see url
    |         | '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()'
    |         | does not match the standard: http(s)://www.drupal.org/node/n or
    |         | http(s)://www.drupal.org/project/aaa/issues/n
--------------------------------------------------------------------------------


FILE: ...ontrib\imageapi_optimize\src\ImageAPIOptimizeProcessorPluginCollection.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------

Time: 1.84 secs; Memory: 10MB

Comment 5 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Actually, as per Drupal coding standard → , @see \Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId() is correct.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 4 months ago
56 fail
Assigned to nitin_lama
Comment 4 months ago →
🇮🇳India nitin_lama
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 4 months ago
56 fail
Status changed to Needs review 4 months ago5:18am 26 February 2024
Comment 4 months ago →
🇮🇳India nitin_lama
Issue was unassigned.
Comment 4 months ago →
🇮🇳India nitin_lama

Comment 4 months ago →

🇮🇳India Preethy_ray

Hi,
Applied the MR!5 found one warning.


FILE: /imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
 23 | WARNING | The @see url '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()' does not match the standard:
    |         | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n
------------------------------------------------------------------------------------------------------------------------------------------------------------

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!5Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!5Fix the issues reported by phpcsOpen

Comments & Activities

!5Fix the issues reported by phpcs
Open