Fix the issues reported by phpcs

phpcs --standard=Drupal imageapi_optimize/ FILE: /var/www/patches/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorAppendCharacters.php ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------- 23 | ERROR | [x] Expected 1 blank line after function; 0 found 24 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorFailedGreenPNG.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 26 | ERROR | [x] Expected 1 blank line after function; 0 found 27 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorBlackPNG.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------------- 23 | ERROR | [x] Expected 1 blank line after function; 0 found 24 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageFieldValidateTest.php ---------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageOnTranslatedEntityTest.php --------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 --------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageDimensionsTest.php ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageFieldDefaultImagesTest.php --------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 --------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageEffectsTest.php ---------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageFieldDisplayTest.php --------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageAdminStylesTest.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/FileMoveTest.php ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageStyleDeleteTest.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageFieldWidgetTest.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageStylesPathAndUrlTest.php ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/QuickEditImageControllerTest.php ---------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/ImageStyleFlushTest.php ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Functional/Update/ImageUpdateTest.php ---------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageFormatterTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageImportTest.php ----------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageOptimizePipelineTest.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 19 ERRORS AFFECTING 15 LINES ----------------------------------------------------------------------------------------------------------------------------------- 18 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line 21 | ERROR | [x] Doc comment short description must end with a full stop 137 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 139 | ERROR | [ ] Missing parameter comment 140 | ERROR | [ ] Missing parameter comment 141 | ERROR | [ ] Missing parameter comment 142 | ERROR | [ ] Missing parameter comment 142 | ERROR | [x] Expected 1 spaces after parameter type; 3 found 143 | ERROR | [ ] Missing parameter comment 143 | ERROR | [x] Expected 1 spaces after parameter type; 3 found 145 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 147 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 148 | ERROR | [x] Opening brace should be on the same line as the declaration 165 | ERROR | [ ] Missing parameter type 168 | ERROR | [ ] Missing parameter type 171 | ERROR | [ ] Missing parameter type 174 | ERROR | [x] Separate the @param and @return sections by a blank line. 174 | ERROR | [ ] Return type missing for @return tag in function comment ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/Migrate/d6/MigrateImageCacheTest.php ---------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/Migrate/d7/MigrateImageSettingsTest.php ------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/Migrate/d7/MigrateImageStylesTest.php ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageItemTest.php --------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 --------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageStyleCustomStreamWrappersTest.php ------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageThemeFunctionTest.php ------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/ImageStyleIntegrationTest.php --------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/Views/RelationshipUserImageDataTest.php ------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Empty array declaration must have no space between the parentheses ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/Kernel/Views/ImageViewsDataTest.php -------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/FunctionalJavascript/ImageFieldValidateTest.php -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/FunctionalJavascript/QuickEditImageTest.php ---------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/tests/src/FunctionalJavascript/ImageAdminStylesTest.php ------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizePipelineEditForm.php -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------------- 56 | WARNING | Line exceeds 80 characters; contains 84 characters 132 | WARNING | Line exceeds 80 characters; contains 84 characters -------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorEditForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 28 | ERROR | Protected method name "ImageAPIOptimizeProcessorEditForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format -------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorDeleteForm.php ----------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------- 15 | WARNING | Line exceeds 80 characters; contains 87 characters ----------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorFormBase.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 39 | ERROR | Parameter $form is not described in comment 39 | ERROR | Parameter $form_state is not described in comment 81 | WARNING | Line exceeds 80 characters; contains 92 characters 105 | WARNING | Line exceeds 80 characters; contains 90 characters 116 | WARNING | Line exceeds 80 characters; contains 90 characters 139 | ERROR | Protected method name "ImageAPIOptimizeProcessorFormBase::prepareImageAPIOptimizeProcessor" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizeDefaultPipelineConfigForm.php ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty ----------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizePipelineDeleteForm.php ---------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------- 61 | WARNING | Line exceeds 80 characters; contains 90 characters ---------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorAddForm.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 56 | ERROR | Protected method name "ImageAPIOptimizeProcessorAddForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format ------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizeProcessorPluginCollection.php ------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------ 15 | ERROR | Description for the @return value is missing 17 | WARNING | Possible useless method overriding detected ------------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/Exception/PluginNotFoundException.php ------------------------------------------------------------------------------------ FOUND 7 ERRORS AFFECTING 6 LINES ------------------------------------------------------------------------------------ 8 | ERROR | [x] Doc comment short description must end with a full stop 16 | ERROR | [ ] Missing member variable doc comment 18 | ERROR | [ ] Missing short description in doc comment 26 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [ ] Description for the @return value is missing 32 | ERROR | [x] Expected 1 newline at end of file; 0 found 32 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 16 | WARNING | Line exceeds 80 characters; contains 84 characters 19 | ERROR | The text '@deprecated in Drupal 8.0.x, will be removed before Drupal 9.0.x. Use \Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId() instead.' does not | | match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. 20 | WARNING | Line exceeds 80 characters; contains 102 characters 22 | WARNING | The @see url '\Drupal\imageapi_optimize\ImageAPIOptimizePipelineStorageInterface::getReplacementId()' does not match the standard: http(s)://www.drupal.org/node/n or | | http(s)://www.drupal.org/project/aaa/issues/n 24 | ERROR | Public method name "ImageAPIOptimizePipelineInterface::getReplacementID" is not in lowerCamel format 105 | WARNING | Line exceeds 80 characters; contains 88 characters ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizePipelineListBuilder.php ------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------ 41 | ERROR | Missing parameter comment 42 | ERROR | Missing parameter comment 43 | ERROR | Missing parameter comment ------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/Annotation/ImageAPIOptimizeProcessor.php ------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ------------------------------------------------------------------------------------- 39 | ERROR | The @var tag must be the first tag in a member variable comment 46 | WARNING | Line exceeds 80 characters; contains 81 characters 50 | ERROR | The @var tag must be the first tag in a member variable comment ------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizePipelineStorageInterface.php ----------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------- 6 | WARNING | Line exceeds 80 characters; contains 92 characters 14 | WARNING | Line exceeds 80 characters; contains 93 characters 34 | WARNING | Line exceeds 80 characters; contains 90 characters ----------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/Entity/ImageStyleWithPipeline.php ------------------------------------------------------------------------------ FOUND 7 ERRORS AFFECTING 7 LINES ------------------------------------------------------------------------------ 7 | ERROR | Doc comment is empty 12 | ERROR | Missing short description in doc comment 14 | ERROR | Missing @var tag in member variable comment 34 | ERROR | Doc comment is empty 41 | ERROR | Missing short description in doc comment 42 | ERROR | Description for the @return value is missing 61 | ERROR | Doc comment is empty ------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/Entity/ImageAPIOptimizePipeline.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 73 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters 81 | ERROR | [ ] Missing @var tag in member variable comment 135 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::replaceImageAPIOptimizePipeline" is not in lowerCamel format 179 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4 180 | ERROR | [x] Expected one space after the comma, 0 found 180 | ERROR | [x] Expected one space after the comma, 0 found 263 | ERROR | [ ] Public method name "ImageAPIOptimizePipeline::getReplacementID" is not in lowerCamel format 290 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::getImageAPIOptimizeProcessorPluginManager" is not in lowerCamel format --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizeProcessorBase.php ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 159 | ERROR | Doc comment is empty ------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizeProcessorInterface.php ----------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------- 21 | WARNING | Line exceeds 80 characters; contains 90 characters 48 | WARNING | Line exceeds 80 characters; contains 85 characters ----------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizePipelineStorage.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 8 | WARNING | Line exceeds 80 characters; contains 81 characters 16 | WARNING | Line exceeds 80 characters; contains 104 characters -------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/src/ImageAPIOptimizeHookImplementations.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::entity_type_alter" is not in lowerCamel format 44 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::form_image_style_edit_form_alter" is not in lowerCamel format 59 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::config_schema_info_alter" is not in lowerCamel format ------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/imageapi_optimize.api.php ---------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 100 characters 16 | ERROR | Missing parameter type 17 | WARNING | Line exceeds 80 characters; contains 90 characters ---------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/imageapi_optimize.install ------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------ 60 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 67 | ERROR | [x] Expected newline after closing brace 67 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /var/www/patches/imageapi_optimize/imageapi_optimize.module ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 3 | ERROR | Missing short description in doc comment 13 | ERROR | Missing parameter type 16 | ERROR | Return type missing for @return tag in function comment ---------------------------------------------------------------------- FILE: /var/www/patches/imageapi_optimize/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 59 | WARNING | Line exceeds 80 characters; contains 96 characters ---------------------------------------------------------------------- Time: 788ms; Memory: 10MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
There are not issues left: The report is based only on the Drupal standard, not Drupal and DrupalPractice standards.
It is not clear why only a standard has been used to check the code, though.
Status changed to Needs work 5 months ago6:38am 20 August 2024

Comment 5 months ago →

a.aaronjake

Hi @urvashi_vora,

After applying your patch, there are more than errors reported by my terminal than what you reported. Please see below:

➜  imageapi_optimize git:(8.x-2.x) curl https://www.drupal.org/files/issues/2022-06-24/coding-standard-fix-3067484-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 45915  100 45915    0     0   145k      0 --:--:-- --:--:-- --:--:--  150k
patching file README.md
patching file imageapi_optimize.api.php
patching file imageapi_optimize.info.yml
patching file imageapi_optimize.install
patching file imageapi_optimize.module
patching file src/Annotation/ImageAPIOptimizeProcessor.php
patching file src/Entity/ImageAPIOptimizePipeline.php
patching file src/Entity/ImageStyleWithPipeline.php
patching file src/Exception/PluginNotFoundException.php
patching file src/Form/ImageAPIOptimizeDefaultPipelineConfigForm.php
patching file src/Form/ImageAPIOptimizePipelineDeleteForm.php
patching file src/Form/ImageAPIOptimizePipelineEditForm.php
patching file src/Form/ImageAPIOptimizeProcessorDeleteForm.php
patching file src/Form/ImageAPIOptimizeProcessorFormBase.php
patching file src/ImageAPIOptimizeHookImplementations.php
patching file src/ImageAPIOptimizePipelineInterface.php
patching file src/ImageAPIOptimizePipelineListBuilder.php
patching file src/ImageAPIOptimizePipelineStorage.php
patching file src/ImageAPIOptimizePipelineStorageInterface.php
patching file src/ImageAPIOptimizeProcessorBase.php
patching file src/ImageAPIOptimizeProcessorInterface.php
patching file src/ImageAPIOptimizeProcessorPluginCollection.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorAppendCharacters.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorBlackPNG.php
patching file tests/module/imageapi_optimize_module_test/src/Plugin/ImageAPIOptimizeProcessor/TestProcessorFailedGreenPNG.php
patching file tests/src/Functional/FileMoveTest.php
patching file tests/src/Functional/ImageAdminStylesTest.php
patching file tests/src/Functional/ImageDimensionsTest.php
patching file tests/src/Functional/ImageEffectsTest.php
patching file tests/src/Functional/ImageFieldDefaultImagesTest.php
patching file tests/src/Functional/ImageFieldDisplayTest.php
patching file tests/src/Functional/ImageFieldValidateTest.php
patching file tests/src/Functional/ImageFieldWidgetTest.php
patching file tests/src/Functional/ImageOnTranslatedEntityTest.php
patching file tests/src/Functional/ImageStyleDeleteTest.php
patching file tests/src/Functional/ImageStyleFlushTest.php
patching file tests/src/Functional/ImageStylesPathAndUrlTest.php
patching file tests/src/Functional/QuickEditImageControllerTest.php
patching file tests/src/Functional/Update/ImageUpdateTest.php
patching file tests/src/FunctionalJavascript/ImageAdminStylesTest.php
patching file tests/src/FunctionalJavascript/ImageFieldValidateTest.php
patching file tests/src/FunctionalJavascript/QuickEditImageTest.php
patching file tests/src/Kernel/ImageFormatterTest.php
patching file tests/src/Kernel/ImageImportTest.php
patching file tests/src/Kernel/ImageItemTest.php
patching file tests/src/Kernel/ImageOptimizePipelineTest.php
patching file tests/src/Kernel/ImageStyleCustomStreamWrappersTest.php
patching file tests/src/Kernel/ImageStyleIntegrationTest.php
patching file tests/src/Kernel/ImageThemeFunctionTest.php
patching file tests/src/Kernel/Migrate/d6/MigrateImageCacheTest.php
patching file tests/src/Kernel/Migrate/d7/MigrateImageSettingsTest.php
patching file tests/src/Kernel/Migrate/d7/MigrateImageStylesTest.php
patching file tests/src/Kernel/Views/ImageViewsDataTest.php
patching file tests/src/Kernel/Views/RelationshipUserImageDataTest.php
➜  imageapi_optimize git:(8.x-2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imageapi_optimize

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/imageapi_optimize.install
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\Entity\ImageAPIOptimizePipeline.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageStyleWithPipelineListBuilder.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 38 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorAddForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\ImageAPIOptimizePipelineInterface.
 56 | ERROR | [ ] Protected method name "ImageAPIOptimizeProcessorAddForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorEditForm.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 28 | ERROR | Protected method name "ImageAPIOptimizeProcessorEditForm::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizePipelineEditForm.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 145 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Form/ImageAPIOptimizeProcessorFormBase.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
  10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\Exception\PluginNotFoundException.
 146 | ERROR | [ ] Protected method name "ImageAPIOptimizeProcessorFormBase::prepareImageAPIOptimizeProcessor" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeProcessorPluginCollection.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 18 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/Entity/ImageAPIOptimizePipeline.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------
  12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\imageapi_optimize\ImageAPIOptimizeProcessorInterface.
 140 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::replaceImageAPIOptimizePipeline" is not in lowerCamel format
 268 | ERROR | [ ] Public method name "ImageAPIOptimizePipeline::getReplacementID" is not in lowerCamel format
 295 | ERROR | [ ] Protected method name "ImageAPIOptimizePipeline::getImageAPIOptimizeProcessorPluginManager" is not in lowerCamel format
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineStorage.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 37 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizePipelineInterface.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | Public method name "ImageAPIOptimizePipelineInterface::getReplacementID" is not in lowerCamel format
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/imageapi_optimize/src/ImageAPIOptimizeHookImplementations.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 29 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::entity_type_alter" is not in lowerCamel format
 44 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::form_image_style_edit_form_alter" is not in lowerCamel format
 59 | ERROR | Public method name "ImageAPIOptimizeHookImplementations::config_schema_info_alter" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------------------

Kindly check and work on it.

Thanks,
Jake

Comment 5 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Let's create a merge request, now that patches are no longer tested.
Comment 5 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3067484-drupal-best-practices to hidden.
Comment 5 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Furthermore, the 8.x-2.x branch is no longer supported. Any change must be done on the 4.x-dev branch.
Merge request !12Issue #3067484: Fix the issues reported by phpcs → (Open) created by apaderno
Pipeline finished with Failed
5 months ago
Total: 137s
#259963
Comment 5 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Closed: duplicate 20 days ago5:06pm 6 January 2025
Comment 20 days ago →
🇬🇧United Kingdom steven jones
Let's continue this in 📌 Phpcs Drupal coding standard issue Active .

Fix the issues reported by phpcs

Merge Requests

!12Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Merge Requests

!12Fix the issues reported by phpcsOpen

Comments & Activities

!12Fix the issues reported by phpcs
Open