Ajax support / Use behaviors

#258 worked for me.

Drupal core 9.5.3, Ajax Comments 8.x-1.0-beta5, PHP 8.0.27.

Thank you!

💬 Any active maintainer left here? vs. frequently used module Fixed
Nothing more to say? Any candidates?

re-roll #258

#273 Patch can't be able to apply.
kindly,rework on this

Patch #273 applied successful for me. Thanks.

Patch #273 looks good to me as well. Thanks @slasher13!

Patch #273 applied successfully for me. Thanks.

Thanks @slasher13, patch #273 works fine for me

patch #273 works with me

Patch #273 was applied successfully and it works fine for me. Thanks.

Patch #273 🐛 Ajax support / Use behaviors Needs work worked perfectly, with this patch recaptcha in modals was solved. Thanks.

Patch #273 tests good

Patch #273 was applied successfully and it is been working fine for the webform in the modal!

Thanks @slasher13

Patch looks good to me and has been successfully tested by all the above; marking RTBC.

Patch #273 works.
+1 RTBC

Patch #273 was applied successfully and it works fine in drupal ajax modal.
Thanks @slasher13

Hi,

Fix for the issue of Unable to install modules: module 'recaptcha_test' is incompatible with this version of Drupal core. Please review.

Thanks.

The last submitted patch, 288: recaptcha-ajax-support-2493183-288.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Hi,

Fix for the error The 'core_version_requirement' constraint (^8.9 || ^9 || ^10) requires the 'core' key not be set in modules/contrib/recaptcha/tests/modules/recaptcha_test/recaptcha_test.info.yml. Please review.

Thanks.

Back to RTBC for #273 with many RTBC votes.

#288 + #290 seem unrelated to this issue.

Anybody → closed merge request !9

Anybody → closed merge request !23

@all: Please help testing and reviewing MR!24 based on #273 so we can hopefully end this never ending story soon. Thank you!

eslint and phpcs are unhappy, but tests are green now. Could someone fix that finally?
https://git.drupalcode.org/project/recaptcha/-/pipelines/63104

Manual testing is still welcome!

I'm update module in 3.2.0 version with patch #273

#273 fixed the initial issue of the captcha being unusable on a multistep form, but the captcha module persistence settings do not appear to be honored. The recaptcha appears on every step of the multistep form regardless of the persistence settings.

@matthewmessmer thank you! Can you elaborate, if it worked as expected without the patch? Then we should add a test for that and fix it. Would be super nice to have more community contribution here to get this finished!

I found this issue because I was experiencing an issue on a multipage form with AJAX enabled for validation. I installed the patch #273 and now it's working, but not ideally.

To resolve the issue with the form not recognizing multipage and putting captcha on every page, I moved the captcha inside the last page, where the submit resides. It's interesting that the "I'm not a robot" is showing but not the reCAPTCHA logo on the bottom of the page. All of my other forms do not require human interaction.

Therefore, I don't know if #273 totally solves it because it appears a backup form is placed on the page, and the reCAPTCHA button is not showing on the bottom right of the page. I prefer the checkbox to a math quiz, so I'm keeping this in place, but it's my understanding there shouldn't be a form input at all.

Adding to the discussion, it appears that the persistence settings were previously overlooked #3363653 🐛 reCAPTCHA ignores “Omit challenges in a multi-step/preview workflow…" setting Needs work and not related to the patch.

#273 worked for me also, Thanks @slasher13. Is there anyway we can commit this and fix the issue with multiform AJAX as a followup ticket

I have tested patch #273 Thanks @slasher13

Environment tested on:
Drupal 10.1.6
Php 8.1.21

Version: Recaptcha 8.x-3.2

Issue prior to patch:
We were using a basic webform with all fields required, with ajax enabled (not multi-step) in a block to collect anonymous user feedback. With persistence set to: "Omit challenges in a multi-step/preview workflow once the user successfully responds to a challenge." and captcha added directly to the webform rather than as a captcha point within the block (however adding the captcha point within the block had the same result). If the anonymous user failed to enter one of the required fields or pass the captcha, the captcha would not display post initial submission. Disabling ajax resolved the issue but was not an option in this use case.

After applying the patch:
The captcha was shown as expected post failed webform submission within the webform block.

One issue I've now encountered with the patch in #273 is that it adds a new functional test, but the setUp function there does not have the void return declaration, which results in throwing an error if I try to run any functional tests. See https://www.drupal.org/project/recaptcha/issues/3446000 🐛 Functional Tests: Declaration of Declaration of Drupal\Tests\recaptcha\Functional\RecaptchaJavascriptTest::setUp() Closed: duplicate . I added that to an updated patch here.

My editor (VS Code with a Drupal formatter) is pointing out other issues with that file, but those ones don't stop me from running other tests, so I'll leave that to those who are working on that test.

I have the #273 patch installed in a multilanguage website. The webform loaded using ajax works correctly in all languages. But a new webform was created in the website and that form doesn't load with ajax. The result is that the recaptcha loads in english but not in other languages. And is something in this patch because, if I remove the patch, the recaptcha in the non-ajax webform works correctly in all languages and the recaptcha in the webform loaded using ajax stops working.