- Issue created by @apotek
- Status changed to Needs work
10 months ago 6:10pm 23 January 2024 - Status changed to Needs review
10 months ago 7:00pm 23 January 2024 - Status changed to Needs work
10 months ago 9:42pm 23 January 2024 - πΊπΈUnited States apotek
I have resolved all issues raised by @nikolay-shapovalov so am switching this back to Needs Review. gitlab-ci is working and reporting back helpful results.
- Status changed to Needs review
10 months ago 12:28am 25 January 2024 - π·πΊRussia zniki.ru
Thanks a lot, for you changes.
I provide a review, please check my feedback.Suggestion about adding comment is optional, it's up to you to decide.
Do you think title "Adopt GitlabCi" will be better fit this issue?
I wasn't able to find "starter phpstan configuration" in the MR. - Status changed to Needs work
10 months ago 8:01am 25 January 2024 - Status changed to Needs review
10 months ago 4:55pm 25 January 2024 - πΊπΈUnited States apotek
Thank you for your review @nikolay-shapovalov. I have added the suggestions you made. I have left unresolved your question about changing
- use Drupal\Dfp\Entity\Tag; + use Drupal\dfp\Entity\Tag;
This was one, very easy to resolve issue highlighted by phpstan. If you want me to remove it, I will.
> I wasn't able to find "starter phpstan configuration" in the MR.
It is in the `phpstan.neon` file I added. I have changed the title as you suggested.
- Status changed to RTBC
10 months ago 6:16pm 25 January 2024 - Issue was unassigned.
- πΊπΈUnited States apotek
Thank you for your valuable input @Nikolay Shapovalov. I have unassigned this issue and now let's see if the maintainers pick it up.
- First commit to issue fork.
- Status changed to Needs review
6 months ago 4:22pm 23 May 2024 - π¦πΊAustralia VladimirAus Brisbane, Australia
Fixed:
- cspell
- phpstan (next minor)
- Status changed to RTBC
6 months ago 4:46am 24 May 2024 - π¦πΊAustralia jannakha Brisbane!
new issues are created to fix CI errors
-
VladimirAus β
committed 96675531 on 2.0.x authored by
apotek β
Issue #3416546 by apotek, VladimirAus, Nikolay Shapovalov: Adopt...
-
VladimirAus β
committed 96675531 on 2.0.x authored by
apotek β
- Status changed to Fixed
6 months ago 9:02am 24 May 2024 - π¦πΊAustralia VladimirAus Brisbane, Australia
Thank you! Committed! π»
Automatically closed - issue fixed for 2 weeks with no activity.