Created on 23 January 2024, 5 months ago
Updated 7 June 2024, 16 days ago

Problem/Motivation

The inclusion of gitlab.ci functionality (which affects all branches being created and all current workflows) which was started in issue https://www.drupal.org/project/dfp/issues/2833962 πŸ“Œ Fix the issues reported by phpcs Fixed was being held up by the more complex factoring involved with fixing the phpcs.

I feel there is much value in:
1. Getting this gitlab file into code (or else every new merge request will be asked about adding it).
2. There is value, even if phpstan and phpcs are not blocking yet (because they fail) in reporting back the results of phpcs and phpstan to any current merge requests since that can be valuable feedback to the developer.

Since the gitlab.ci work is relatively straightforward and offers benefits to all ongoing and future gitlab-based issues, since it will report phpcs and phpstan issues, which can be useful, even if not blocking, I felt it would be expedient to break that out into its own issue, so that other branches can also benefit from it as soon as possible.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States apotek

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024