- Issue created by @Zed9
- First commit to issue fork.
- ๐ฎ๐ณIndia Ashutosh Ahirwal India
Ashutosh Ahirwal โ made their first commit to this issueโs fork.
- Status changed to Needs work
10 months ago 1:22pm 12 January 2024 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
I have created a new MR with phpcs issue fixes.
There are some remaining error for which i'm not sure.
Need maintainer review on it. - ๐ฎ๐ณIndia zkhan.aamir
Hi,
MR #7 applied partially.
MR #7 did not applied successfully.Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/smart_date (4.0.x) $ curl https://git.drupalcode.org/project/smart_date/-/merge_requests/77.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 56985 0 56985 0 0 116k 0 --:--:-- --:--:-- --:--:-- 116k patching file modules/smart_date_recur/smart_date_recur.module Hunk #1 FAILED at 70. Hunk #2 succeeded at 139 (offset -39 lines). Hunk #3 succeeded at 483 (offset -39 lines). Hunk #4 succeeded at 725 (offset -39 lines). Hunk #5 FAILED at 817. Hunk #6 succeeded at 888 (offset -38 lines). 2 out of 6 hunks FAILED -- saving rejects to file modules/smart_date_recur/smart_date_recur.module.rej patching file modules/smart_date_recur/smart_date_recur.tokens.inc patching file modules/smart_date_recur/src/Controller/Instances.php patching file modules/smart_date_recur/src/Entity/SmartDateOverride.php patching file modules/smart_date_recur/src/Entity/SmartDateRule.php Hunk #1 FAILED at 522. Hunk #2 succeeded at 654 (offset -59 lines). Hunk #3 succeeded at 714 (offset -59 lines). 1 out of 3 hunks FAILED -- saving rejects to file modules/smart_date_recur/src/Entity/SmartDateRule.php.rej patching file modules/smart_date_recur/src/Plugin/Field/FieldFormatter/SmartDateRecurrenceFormatter.php Hunk #1 succeeded at 260 (offset -7 lines). patching file modules/smart_date_recur/src/Plugin/QueueWorker/RecurRuleUpdate.php patching file smart_date.install patching file smart_date.tokens.inc patching file src/Commands/SmartDateDrushCommands.php patching file src/Feeds/Target/SmartDate.php patching file src/Form/SmartDateFormatSettingsForm.php patching file src/FormElement/Boolean.php patching file src/Normalizer/SmartDateItemNormalizer.php patching file src/Plugin/Field/FieldFormatter/SmartDateDefaultFormatter.php patching file src/Plugin/Field/FieldFormatter/SmartDateFormatterBase.php patching file src/Plugin/Field/FieldType/DateTimeComputed.php patching file src/Plugin/Field/FieldType/SmartDateItem.php Hunk #2 succeeded at 139 (offset -2 lines). patching file src/Plugin/Field/FieldWidget/SmartDateInlineWidget.php patching file src/Plugin/Field/FieldWidget/SmartDateTimezoneWidget.php patching file src/Plugin/Field/FieldWidget/SmartDateWidgetBase.php Hunk #1 succeeded at 11 (offset -1 lines). Hunk #2 succeeded at 129 (offset -1 lines). patching file src/Plugin/diff/Field/SmartdateFieldBuilder.php patching file src/Plugin/migrate/process/ParseDates.php patching file src/Plugin/views/argument/Date.php patching file src/Plugin/views/filter/Date.php patching file src/SmartDateDurationConfigTrait.php patching file src/SmartDateServiceProvider.php patching file src/SmartDateTrait.php patching file src/TwigExtension/SmartDateFormat.php patching file src/TypedData/Plugin/DataType/SmartDate.php patching file tests/src/Functional/SmartDateTimezoneWidgetTest.php
- Status changed to Closed: outdated
7 months ago 12:39pm 3 May 2024 - ๐จ๐ฆCanada mandclu
I appreciate the work done here. but these issues have already been cleaned up in the 4.1.x branch.