- Issue created by @ashutosh ahirwal
- Assigned to Akshay kashyap
- 🇮🇳India Akshay kashyap
From tomorrow, I will start working on this issue.
- Issue was unassigned.
- Merge request !10form-responsive: Corrected the form so that the horizontal scroll bar does not appear. → (Open) created by Tanushree Gupta
- Status changed to Needs review
about 1 year ago 5:43am 15 March 2024 Made the input field inside the form so that there is no horizontal scroll bar and the form is responsive.
https://git.drupalcode.org/project/picked_fresh/-/merge_requests/10
Here is a screenshot I am attaching for reference.- Status changed to Needs work
11 months ago 10:14am 5 June 2024 Hi @Tanushree Gupta,
After applying your patch the horizontal scrollbar issue is resolved, but I can see other several style breaks in the login page.
It'll be great if we can address them in this issue as well.
On small viewports as that of iPhone15 or so the search block is overlapping with nav tabs, we can make it responsive, in my opinion all the tabs and buttons can have a little bit more padding, otherwise it looks to be too shrunken.
Btw, I cannot see any placeholder or labels on the form, it should be there to make the theme more accessible to assistive technologies like screen-readers. I'd prefer a placeholder over label, just a personal preference though!
On smaller viewports the field names are coming as horizontally centered whereas on desktop view its left aligned, so I think we should follow the same for smaller viewports as well to maintain cohesiveness through out the design.
Attaching relevant screenshots for reference!- Status changed to Needs review
11 months ago 12:21pm 7 June 2024 Here is the commit-id: https://git.drupalcode.org/project/picked_fresh/-/merge_requests/10/diff...
I have styled the login form, and in addition to this, I have solved the issue of the search block overlapping the menus. I also noticed that the primary tabs are a block, and I believe we can change their position through the block layout.Hi,
Applied MR!10, the login form looks good for all dimensions and the search block overlapping the menus issue is also resolved.
Attaching screenshots for reference.- Status changed to Needs work
11 months ago 10:04am 10 June 2024 Hello @Tanushree Gupta,
I've checked your latest changes and on applying the patch though the tab styling and form styling looks good now, but I found other problems also, which I think goes beyond the scope of the issue.
As far as this issue is concerned, most the things have been addressed well, and you're correct that we can manipulate the placement of blocks through UI itself!
But a small issue seems to be there in terms of styling, which might not be possible to fix through UI, and need some code changes.When placing 'Site Branding' and 'Primary Tabs' block on the Header region its showing closely packed, we can turn it into a flexbox display and provide a breathing space!
Attaching a screenshot for quick reference!
- Status changed to Needs review
11 months ago 8:17am 11 June 2024 I am unable to find this issue in my site.
Here is a screenshot I am attaching for the reference.Hi Applied MR!10, the login form looks good and the search block overlapping the menus issue is also resolved.
Even I am unable to find the issue mentioned in comment #10.
Attached screenshot for reference.
RTBC +1
Thankyou.- Status changed to RTBC
10 months ago 10:45am 20 June 2024