- Issue created by @dpacassi
- 🇨🇭Switzerland dpacassi Zürich, Switzerland
Pull request created, see:
https://git.drupalcode.org/project/entity_export_csv/-/merge_requests/7Attaching a static patch file in case the PR gets rerolled.
- Status changed to Needs review
6 months ago 8:03pm 14 May 2024 Hi, Applied #3 patch. The patch applies successfully and resolves the issue.
Attaching screenshots for reference.- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR !7 on Drupal 10
MR is applied cleanly and Resolved the download link issue.RTBC+1
Adding SS for referenceMoving to RTBC
- Status changed to RTBC
6 months ago 10:38am 15 May 2024 - Status changed to Needs work
6 months ago 12:25pm 15 May 2024 - 🇫🇷France flocondetoile Lyon
> However, the download link in the status message doesn't work.
I guess that if the download link doesn't work, it's because the file has been already downloaded (and this is what your patch shows as "fix"). And as we delete the file once it has been downloaded, then the link is not relevant anymore. It's not really a bug, it's a feature ! So I think then, if the file is automaticcaly downloaded (or even manually), then the link/sentence about the download should be replaced by a sentence as "the file has been downloaded. Check your download directory.".
I think we must keep the feature which delete the file once downloaded, as we don't need to keep it anymore on the server.