Fix the issues reported by phpcs

FILE: /nodeorder/nodeorder.install ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 13 | WARNING | [x] '@todo: Handle exceptions that could be thrown by DatabaseSchema::addField.' should match the format '@todo Fix problem X | | here.' ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /nodeorder/src/NodeOrderManager.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 201 | WARNING | [x] '@todo: distinct?' should match the format '@todo Fix problem X here.' 203 | WARNING | [x] '@todo: ORDER BY ' . $order;' should match the format '@todo Fix problem X here.' 220 | WARNING | [x] '@todo: Please convert this statement to the D7 database API syntax.' should match the format '@todo Fix problem X | | here.' 224 | WARNING | [x] '@todo: Please convert this statement to the D7 database API syntax.' should match the format '@todo Fix problem X | | here.' ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /nodeorder/src/NodeOrderManagerInterface.php ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 75 | ERROR | Type hint "array" missing for $tids ----------------------------------------------------------------------------------------------- FILE: /nodeorder/tests/src/Functional/NodeorderPermissionsTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 97 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: /nodeorder/nodeorder.module --------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 119 | WARNING | [x] '@todo: Replace this hacked function call.' should match the format '@todo Fix problem X here.' --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /nodeorder/README.md ----------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------- 22 | WARNING | Line exceeds 80 characters; contains 82 characters 23 | WARNING | Line exceeds 80 characters; contains 245 characters 26 | WARNING | Line exceeds 80 characters; contains 158 characters -----------------------------------------------------------------------

Comments & Activities

Issue created by @Binoli Lalani
Merge request !6Issue #3350621: Fix the issues reported by phpcs → (Merged) created by Binoli Lalani
Issue was unassigned.
Status changed to Needs review about 2 years ago12:09pm 27 March 2023
Comment about 2 years ago →
🇮🇳India Binoli Lalani Gujarat
Hello,

I've created MR. Please review.

Thank you!
Comment about 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work about 2 years ago12:56pm 27 March 2023

Comment about 2 years ago →

🇮🇹Italy apaderno Brescia, 🇮🇹

-        // @todo: distinct?
+        // @todo distinct?

What follows @todo must be a sentence, but not an interrogative sentence.

-          // @todo: Please convert this statement to the D7 database API syntax.
+          // @todo Please convert this statement to the D7 database API syntax.

Please is not necessary. The sentence should use the imperative mood.

-    $user = $this->drupalCreateUser(['administer taxonomy', 'order nodes within categories']);
+    $users = ['administer taxonomy', 'order nodes within categories'];
+
+    $user = $this->drupalCreateUser($users);

It is probably better to leave the code as it is.
Also, those are permissions, not users. The variable has the wrong name.

Status changed to Needs review about 2 years ago1:24pm 28 March 2023
Comment about 2 years ago →
🇮🇳India Binoli Lalani Gujarat
Hello @apaderno,

Thank you for reviewing the MR. I have updated the code as requested. Please review.

Thank you!
Status changed to Needs work about 1 year ago9:33pm 12 March 2024
Comment about 1 year ago →
davps
First commit to issue fork.
Pipeline finished with Failed
about 1 year ago
Total: 246s
#117887
First commit to issue fork.
Status changed to Needs review about 1 year ago5:54am 13 March 2024
Comment about 1 year ago →
🇮🇳India pray_12
Pipeline finished with Failed
about 1 year ago
Total: 155s
#117892
Pipeline finished with Failed
about 1 year ago
Total: 151s
#118074
Comment about 1 year ago →
System Message

davps → committed d21b568c on 2.x authored by Binoli Lalani →
Issue #3350621 by Binoli Lalani, davps, apaderno, pray_12, Shruu_rao:...
Status changed to Fixed about 1 year ago12:05pm 13 March 2024
Comment about 1 year ago →
davps
Thanks everyone for help.
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!6Fix the issues reported by phpcs
Merged

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!6Fix the issues reported by phpcsMerged

Comments & Activities

!6Fix the issues reported by phpcs
Merged