Fix the issues reported by phpcs

The provided patch file "fix_coding_standards-3398244-2.patch", fixes all the phpcs reported issues.

Hi Keshav,

I applied your patch #2 and I confirmed that it fixes all the PHPCS issues, the only remaining issues being flagged are "project", "datestamp", and "version" which I believe appears when the module is installed via composer.

➜  eqneditor git:(master) ✗ curl https://www.drupal.org/files/issues/2023-11-01/fix_coding_standards-3398244-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3503  100  3503    0     0  12201      0 --:--:-- --:--:-- --:--:-- 12555
patching file eqneditor.module
patching file 'src/Plugin/CKEditorPlugin/Equationbutton.php'
➜  eqneditor git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml eqneditor 

FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/eqneditor/eqneditor.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 253ms; Memory: 10MB

➜  contrib git:(master) ✗ 

+  /**
+   * Implements \Drupal\ckeditor\Plugin\CKEditorPluginInterface::getFile().
+   */
+  public function getFile() {

For methods defined in an interface or a parent class, the documentation comment contains just {@inheritdoc}.

The revised patch file "fix_coding_standards-3398244-5.patch", fixes the PHPCS reported issues in accordance with comment #4.

Hi Keshav,

Confirmed the patch on #5 complies with #4
Here is the code on line 22:

  /**
   * {@inheritdoc}
   */
  public function getFile() {
    return base_path() . 'libraries/eqneditor/plugin.js';
  }

pray_12 → made their first commit to this issue’s fork.

i have applied #8 and still see some issues, i have fixed and applied a patch for this . Please review

+  /**
+   * Implements \Drupal\ckeditor\Plugin\CKEditorPluginInterface::getFile().
+   */
+  public function getFile() {
+    return base_path() . 'libraries/eqneditor/plugin.js';
+  }

Method descriptions do not start with Implements. This has been already reported in comment #4 and fixed in the patch provided in comment #5.

Let's keep using the issue fork, which has been already created.

These are the only issues I found on running the command:

 phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml eqneditor/

FILE: C:\Users\YASHASWI\OneDrive\Desktop\Contrib\eqneditor\eqneditor.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found
   |       |     "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ive\Desktop\Contrib\eqneditor\src\Plugin\CKEditorPlugin\Equationbutton.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found
   |       |     "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Hi,
Applied MR!1 , found no phpcs issues.

Changing issue status to RTBC as per #17