Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 4 July 2023, almost 2 years ago

Problem/Motivation

FILE: ...r/www/html/vb/d_cont/cl_editorial/src/Element/ComponentSelectorElement.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
15 | WARNING | [x] Unused use statement
56 | ERROR | [ ] Missing short description in doc comment
92 | ERROR | [ ] Key specified for array entry; first entry has no key
109 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
110 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...var/www/html/vb/d_cont/cl_editorial/src/Form/ComponentFiltersFormTrait.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
38 | ERROR | The array declaration extends to column 83 (the limit is 80).
| | The array content should be split up over multiple lines
48 | ERROR | Key specified for array entry; first entry has no key
109 | ERROR | The array declaration extends to column 97 (the limit is 80).
| | The array content should be split up over multiple lines
110 | ERROR | The array declaration extends to column 93 (the limit is 80).
| | The array content should be split up over multiple lines
113 | ERROR | The array declaration extends to column 164 (the limit is 80).
| | The array content should be split up over multiple lines
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/cl_editorial/src/assets/css/options-filter.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
131 | ERROR | [ ] Class definition is empty
156 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeee but
| | found #EEEE
158 | ERROR | [x] CSS colours must be defined in lowercase; expected #ddd but
| | found #DDD
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/cl_editorial/src/NoThemeComponentManager.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
73 | ERROR | [ ] Key specified for array entry; first entry has no key
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 140ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cl_editorial/

Remaining tasks

Patch review

šŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India ashutosh ahirwal India

    Provided patch get apply cleanly but still having so many errors.

    Used Command:-
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/cl_editorial

    Remaining issue:-
    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/cl_editorial.module
    ---------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------
    38 | ERROR | Missing parameter comment
    ---------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/modules/sdc_tags/sdc_tags.module
    ----------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------------------------------------
    1 | ERROR | [x] Missing file doc comment
    19 | ERROR | [x] PHP keywords must be lowercase; expected "function" but found "functioN"
    ----------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/modules/sdc_tags/src/Form/AutoTaggingForm.php
    -----------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
    -----------------------------------------------------------------------------------------------------------------------------------
    18 | ERROR | [x] Missing class doc comment
    119 | ERROR | [x] Expected 1 blank line after function; 2 found
    122 | ERROR | [x] Missing function doc comment
    124 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
    127 | ERROR | [x] Expected 1 blank line after function; 0 found
    128 | ERROR | [x] The closing brace for the class must have an empty line before it
    -----------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/modules/sdc_tags/src/Controller/ComponentTaggingController.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 11 ERRORS AND 3 WARNINGS AFFECTING 12 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------------------
    8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
    9 | WARNING | [x] Unused use statement
    50 | ERROR | [ ] Parameter $config_factory is not described in comment
    50 | ERROR | [ ] Parameter $component_manager is not described in comment
    50 | ERROR | [ ] Parameter $no_theme_component_manager is not described in comment
    94 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    126 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    170 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    206 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
    221 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    224 | ERROR | [ ] Key specified for array entry; first entry has no key
    236 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
    261 | ERROR | [ ] No key specified for array entry; first entry specifies key
    281 | ERROR | [ ] Description for the @return value is missing
    ----------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/modules/sdc_tags/src/ComponentTagPluginManager.php
    ----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------
    15 | WARNING | Line exceeds 80 characters; contains 87 characters
    16 | WARNING | Line exceeds 80 characters; contains 82 characters
    34 | WARNING | Line exceeds 80 characters; contains 86 characters
    44 | ERROR | Missing short description in doc comment
    ----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/modules/sdc_tags/src/ComponentTagDefault.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    33 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
    34 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6
    83 | ERROR | [x] 4 spaces found before inline comment; expected "// $form_state->setErrorByName('lorem', 'Error!');" but found "// $form_state->setErrorByName('lorem', 'Error!');"
    91 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/Form/ComponentFiltersFormTrait.php
    --------------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------------------------------------------------------------
    7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\cl_editorial\NoThemeComponentManager.
    56 | ERROR | [ ] Key specified for array entry; first entry has no key
    --------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/Form/ComponentInputToForm.php
    -----------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------
    12 | ERROR | [x] Missing class doc comment
    40 | ERROR | [ ] Missing parameter comment
    47 | ERROR | [x] Visibility must be declared on method "buildForm"
    -----------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/Element/ComponentSelectorElement.php
    ------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ------------------------------------------------------------------------------------------------------------------------------
    91 | ERROR | [ ] Key specified for array entry; first entry has no key
    108 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
    109 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
    ------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/Util.php
    -----------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------
    11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
    -----------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/assets/css/options-filter.css
    -----------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------
    1 | ERROR | [x] Multiple selectors should each be on a single line
    -----------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/assets/js/options-filter.js
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 175 ERRORS AFFECTING 45 LINES
    ---------------------------------------------------------------------------------------------------------------------
    1 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    64 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    79 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    88 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    89 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    96 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    101 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    102 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    109 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    141 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
    144 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    181 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    186 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    189 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    192 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    198 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    201 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    208 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    219 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    222 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    225 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    231 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    234 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    235 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    245 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
    270 | ERROR | [x] Expected 1 space after "<"; 0 found
    270 | ERROR | [x] Expected 1 space before ">"; 0 found
    270 | ERROR | [x] Expected 1 space after ">"; 0 found
    271 | ERROR | [x] Expected 1 space before "<"; 0 found
    271 | ERROR | [x] Expected 1 space after "<"; 0 found
    271 | ERROR | [x] Expected 1 space before "/"; 0 found
    271 | ERROR | [x] Expected 1 space after "/"; 0 found
    271 | ERROR | [x] Expected 1 space before ">"; 0 found
    272 | ERROR | [x] Expected 1 space after "<"; 0 found
    272 | ERROR | [x] Expected 1 space before ">"; 0 found
    272 | ERROR | [x] Expected 1 space after ">"; 0 found
    272 | ERROR | [x] Expected 1 space before "<"; 0 found
    272 | ERROR | [x] Expected 1 space after "<"; 0 found
    272 | ERROR | [x] Expected 1 space before "/"; 0 found
    272 | ERROR | [x] Expected 1 space after "/"; 0 found
    272 | ERROR | [x] Expected 1 space before ">"; 0 found
    273 | ERROR | [x] Expected 1 space after "<"; 0 found
    273 | ERROR | [x] Expected 1 space before "="; 0 found
    273 | ERROR | [x] Expected 1 space after "="; 0 found
    273 | ERROR | [x] Expected 1 space before ">"; 0 found
    274 | ERROR | [x] Expected 1 space after "<"; 0 found
    274 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before "/"; 0 found
    275 | ERROR | [x] Expected 1 space after "/"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before "/"; 0 found
    275 | ERROR | [x] Expected 1 space after "/"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before "/"; 0 found
    275 | ERROR | [x] Expected 1 space after "/"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    275 | ERROR | [x] Expected 1 space after ">"; 0 found
    275 | ERROR | [x] Expected 1 space before "<"; 0 found
    275 | ERROR | [x] Expected 1 space after "<"; 0 found
    275 | ERROR | [x] Expected 1 space before "/"; 0 found
    275 | ERROR | [x] Expected 1 space after "/"; 0 found
    275 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after ">"; 0 found
    276 | ERROR | [x] Expected 1 space before "<"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after ">"; 0 found
    276 | ERROR | [x] Expected 1 space before "<"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before "/"; 0 found
    276 | ERROR | [x] Expected 1 space after "/"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after ">"; 0 found
    276 | ERROR | [x] Expected 1 space before "<"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after ">"; 0 found
    276 | ERROR | [x] Expected 1 space before "<"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before "/"; 0 found
    276 | ERROR | [x] Expected 1 space after "/"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    276 | ERROR | [x] Expected 1 space after ">"; 0 found
    276 | ERROR | [x] Expected 1 space before "<"; 0 found
    276 | ERROR | [x] Expected 1 space after "<"; 0 found
    276 | ERROR | [x] Expected 1 space before "/"; 0 found
    276 | ERROR | [x] Expected 1 space after "/"; 0 found
    276 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after ">"; 0 found
    277 | ERROR | [x] Expected 1 space before "<"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after ">"; 0 found
    277 | ERROR | [x] Expected 1 space before "<"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before "/"; 0 found
    277 | ERROR | [x] Expected 1 space after "/"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after ">"; 0 found
    277 | ERROR | [x] Expected 1 space before "<"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after ">"; 0 found
    277 | ERROR | [x] Expected 1 space before "<"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before "/"; 0 found
    277 | ERROR | [x] Expected 1 space after "/"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    277 | ERROR | [x] Expected 1 space after ">"; 0 found
    277 | ERROR | [x] Expected 1 space before "<"; 0 found
    277 | ERROR | [x] Expected 1 space after "<"; 0 found
    277 | ERROR | [x] Expected 1 space before "/"; 0 found
    277 | ERROR | [x] Expected 1 space after "/"; 0 found
    277 | ERROR | [x] Expected 1 space before ">"; 0 found
    278 | ERROR | [x] Expected 1 space after "<"; 0 found
    278 | ERROR | [x] Expected 1 space before "/"; 0 found
    278 | ERROR | [x] Expected 1 space after "/"; 0 found
    278 | ERROR | [x] Expected 1 space before ">"; 0 found
    279 | ERROR | [x] Expected 1 space after "<"; 0 found
    279 | ERROR | [x] Expected 1 space before "="; 0 found
    279 | ERROR | [x] Expected 1 space after "="; 0 found
    279 | ERROR | [x] Expected 1 space before "-"; 0 found
    279 | ERROR | [x] Expected 1 space after "-"; 0 found
    281 | ERROR | [x] Expected 1 space before ">"; 0 found
    283 | ERROR | [x] Expected 1 space after "<"; 0 found
    283 | ERROR | [x] Expected 1 space before "/"; 0 found
    283 | ERROR | [x] Expected 1 space after "/"; 0 found
    283 | ERROR | [x] Expected 1 space before ">"; 0 found
    284 | ERROR | [x] Expected 1 space after "<"; 0 found
    284 | ERROR | [x] Expected 1 space before "/"; 0 found
    284 | ERROR | [x] Expected 1 space after "/"; 0 found
    284 | ERROR | [x] Expected 1 space before ">"; 0 found
    285 | ERROR | [x] Expected 1 space after "<"; 0 found
    285 | ERROR | [x] Expected 1 space before "="; 0 found
    285 | ERROR | [x] Expected 1 space after "="; 0 found
    285 | ERROR | [x] Expected 1 space before ">"; 0 found
    285 | ERROR | [x] Expected 1 space after ">"; 0 found
    285 | ERROR | [x] Expected 1 space before "<"; 0 found
    285 | ERROR | [x] Expected 1 space after "<"; 0 found
    285 | ERROR | [x] Expected 1 space before "/"; 0 found
    285 | ERROR | [x] Expected 1 space after "/"; 0 found
    285 | ERROR | [x] Expected 1 space before ">"; 0 found
    ---------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 175 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/cl_editorial/src/NoThemeComponentManager.php
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------
    71 | ERROR | Key specified for array entry; first entry has no key
    ---------------------------------------------------------------------------------------------------------------------

  • Assigned to nitin_lama
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India
  • First commit to issue fork.
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India

    Providing the updated patch for 2.x.
    Please review.

  • Issue was unassigned.
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India
  • Merge request !93372210: Fixed the issues reported by phpcs. ā†’ (Closed) created by diwakar07
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India diwakar07

    I have fixed the errors and warnings reported by phpcs.
    Created an MR for the same.
    Please review.

  • Comment over 1 year ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied the MR !9 and I noticed that there are still PHPCS issues that needs to resolved, hence moving this to needs work

    āžœ  cl_editorial git:(master) āœ— curl https://git.drupalcode.org/project/cl_editorial/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 23449    0 23449    0     0  43346      0 --:--:-- --:--:-- --:--:-- 43994
patching file cl_editorial.module
patching file 'modules/sdc_tags/sdc_tags.module'
patching file 'modules/sdc_tags/src/ComponentTagDefault.php'
patching file 'modules/sdc_tags/src/ComponentTagPluginManager.php'
patching file 'modules/sdc_tags/src/Controller/ComponentTaggingController.php'
patching file 'modules/sdc_tags/src/Form/AutoTaggingForm.php'
patching file 'src/Element/ComponentSelectorElement.php'
patching file 'src/Form/ComponentFiltersFormTrait.php'
patching file 'src/Form/ComponentInputToForm.php'
patching file 'src/NoThemeComponentManager.php'
patching file 'src/Util.php'
patching file 'src/assets/css/options-filter.css'
patching file 'src/assets/js/options-filter.js'
āžœ  cl_editorial git:(master) āœ— ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cl_editorial

FILE: ...-local/web/modules/contrib/cl_editorial/modules/sdc_tags/sdc_tags.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...modules/contrib/cl_editorial/modules/sdc_tags/src/Form/AutoTaggingForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 129 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
--------------------------------------------------------------------------------


FILE: ...l_editorial/modules/sdc_tags/src/Controller/ComponentTaggingController.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
   8 | ERROR   | [x] Use statements should be sorted alphabetically. The first
     |         |     wrong one is Drupal\Core\Config\ConfigFactoryInterface.
 211 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 229 | ERROR   | [ ] Key specified for array entry; first entry has no key
 241 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 266 | ERROR   | [ ] No key specified for array entry; first entry specifies
     |         |     key
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...es/contrib/cl_editorial/modules/sdc_tags/src/ComponentTagPluginManager.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------


FILE: ...rojects/d9/d9-local/web/modules/contrib/cl_editorial/cl_editorial.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...al/web/modules/contrib/cl_editorial/src/Form/ComponentFiltersFormTrait.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  7 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\cl_editorial\NoThemeComponentManager.
 50 | ERROR | [ ] Key specified for array entry; first entry has no key
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../web/modules/contrib/cl_editorial/src/Element/ComponentSelectorElement.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 91 | ERROR | Key specified for array entry; first entry has no key
--------------------------------------------------------------------------------


FILE: .../d9-local/web/modules/contrib/cl_editorial/src/NoThemeComponentManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 71 | ERROR | Key specified for array entry; first entry has no key
--------------------------------------------------------------------------------

Time: 516ms; Memory: 12MB

āžœ  contrib git:(master) āœ—
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡µšŸ‡­Philippines clarkssquared
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India zkhan.aamir
  • First commit to issue fork.
  • Comment over 1 year ago ā†’
    shruu_rao

    Hii,
    Reviewed MR 9!, still can see some phpcs errors.

    \cl_editorial\modules\sdc_tags\src\Controller\ComponentTaggingController.php
    -------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -------------------------------------------------------------------------------------------------
    242 | ERROR | Key specified for array entry; first entry has no key
    279 | ERROR | No key specified for array entry; first entry specifies key
    -------------------------------------------------------------------------------------------------

    \cl_editorial\src\Element\ComponentSelectorElement.php
    ---------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------
    91 | ERROR | Key specified for array entry; first entry has no key
    ---------------------------------------------------------------------------

    \cl_editorial\src\Form\ComponentFiltersFormTrait.php
    -------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------
    50 | ERROR | Key specified for array entry; first entry has no key
    -------------------------------------------------------------------------

    \cl_editorial\src\NoThemeComponentManager.php
    ----------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------
    71 | ERROR | Key specified for array entry; first entry has no key
    ----------------------------------------------------------------------

  • Assigned to mohd sahzad
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India mohd sahzad
  • Issue was unassigned.
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India mohd sahzad
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India mohd sahzad
  • Comment about 1 year ago ā†’
    šŸ‡®šŸ‡³India pray_12

    Hi,
    Applied the MR!9[#15].No Phpcs errors or warnings were found.

  • Comment 11 months ago ā†’
    šŸ‡®šŸ‡³India manish-31

    manish-31 ā†’ changed the visibility of the branch 3372210-fix-the-issues to hidden.

  • Comment 11 months ago ā†’
    šŸ‡®šŸ‡³India manish-31

    manish-31 ā†’ changed the visibility of the branch 3372210-fix-the-issues to active.

  • Comment 11 months ago ā†’
    šŸ‡®šŸ‡³India manish-31

    Resolved conflicts and fixed all the remaining PHPCS issues. Needs review.

  • Status changed to Needs work 10 months ago
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India dev16.addweb

    Hi, I have tested phpcs issues, Need to fix one minor phpcs issue

    modules/custom/cl_editorial/

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                                                                  FIXED  REMAINING
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
modules/custom/cl_editorial/modules/sdc_tags/src/Controller/ComponentTaggingController.php       1      0
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 432ms; Memory: 14MB
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India dev16.addweb

    Hi,
    I have fixed error mention in #21, Please review.

  • Status changed to Needs work 10 months ago
  • Comment 10 months ago ā†’
    a.aaronjake

    Hi @silvi.addweb,

    Applied your changes on MR !9, it applied cleanly but still threw multiple errors. See below:

    cl_editorial git:(2.x) curl https://git.drupalcode.org/project/cl_editorial/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 35763    0 35763    0     0  31781      0 --:--:--  0:00:01 --:--:-- 32017
patching file cl_editorial.module
patching file modules/sdc_tags/sdc_tags.module
patching file modules/sdc_tags/src/ComponentTagDefault.php
patching file modules/sdc_tags/src/ComponentTagPluginManager.php
patching file modules/sdc_tags/src/Controller/ComponentTaggingController.php
patching file modules/sdc_tags/src/Form/AutoTaggingForm.php
patching file src/Element/ComponentSelectorElement.php
patching file src/Form/ComponentFiltersFormTrait.php
patching file src/Form/ComponentInputToForm.php
patching file src/NoThemeComponentManager.php
patching file src/Util.php
patching file src/assets/css/options-filter.css
patching file src/assets/js/options-filter.js
āžœ  cl_editorial git:(2.x) āœ— cd ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cl_editorial

FILE: ...te/drupal-orgissue-v9/web/modules/contrib/cl_editorial/cl_editorial.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 51 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ssue-v9/web/modules/contrib/cl_editorial/src/Form/ComponentInputToForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 29 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 56 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../web/modules/contrib/cl_editorial/src/Element/ComponentSelectorElement.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 39 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 78 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...gissue-v9/web/modules/contrib/cl_editorial/src/NoThemeComponentManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 45 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 575ms; Memory: 12MB

    Kindly check

    Thanks,
    Jake

  • Status changed to Closed: won't fix 6 months ago
  • Comment 6 months ago ā†’
    šŸ‡ŖšŸ‡øSpain pcambra Asturies

    Yeah, we're not doing this.

  • Comment 5 months ago ā†’
    System Message
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024