Remove legacy code from D7

Created on 19 April 2024, 2 months ago

Problem/Motivation

The module currently contains some D7 code in the legacy directory.

As per this comment πŸ“Œ Fix PHPStan issues identified by GitLab CI Needs review , this code should be converted into issues and then removed.

Upon examining the code, though, it may be safe to remove it all. I'm going to do a review on the MR.

πŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡―πŸ‡΅Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • Merge request !14remove legacy code β†’ (Open) created by ptmkenny
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update 2 months ago
    36 pass
  • Pipeline finished with Success
    2 months ago
    Total: 214s
    #151146
  • Status changed to Needs review 2 months ago
  • πŸ‡³πŸ‡±Netherlands MegaChriz

    It's quite possible that nothing from what's left in "legacy" is relevant anymore for the D8+ version of Feeds Tamper. I don't know exactly what every function does or is used for. Or at least I didn't put the effort in yet to read and understand it.

    Some functions do look related to make safe urls for editing a Tamper for a source. In the D8+ version UUID's are used to make safe urls.

  • πŸ‡³πŸ‡±Netherlands MegaChriz

    For example, I don't know where pack('H*', $source) is exactly useful for.

  • πŸ‡―πŸ‡΅Japan ptmkenny

    Ah, that makes sense if the code is about generating safe URLs.

    It certainly seems like there's nothing left useful-- there's a general include file, but all the code it supported is gone, and then the UI submodule, but the 8.x branch already has a working UI.

Production build 0.69.0 2024