- Issue created by @ptmkenny
- last update
8 months ago 36 pass - Status changed to Needs review
8 months ago 1:19pm 19 April 2024 - 🇳🇱Netherlands megachriz
It's quite possible that nothing from what's left in "legacy" is relevant anymore for the D8+ version of Feeds Tamper. I don't know exactly what every function does or is used for. Or at least I didn't put the effort in yet to read and understand it.
Some functions do look related to make safe urls for editing a Tamper for a source. In the D8+ version UUID's are used to make safe urls.
- 🇳🇱Netherlands megachriz
For example, I don't know where
pack('H*', $source)is exactly useful for. - 🇯🇵Japan ptmkenny
Ah, that makes sense if the code is about generating safe URLs.
It certainly seems like there's nothing left useful-- there's a general include file, but all the code it supported is gone, and then the UI submodule, but the 8.x branch already has a working UI.
- Status changed to Needs work
5 months ago 11:20am 1 August 2024 - 🇳🇱Netherlands megachriz
Issues need to be created for the tests that haven't been ported yet. Tag these issues with 'porting'. After that, I think that we can merge this. :)
-
MegaChriz →
committed 6ed0d67c on 8.x-2.x authored by
ptmkenny →
Issue #3442101 by ptmkenny, MegaChriz: Removed legacy code from D7.
-
MegaChriz →
committed 6ed0d67c on 8.x-2.x authored by
ptmkenny →
- Status changed to Fixed
5 months ago 9:28am 10 August 2024 - 🇳🇱Netherlands megachriz
An issue was created for adding additional test coverage: 📌 Add additional test coverage Needs work
And the tests there have all been written.The legacy folder is removed!
Automatically closed - issue fixed for 2 weeks with no activity.