Fix PHPStan issues identified by GitLab CI

------ -------------------------------------------------------------------- Line src/FeedTypeTamperManager.php ------ -------------------------------------------------------------------- 13 Usage of deprecated trait Symfony\Component\DependencyInjection\ContainerAwareTrait in class Drupal\feeds_tamper\FeedTypeTamperManager: since Symfony 6.4, use dependency injection instead ------ -------------------------------------------------------------------- ------ ---------------------------------------------------------------------------------------- Line tests/src/FunctionalJavascript/FeedsTamperJavascriptTestBase.php ------ ---------------------------------------------------------------------------------------- 17 Property Drupal\Tests\feeds_tamper\FunctionalJavascript\FeedsTamperJavascriptTestBase::$modules property must be protected. 💡 Change record: https://www.drupal.org/node/2909426 ------ ---------------------------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line tests/src/Kernel/FeedsTamperKernelTestBase.php ------ ---------------------------------------------------------------------- 17 Property Drupal\Tests\feeds_tamper\Kernel\FeedsTamperKernelTestBase::$modules property must be protected. 💡 Change record: https://www.drupal.org/node/2909426 ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------- Line tests/src/Unit/Adapter/TamperableFeedItemAdapterTest.php ------ ---------------------------------------------------------- 32 Missing call to parent::setUp() method. ------ ----------------------------------------------------------

Comments & Activities

Issue created by @ptmkenny
Comment 8 months ago →
🇳🇱Netherlands megachriz
There are also issues in the /legacy directory, but I assume those are safe to ignore because that code will eventually be rewritten or removed anyway.

That's correct. They are there as a reminder of what isn't ported from the D7 version of Feeds Tamper yet. Perhaps it should be examined what is actually left, and then create issues for them (+ a meta issue to have an overview of these). Then the legacy folder could get removed.
Merge request !13phpstan fixes for tests → (Open) created by ptmkenny
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
last update 8 months ago
36 pass
Pipeline finished with Success
8 months ago
Total: 193s
#151127
Status changed to Needs review 8 months ago12:49pm 19 April 2024
Comment 8 months ago →
🇯🇵Japan ptmkenny
The MR fixes the PHPStan issues with the tests.

📌 phpstan: Usage of deprecated trait Symfony\Component\DependencyInjection\ContainerAwareTrait Active is a separate issue since it involves a deprecation/DI.

Legacy tests can be ignored for now as per #2.
Status changed to Closed: duplicate 5 months ago9:06am 27 July 2024
Comment 5 months ago →
🇳🇱Netherlands megachriz
This has been resolved as part of 📌 Automated Drupal 11 compatibility fixes for feeds_tamper Active .

For anything related to the legacy folder, we have 📌 Remove legacy code from D7 Needs review .

Fix PHPStan issues identified by GitLab CI

Problem/Motivation

Merge Requests

!13Fix PHPStan issues identified by GitLab CI
Open

Comments & Activities

Fix PHPStan issues identified by GitLab CI

Problem/Motivation

Merge Requests

!13Fix PHPStan issues identified by GitLab CIOpen

Comments & Activities

!13Fix PHPStan issues identified by GitLab CI
Open