- Issue created by @Prachi6824
- Assigned to Prachi6824
- Status changed to Needs review
over 1 year ago 8:18am 1 July 2023 - Issue was unassigned.
- 🇮🇳India Prachi6824
Hello,
I have created a patch to solve all the errors related to phpcs code standard but have left these warnings
reported within the .module file.
----------------------------------------------------------------------------------------
144 | WARNING | The use of function dvm() is discouraged
147 | WARNING | The use of function dvm() is discouraged
200 | WARNING | The use of function dvm() is discouraged
204 | WARNING | The use of function dvm() is discouragedI think this function may be replaced by drupal_var_export.
Please review and apply it .
Thank You. - Status changed to Needs work
about 1 year ago 6:44am 17 November 2023 - 🇬🇧United Kingdom scott_euser
Thanks for your work on this, the code reviewed was pre-alpha and very much a prototype code. Now its actually working. I doubt the patch would apply, sorry.
Can we make this a merge request please and have it be a branch off the latest code? y, so I think its now a fresh `phpcs --standard=Drupal,DrupalPractice .`
- 🇬🇧United Kingdom scott_euser
Added gitlab-ci default pipelines so phpcs and phpneon results can be seen when new commits are added to the eventual merge request https://git.drupalcode.org/project/ai_auto_reference/-/pipelines
- First commit to issue fork.
- Assigned to thakurnishant_06
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:46am 17 November 2023 - thakurnishant_06 India
Hi @scott_euser,
Fixed all the errors reported by the code sniffer. Kindly review the changes.
Thank you. - Status changed to Needs work
about 1 year ago 9:15am 17 November 2023 - 🇬🇧United Kingdom scott_euser
Thanks! Can you create the merge request please so I can have a look
- thakurnishant_06 India
Hello @scott_euser,
I hope you are doing well. I have created an MR2 addressing all the remaining PHPCS errors.
-
scott_euser →
committed 7a306b28 on 1.0.x authored by
thakurnishant_06 →
Issue #3371735 by thakurnishant_06, prachi6824, scott_euser: Fix the...
-
scott_euser →
committed 7a306b28 on 1.0.x authored by
thakurnishant_06 →
- Status changed to Fixed
about 1 year ago 1:15pm 22 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.