Madrid
Account created on 10 April 2015, almost 10 years ago
#

Merge Requests

Recent comments

🇪🇸Spain navneet0693 Madrid

This will be landing in Open Social 12.0.6 and above

🇪🇸Spain navneet0693 Madrid

@PCate: 🔥🙌

Superb work ! thank you so much for pushing this.

🇪🇸Spain navneet0693 Madrid

I am having the same issue as suggested in https://www.drupal.org/project/drupal/issues/3342874#comment-14943480 [upstream] Allow inline HTML comments in ckeditor5 Postponed

Also, I did checked on latest Drupal 10 installation with Basic HTML text editor, it behaved the same.

The following

<!--
comment
-->

was stripped when we go out of source ediiting mode.

🇪🇸Spain navneet0693 Madrid

@Wim Leers,

I am willing to offer help, but it seems that my knowledge is limited, I am highly willing to make point 2 in #127 work.

🇪🇸Spain navneet0693 Madrid

@2dareis2do

Why are you dropping Drupal 8 support?

Because even Drupal 9 is going meet it's EOL. Read about more about it: https://www.drupal.org/about/core/policies/core-release-cycles/schedule#...

Also any update on the merge request.

What kind of updates you are looking for here? It's an Open Source world, feel free to contribute to this issue. Here's a guide which will help you : https://www.drupal.org/community/contributor-guide :-)

Would quite like to try this module not able to when running Drupal 10 via composer..

There are multiple solutions to this problem. Try Drupal slack for getting answers.

🇪🇸Spain navneet0693 Madrid

Not sure if this is related, but I have been using this module along with https://www.drupal.org/project/cloudflare/releases/2.0.0-alpha1 on Drupal 10.1 installation, and this was causing

Exception: Only local files should be passed to _locale_parse_js_file(). in _locale_parse_js_file() (line 1131 of core/modules/locale/locale.module).
🇪🇸Spain navneet0693 Madrid

I have just created a fork of this module at https://github.com/navneet0693/ckeditor_entity_link which is working with Drupal 10. I am dropping the link here just in case someone needs this for Drupal 10 based project.

🇪🇸Spain navneet0693 Madrid

Just adding link to https://www.drupal.org/project/ckeditor_entity_link/issues/3312523 📌 CKEditor 5 support: merge with Linkit? Active

🇪🇸Spain navneet0693 Madrid

What is the guidance for this? What steps shall we take for moving the customers from this module to LinkIt?

🇪🇸Spain navneet0693 Madrid

I have made some small changes and removed Drupal 8 support in the MR.

🇪🇸Spain navneet0693 Madrid
+++ b/views_attach_library.info.yml
@@ -1,8 +1,7 @@
+core_version_requirement: ^8 || ^9 || ^10

Drupal 8 support should be removed :-)

🇪🇸Spain navneet0693 Madrid

Though the minimum things required for D10 compatible is already covered in patch in #5

🇪🇸Spain navneet0693 Madrid

For someone looking for a more improvements regarding Drupal 10, please take a look at : https://github.com/navneet0693/views_advanced_cache

🇪🇸Spain navneet0693 Madrid

@sakthi_dev One small suggestion, rest is good to go !

🇪🇸Spain navneet0693 Madrid
+++ b/ape_test/ape_test.info.yml
@@ -1,6 +1,6 @@
+core_version_requirement: ^8 || ^9 || ^10

We should remove Drupal 8 support.

🇪🇸Spain navneet0693 Madrid

I tested this MR along with https://www.drupal.org/project/entity_embed/issues/3272732 Drupal 10 & CKEditor 5 readiness Fixed and it works like charm !

Environment config:

Drupal 10.1 using DDev
PHP 8.1
Embed & Entity Embed 8.x-1.x branches with patches applied

🇪🇸Spain navneet0693 Madrid

I tested this MR along with https://www.drupal.org/project/embed/issues/3309747 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC

Environment config:

Drupal 10.1 using DDev
PHP 8.1
Embed & Entity Embed 8.x-1.x branches with patches applied

🇪🇸Spain navneet0693 Madrid

I am trying to put right status to this issue. According to @Wim Leers's comment in #91, I am believe this should be in "Needs Review" status.

🇪🇸Spain navneet0693 Madrid

I was also facing this issue, but I later found out that the some configuration in database was not updated and it had the condition "php" entry into it.

🇪🇸Spain navneet0693 Madrid

@validoll super thanks for the merge! <3 , would it be possible for making a release as well?

🇪🇸Spain navneet0693 Madrid

This is an incomplete patch. The module description clearly mentions that it requires "Seven" theme or any theme which extends "Seven" theme. In Drupal 10, seven has been removed and moved to https://drupal.org/project/seven which is minimally maintained.

🇪🇸Spain navneet0693 Madrid

Hey @IT-Cru,

Please create a new release of this module for Drupal 10.

🇪🇸Spain navneet0693 Madrid

Hey @Wim Leers,

I request you to please make a release of this module for Drupal 10.

🇪🇸Spain navneet0693 Madrid

@Medha Kumari Patch https://www.drupal.org/project/search_api_opensearch/issues/3339329#comm... Feature: Support for Search API Spellcheck Needs work is rolled for Search API Open Search 2.x branch

🇪🇸Spain navneet0693 Madrid

@kim.pepper thank you for the feedback :-D

I have added the updated doc link and Grammar fixes.

I will try to work on tests soon.

🇪🇸Spain navneet0693 Madrid

@kim.pepper Here's a patch re-rolled to 2.x

🇪🇸Spain navneet0693 Madrid

@kim.pepper Aah, okay. I will re-roll for 2.x. I will put the last and final patch for 1.x here, so that any one using 1.x can patch their modules and use this functionality.

In this patch, I added a data type spell check which is needed for having an aggregated field of type Open Search spell check.

🇪🇸Spain navneet0693 Madrid

Added search_api_spellcheck to "supported features" in Open Search backend.

Production build 0.71.5 2024