Automated Drupal 10 compatibility fixes

Guillaume Aveline → made their first commit to this issue’s fork.

I have tested this patch in Drupal 9.5.7 and 10.0.3. Patch applied cleanly and working as expected. So, moving this to RTBC.

I have tested this patch in Drupal 9.5.7 and 10.0.3. Patch applied cleanly and working as expected. So, moving this to RTBC.

1. +++ b/ckeditor_entity_link.info.yml
   @@ -1,8 +1,7 @@
    dependencies:
   

   The module depends on `drupal/ckeditor` which no longer exists in Drupal 10. This should be changed to `drupal/ckeditor5` if a hard dependency is needed.

2. +++ b/src/Form/CKEditorEntityLinkDialog.php
   @@ -224,7 +224,7 @@ class CKEditorEntityLinkDialog extends FormBase implements BaseFormIdInterface {
   +          $url = \Drupal::service('file_url_generator')->generateAbsoluteString($file->getFileUri());
   

   The dependency should be injected instead.

3. +++ b/src/Plugin/CKEditorPlugin/EntityLink.php
   +++ b/src/Plugin/CKEditorPlugin/EntityLink.php
   @@ -19,7 +19,7 @@ class EntityLink extends CKEditorPluginBase {
   

   CKEditorPluginBase does not exist in Drupal 10.

   I think this class/change could remain unchanged if a new "CKEditor5EntityLink" plugin was created.

4. +++ b/src/Plugin/CKEditorPlugin/EntityLink.php
   @@ -19,7 +19,7 @@ class EntityLink extends CKEditorPluginBase {
   +    return \Drupal::service('extension.list.module')->getPath('ckeditor_entity_link') . '/js/plugins/entitylink/plugin.js';
   
   @@ -45,7 +45,7 @@ class EntityLink extends CKEditorPluginBase {
   +    $path = \Drupal::service('extension.list.module')->getPath('ckeditor_entity_link') . '/js/plugins/entitylink';
   

   In that new plugin, these dependencies should be injected.

I'm not sure if it's possible to make this compatible with both Drupal 9 and Drupal 10. To make it compatible with Drupal 9, a separate CKEditor5 plugin should be created. To make it compatible with Drupal 10, a new branch should be used that only includes dependency on ckeditor5 and/or the ckeditor5 plugin.

Comments addressed.
Switching to version 10 because of the ckeditor5 module and CKEditor5PluginDefault dependency.

Looks like D10 version needs to be separate from D9.
Still work in progress.

Just adding link to https://www.drupal.org/project/ckeditor_entity_link/issues/3312523 📌 CKEditor 5 support: merge with Linkit? Active

I have just created a fork of this module at https://github.com/navneet0693/ckeditor_entity_link which is working with Drupal 10. I am dropping the link here just in case someone needs this for Drupal 10 based project.

Looks like Linkit → module works perfectly with ckEditor 5 module in Drupal 10. I am already using it in one of my project.

@usmanjutt84 ^10.0 means it works with both 10.0 and 10.1 same as ^9.4 works with both 9.4 and 9.5.

Changed it to ^10, please review.

I was thinking, shouldn't we create a release to still require ckeditor 4?

CKeditor4 and Drupal9 have two months to live.
Don't think it worth it.

@joaopauloscho
Removing ^9 and keeping only ^10 breaks the module in the process of updating to D10.
I think it won't hurt keeping it ^9 || ^10

@joaopauloscho
@VladimirAus

Decisions like this make upgrading a D9 site to D10 more difficult for people who are less comfortable with composer.

For those of us who have D9 sites, we have to make a decision to keep or upgrade CKEditor4... And in my case, for most of my sites, I'm keeping CKEDITOR 5 cause many features my clients use on CK4 aren't ready yet.

I suggest removing the ckeditor requirement

and keeping 9 in the core requirements,

That way people who are doing the upgrade can make their own mind up about CK4, but don't have to do any composer song and dance to do the Drupal 10 upgrade.

I would assume ^8.x-1.3 would keep ck4 and support d9 and d10 for upgrade. Removing d9 support would mean you should need a new branch.

If there is a version of this module that is ck5 compatible, it would be it's own branch going forward like 2.0.0 that requires d10 and ck5, but not d9 compatible.

This allows ck4 people to update and stay on ck4 if they have to. And ck5 people can learn about and leverage this tool.

thanks to those working on this! It would be helfpul to at least have a new dev release with d10 support from #3. But in the meantime, I think I'll have to use composer-drupal-lenient to move forward with that patch in composer.

MR!3 works for CKEditor4.
MR!1 crashes for CKEditor4.

Now that there is partial work committed, a ckeditor5 plugin needs to be written so that the module is compatible with Drupal 10 core editor.