CKEditor 5 support: merge with Linkit?

Created on 29 September 2022, about 2 years ago

Updated 16 October 2023, about 1 year ago

Problem/Motivation

CKEditor 4 is going away. See https://www.drupal.org/node/3304481 → .

All contributed modules need to transition to supporting CKEditor 5.

I'm wondering if we can avoid doing a duplicate port here and instead ask users to install linkit (port on its way in 📌 CKEditor 5 readiness Fixed ) ?

It seems the #1 distinction is that it has some special logic in CKEditorEntityLinkDialog::getUrl(), which especially has special handling for media (introduced in #3218837: Link to document (pdf) in media category → , only a month ago).

So: would you at least be open to the idea?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

ckeditor5

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
+1 for this proposal.
Comment over 1 year ago →
🇪🇸Spain navneet0693 Madrid
What is the guidance for this? What steps shall we take for moving the customers from this module to LinkIt?
Comment about 1 year ago →
🇬🇷Greece dimitriskr
This module just adds the entity's uri as an anchor element, even in media entities.

ie.

<p> <a href="/sites/default/files/2023-10/Screenshot%20from%202023-10-12%2017-13-01.png">/sites/default/files/2023-10/Screenshot%20from%202023-10-12%2017-13-01.png</a> </p>
Switching to linkit doesn't seem to interrupt the ck5 upgrade

As for the module itself, I also believe there's no need to do anything here and just move to 'linkit'

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024