Automated Drupal 10 compatibility fixes

I confirm patch #3 makes this work with D10 without errors.
Please provide a D10 compatible release.

+++ b/views_attach_library.info.yml
@@ -1,8 +1,7 @@
+core_version_requirement: ^8 || ^9 || ^10

Drupal 8 support should be removed :-)

I have made some small changes and removed Drupal 8 support in the MR.

Why are you dropping Drupal 8 support?

Also any update on the merge request. Would quite like to try this module not able to when running Drupal 10 via composer..

@2dareis2do

Why are you dropping Drupal 8 support?

Because even Drupal 9 is going meet it's EOL. Read about more about it: https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... →

Also any update on the merge request.

What kind of updates you are looking for here? It's an Open Source world, feel free to contribute to this issue. Here's a guide which will help you : https://www.drupal.org/community/contributor-guide → :-)

Would quite like to try this module not able to when running Drupal 10 via composer..

There are multiple solutions to this problem. Try Drupal slack for getting answers.

Thanks @navneet0693

Ok sounds like you are removing support simply because drupal 8 is no longer supported, not because it will stop working. If that is the case maybe it is better to merge these changes into a major release as that sounds like a breaking change to me.

The patch here looks like it does what it is supposed to but I am still unable to install because due to composer dependency issues.

I am still wondering though, what is holding up this fairly minor change form being released?

I've used lenient to help get past composer issues and to D10. I had to do it with this module. I added the patch in #3 (thank you @mauryarahul11). I then ran these composer commands to make it work with D10.

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/views_attach_library"]'

I agree with @2dareis2do in #11. No reason to remove D8 support in the module. If a breaking change like that is done, a new branch should be made leaving the old intact. Or, what is likely easier, just add ||^10 to the module for now.

I've been using the issue fork on Drupal 10.1 with no issues.

Also bumping to critical as there is no release of the module for any currently supported version of Drupal.

Automatically closed - issue fixed for 2 weeks with no activity.

lazzyvn → closed merge request !2