Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, about 2 years ago
Updated 29 March 2024, 3 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇮🇹Italy kopeboy Mainland

    I confirm patch #3 makes this work with D10 without errors.
    Please provide a D10 compatible release.

  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    🇳🇱Netherlands navneet0693 Amsterdam, Netherlands
    +++ b/views_attach_library.info.yml
@@ -1,8 +1,7 @@
+core_version_requirement: ^8 || ^9 || ^10

    Drupal 8 support should be removed :-)

  • Merge request !2Issue #3290430: Automated Drupal 10 compatibility fixes → (Closed) created by navneet0693
  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇳🇱Netherlands navneet0693 Amsterdam, Netherlands

    I have made some small changes and removed Drupal 8 support in the MR.

  • Comment 10 months ago →
    🇬🇧United Kingdom 2dareis2do

    Why are you dropping Drupal 8 support?

    Also any update on the merge request. Would quite like to try this module not able to when running Drupal 10 via composer..

  • Comment 10 months ago →
    🇳🇱Netherlands navneet0693 Amsterdam, Netherlands

    @2dareis2do

    Why are you dropping Drupal 8 support?

    Because even Drupal 9 is going meet it's EOL. Read about more about it: https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... →

    Also any update on the merge request.

    What kind of updates you are looking for here? It's an Open Source world, feel free to contribute to this issue. Here's a guide which will help you : https://www.drupal.org/community/contributor-guide → :-)

    Would quite like to try this module not able to when running Drupal 10 via composer..

    There are multiple solutions to this problem. Try Drupal slack for getting answers.

  • Comment 10 months ago →
    🇬🇧United Kingdom 2dareis2do

    Thanks @navneet0693

    Ok sounds like you are removing support simply because drupal 8 is no longer supported, not because it will stop working. If that is the case maybe it is better to merge these changes into a major release as that sounds like a breaking change to me.

    The patch here looks like it does what it is supposed to but I am still unable to install because due to composer dependency issues.

    I am still wondering though, what is holding up this fairly minor change form being released?

  • First commit to issue fork.
  • Comment 8 months ago →
    🇺🇸United States eahonet

    I've used lenient to help get past composer issues and to D10. I had to do it with this module. I added the patch in #3 (thank you @mauryarahul11). I then ran these composer commands to make it work with D10.

    composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/views_attach_library"]'

    I agree with @2dareis2do in #11. No reason to remove D8 support in the module. If a breaking change like that is done, a new branch should be made leaving the old intact. Or, what is likely easier, just add ||^10 to the module for now.

  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    david.muffley

    I've been using the issue fork on Drupal 10.1 with no issues.

  • Comment 8 months ago →
    david.muffley

    Also bumping to critical as there is no release of the module for any currently supported version of Drupal.

  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇫🇷France lazzyvn paris
  • Comment 6 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Comment 3 months ago →
    System Message
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024