Error when using markdown module with PHP 8.1 on Drupal 9.3

I add the type hints as @GuyPaddock suggested.

Add Drupal\Core\Link as per #11 🐛 Error when using markdown module with PHP 8.1 on Drupal 9.3 Needs review .

And the patch.

Are the patch(es) in line with the MR?

Of course, identical.

Thank you.

I was getting alot of warning after upgrading my dev environment to php 8.1 with Drupal 9.5.8, adding the patch in #25 did fix the warnings.

Warnings were as shown in the attached screenshot https://imgur.com/a/UfvpwBs.

As its working fine marking this as RTBC.

Thank you

Setting this to major, as PHP 8.1 is currently recommended for Drupal 9 (as the issue already says). And this issue makes testing 📌 Drupal 10 compatibility fixes Fixed quite inconvenient.

Changes in the current MR !17, work great!

• Editing a parser through "/admin/config/content/markdown" doesn't throw any errors or warnings
• Creating a new markdown filter format and using it to create an article also works as expected and doesn't throw any error nor warning

ONLY running the tests will throw a few remaining deprecation notices:

OK (1 test, 1 assertion)

Remaining self deprecation notices (1)

1x: Declaring ::setUp without a void return typehint in Drupal\Tests\markdown\Kernel\Plugin\Markdown\MissingParserTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724 →
1x in DrupalListener::startTest from Drupal\Tests\Listeners

Remaining direct deprecation notices (1)

1x: Using the "Twig_Extension_GlobalsInterface" class is deprecated since Twig version 2.7, use "Twig\Extension\GlobalsInterface" instead.
1x in MissingParserTest::testRenderInstallableLibrary from Drupal\Tests\markdown\Kernel\Plugin\Markdown

Since they are quite minor I'd suggest fixing them aswell, while we are at it.

Ok, there are actually quite a LOT of deprecation errors, so many, that I created a separate issue for fixing these: 🐛 Fix deprecation errors Active . Otherwise, this would be straight up too much for this issue.

So, setting this back to RTBC! Great job everyone! 🙂

Patch in #25 works for me as well.

RTBC ++ for MR.

Thanks.

Automatically closed - issue fixed for 2 weeks with no activity.

Confirming patch #25 🐛 Error when using markdown module with PHP 8.1 on Drupal 9.3 Needs review worked on D9.5.10 on PHP 8.1.18.
Thanks

No credit for reviewers, eh? Oh well. :/