πŸ‡¬πŸ‡§United Kingdom @MustangGB

Coventry, United Kingdom
Account created on 30 April 2010, about 14 years ago
#

Recent comments

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom
πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Hurray, great addition.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Just hard to view the diff when it's 20k lines long.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

If anyone is still interested I've grabbed a snippet of code from a custom module, at least might give you a starting point if you wished to implement something like this.

/**
 * Implements hook_menu_site_status_alter().
 */
function MODULE_menu_site_status_alter(&$menu_site_status, $path) {
  // Before a switch user take note of the original user.
  if (substr($path, 0, 12) === 'devel/switch') {
    global $user;
    global $original_user;
    $original_user = $user;
  }
}

/**
 * Implements hook_user_login().
 */
function MODULE_user_login(&$edit, $account) {
  // After a switch user bypass TFA.
  global $original_user;
  if (!empty($original_user)) {
    $_SESSION['tfa'][$account->uid]['login'] = TRUE;
  }
}
πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Urrm no, the point of administrators having access to user switching is to bypass access checks, otherwise they could just login normally.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Just to mention there is another slight "problem" with mathieuviossat/arraytotexttable.

That being it effectively prevents PHP 8.2 usage.

Reason being that drupal/core-recommended wants psr/container v2.

Whereas mathieuviossat/arraytotexttable wants psr/container v1.

It "kind of works" because laminas/laminas-servicemanager v3.15.0 (which is a dependency of laminas/laminas-text which is a dependency of mathieuviossat/arraytotexttable) allowed for psr/container v1/v2, however this was quickly realised as BC breaking and rolled back.

However as a side effect laminas/laminas-servicemanager v3.15.0 also has PHP 8.1 as a restriction.

The end result being the only option for using drupal/core-recommended and mathieuviossat/arraytotexttable is to use the "broken" laminas/laminas-servicemanager v3.15.0, therefore no PHP 8.2 option.

That being said there is a laminas/laminas-servicemanager v4.0.0-rc2 that does support psr/container v2 and PHP 8.2, so this could be resolved soon-ish.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Thanks.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom
πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

@pjflopes

This is not really the best place to ask.

But you can either disable it globally with $conf['javascript_use_double_submit_protection'] = FALSE;

Or presumably on a per form basis with a hook_form_alter() and removing form_process_button from the relevant submit button #process arrays.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

It looks like you went with the second option: Or add color-X support back for tables.

Can I ask what the problem with the first option was, because if there is a choice of approaches this seems to be preferable as it can just use the built-in Bootstrap CSS rather than requiring additional special case CSS: Either add way to change color-X to table-X for tables.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Has anyone followed the reproduce steps yet?

i.e. Does the table at /admin/reports/updates have the correct colors?

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Any maintainers able to chime in on ✨ Add hook_field_schema_alter() RTBC ?

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

This is still working great, including the change to support *.install added in #127.

#129 is the patch to review.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Of course, identical.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Correct me if I'm wrong, as I've not tested the patch.

But it doesn't look like the user is given any indication that this is happening.

I expected to see something along these lines:

$('.form-actions input', $form).attr('disabled', true);

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Can remove:

protected function validate($code) {
  <snip>
}

Because it was added to tfa 7.x-2.x as timingSafeEquals() in #3183248: Use hash_equals instead of === β†’ .

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

MustangGB β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Rebase and updated to v6.1.0 (to match HEAD).

And a patch for use with cweagans/composer-patches.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

MustangGB β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

And the patch.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Add Drupal\Core\Link as per #11 πŸ› Error when using markdown module with PHP 8.1 on Drupal 9.3 Needs review .

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

MustangGB β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Re-upload of existing patch to check tests.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

@joseph.olstad Thanks for your hard work.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

I leave the decision to the module maintainers, I just make my requests.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Seems to be okay now.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Re-opening this to ask if the commit intentionally changed arrays to use the short syntax.

Drupal 7 supports PHP 5.2.5 and short array syntax wasn't added until PHP 5.4, so as a general rule no-one else is doing this in D7.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Re-roll with very minor whitespace fix.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

MustangGB β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

I originally considered jquery_update.autocomplete.fix, meaning all fixes related to autocomplete.

But as the thing that changed was the functionality of position() thought it made more sense to go with jquery_update.position.fix, meaning all fixes related to position, it just so happens that the only place we've found to fix so far is in autocomplete, but in theory fixes for other elements could also go in this file.

I'd not considered jquery_update.autocomplete_position.fix, because as previously mentioned I wanted to keep the door open to other fixes relating to position() to have a place to go.

If you're still sure you'd like to change it I will update the patch, please let me know.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom
πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Simple? Not sure about that.

Are you sure you tested with the autocomplete in a table?

Nevertheless, added some more in-depth repro steps to the description.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Thanks.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

It's already on the priority list #3207851: [meta] Priorities for 2021-06-02 release of Drupal 7 β†’ , we don't need to update the labels anymore.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

@Ronino
For D7 please comment in πŸ› [D7] node_access filters out accessible nodes when node is left joined Postponed and perhaps the maintainers will see it, also there is a more recent re-roll.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Hey thetwentyseven, please see πŸ› [D7] node_access filters out accessible nodes when node is left joined Postponed for the D7 backport.

πŸ‡¬πŸ‡§United Kingdom MustangGB Coventry, United Kingdom

Patch looks good to go and #13 has been addressed.

Production build 0.69.0 2024