- 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Thanks for all the cleanup.
It's definitely not intentional that the tests would need to be updated when a new jQuery release is published, but it looks like
\JqueryUpdateTestCase::testExampleCustomPaths()
will indeed have that problem becausejquery_update_settings_form()
does this when putting the examples in the form:$latest_version = jquery_update_latest_version('jquery'); $example_version = $latest_version ? $latest_version : JQUERY_UPDATE_EXAMPLE_JQUERY_VERSION;
So let's set this variable to FALSE before requesting the admin form in this test:
function jquery_update_latest_version($library = 'jquery', $refresh = FALSE) { $check_enabled = variable_get('jquery_update_check_latest_versions', TRUE);
I think that should mean the defaults from the constants are always used and the test should remain consistent.
- 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Sorry; I misread the changes in the MR and missed that @MustangGB had already made the change I outlined in my last comment.
Reviewing the MR now... looks good so far.
-
mcdruid →
committed 57b1861c on 7.x-4.x authored by
MustangGB →
Issue #3327465 by MustangGB, poker10: Fix broken tests
-
mcdruid →
committed 57b1861c on 7.x-4.x authored by
MustangGB →
- Status changed to Fixed
almost 2 years ago 2:26pm 23 January 2023 - 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Thanks! Hopefully this unblocks 🐛 jQuery 3.3+ breaks autocomplete Fixed
... I think 🐛 [PHP 8.2] Creation of dynamic property JqueryUpdateTestCase::$full_admin is deprecated Closed: duplicate can also be closed as a duplicate as the changes here fixed that.
Automatically closed - issue fixed for 2 weeks with no activity.