- π¬π§United Kingdom mustanggb Coventry, United Kingdom
Re-roll with very minor whitespace fix.
- πΊπΈUnited States brad.bulger
reroll for 7.98 - removed a trailing whitespace line from node.test
- Status changed to Needs review
11 months ago 8:19am 5 January 2024 - last update
11 months ago 2,168 pass - last update
11 months ago run-tests.sh exception - last update
11 months ago 2,168 pass - πΈπ°Slovakia poker10
Parent issue was fixed, so moving back to needs review, as we should compare with D10 patch which was committed.
- π¨π¦Canada joseph.olstad
A tests-only test run it would help us move this along faster.
A tests-only test run using the same tests in #34 without the fix code should result in a test failure. If we show a test failure along with the pass results from #34, it should help move this along quickly.
- πΊπΈUnited States laryn
Should `ConditionInterface` be `QueryConditionInterface`?
- Status changed to Needs work
8 months ago 11:16pm 24 March 2024 - πΈπ°Slovakia poker10
Nice catch! It seems like the
ConditionInterface
does not exists in D7.I think it would help to convert this into MR, fix this and run test-only test as suggested by @joseph.olstad. However I would expect that also previous tests runs would fail based on this non-existing interface, but maybe this part is not tested at all?
- Merge request !7172Draft: Issue #3176634 by MustangGB, izmeez, voleger, skylord: [D7] node_access... β (Open) created by joseph.olstad
34:20 33:14 Running- π¨π¦Canada joseph.olstad
This patch/MR breaks PHP 8.2 compatibility. These properties must be defined in the test class.
Exception Deprecated node.test 3042 NodeAccessJoinTest->setUp() Creation of dynamic property NodeAccessJoinTest::$field_name is deprecated Exception Deprecated node.test 3043 NodeAccessJoinTest->setUp() Creation of dynamic property NodeAccessJoinTest::$field is deprecated Exception Deprecated node.test 3090 NodeAccessJoinTest->testNodeAccessJ Creation of dynamic property NodeAccessJoinTest::$authorUser is deprecated Exception Deprecated node.test 3093 NodeAccessJoinTest->testNodeAccessJ Creation of dynamic property NodeAccessJoinTest::$otherUser is deprecated Exception Deprecated node.test 3126 NodeAccessJoinTest->testNodeAccessJ Creation of dynamic property NodeAccessJoinTest::$articles is deprecated Exception Deprecated node.test 3232 NodeAccessJoinTest->testNodeAccessJ Creation of dynamic property NodeAccessJoinTest::$regularUser is deprecated Exception Deprecated node.test 3253 NodeAccessJoinTest->testNodeAccessJ Creation of dynamic property NodeAccessJoinTest::$accessUser is deprecated