[D7] node_access filters out accessible nodes when node is left joined

Created on 13 October 2020, about 4 years ago
Updated 25 March 2024, 8 months ago

Problem/Motivation

Backport of πŸ› node_access filters out accessible nodes when node is left joined Needs work .

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

7.0 ⚰️

Component
Node systemΒ  β†’

Last updated about 8 hours ago

No maintainer
Created by

πŸ‡¬πŸ‡§United Kingdom mustanggb Coventry, United Kingdom

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¬πŸ‡§United Kingdom mustanggb Coventry, United Kingdom

    Re-roll with very minor whitespace fix.

  • πŸ‡ΊπŸ‡ΈUnited States crystaldawn

    A re-roll is needed to apply to 7.97

  • πŸ‡ΊπŸ‡ΈUnited States brad.bulger

    reroll for 7.98 - removed a trailing whitespace line from node.test

  • Status changed to Needs review 11 months ago
  • last update 11 months ago
    2,168 pass
  • last update 11 months ago
    run-tests.sh exception
  • last update 11 months ago
    2,168 pass
  • πŸ‡ΈπŸ‡°Slovakia poker10

    Parent issue was fixed, so moving back to needs review, as we should compare with D10 patch which was committed.

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    A tests-only test run it would help us move this along faster.

    A tests-only test run using the same tests in #34 without the fix code should result in a test failure. If we show a test failure along with the pass results from #34, it should help move this along quickly.

  • πŸ‡ΊπŸ‡ΈUnited States laryn

    Should `ConditionInterface` be `QueryConditionInterface`?

  • Status changed to Needs work 8 months ago
  • πŸ‡ΈπŸ‡°Slovakia poker10

    Nice catch! It seems like the ConditionInterface does not exists in D7.

    I think it would help to convert this into MR, fix this and run test-only test as suggested by @joseph.olstad. However I would expect that also previous tests runs would fail based on this non-existing interface, but maybe this part is not tested at all?

  • Pipeline finished with Success
    8 months ago
    Total: 465s
    #127976
  • 34:20
    33:14
    Running
  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    This patch/MR breaks PHP 8.2 compatibility. These properties must be defined in the test class.

    Exception Deprecated node.test         3042 NodeAccessJoinTest->setUp()        
        Creation of dynamic property NodeAccessJoinTest::$field_name is deprecated
    Exception Deprecated node.test         3043 NodeAccessJoinTest->setUp()        
        Creation of dynamic property NodeAccessJoinTest::$field is deprecated
    Exception Deprecated node.test         3090 NodeAccessJoinTest->testNodeAccessJ
        Creation of dynamic property NodeAccessJoinTest::$authorUser is deprecated
    Exception Deprecated node.test         3093 NodeAccessJoinTest->testNodeAccessJ
        Creation of dynamic property NodeAccessJoinTest::$otherUser is deprecated
    Exception Deprecated node.test         3126 NodeAccessJoinTest->testNodeAccessJ
        Creation of dynamic property NodeAccessJoinTest::$articles is deprecated
    Exception Deprecated node.test         3232 NodeAccessJoinTest->testNodeAccessJ
        Creation of dynamic property NodeAccessJoinTest::$regularUser is deprecated
    Exception Deprecated node.test         3253 NodeAccessJoinTest->testNodeAccessJ
        Creation of dynamic property NodeAccessJoinTest::$accessUser is deprecated
    
  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    Needs a small amount of work to fix this.

Production build 0.71.5 2024