Account created on 14 March 2007, over 17 years ago
#

Merge Requests

Recent comments

🇺🇸United States laryn

LGTM. This has also been pulled into the Backdrop version of the module and is in the latest release there, working nicely. Thank you!

https://github.com/backdrop-contrib/feeds_xpathparser/commit/d2335ed39cb...

🇺🇸United States laryn

Thanks for taking the time to make it easier for people to understand how to use this!

I'm using a variation of your suggestion in the Backdrop version -- the only change I think would be needed here is that you've used the word "prefix" in a few locations but the "(selective)" text is actually added as a suffix.

🇺🇸United States laryn

It's also present in the 7.x branch. I can fix that one, too, after this one is merged if you like.

🇺🇸United States laryn

I've made the initial port and an initial release, so I'll mark this as complete.

- https://github.com/backdrop-contrib/webform_term_opts

🇺🇸United States laryn

@avpaderno I am interested in maintaining for security fixes, not likely for any major new development in the Drupal 7 version.

🇺🇸United States laryn

I would like to use this on a Backdrop site I'm working on, so I've done an initial port. If any of the maintainers here are interested in co-maintaining there, please let me know. You'd be more than welcome! Thanks for all the effort that's gone into this module over the years. Hopefully it's gratifying to see that effort branch out into another realm and live on. :)

@stpaultim It looks like you removed your earlier work at some point so I have moved the port I just made into place at the URL you posted. If you're still interested, please feel free to test things out and report back in the Backdrop issue queue.

🇺🇸United States laryn

We came across this on a Backdrop site using multifield and the last patch here was successful. It's been merged into the Backdrop version and will be included in the next release there. Marking RTBC here as well.

https://github.com/backdrop-contrib/multifield/commit/dfbef95c3d23d92dbc...

🇺🇸United States laryn

It sounds like Backdrop would be perfect for you. See earlier comments on this page for more info if interested.

🇺🇸United States laryn

No worries -- and I've already got you added to credits and have retained the (very short) commit history as well, so you are there already. ;)

🇺🇸United States laryn

I had a simple need for this functionality so I went ahead and ported it -- I didn't see your issue already here before I did so. Sorry about that, but you may be interested that this is now available for Backdrop:

- https://github.com/backdrop-contrib/behavior_weights

@donquixote Thanks for your work on this module. If you are interested in co-maintaining for Backdrop please let me know. You'd be very welcome!

🇺🇸United States laryn

Seems like a good idea to me. Here's an approach I used in the Backdrop version which would be easy to port back to Drupal 7 if desired:

https://github.com/backdrop-contrib/views_contextual_filter_query/commit...

🇺🇸United States laryn

Looks good to me, too.

🇺🇸United States laryn

I think I'm far enough for an initial release. Work will continue here: https://github.com/backdrop-contrib/linked_field

🇺🇸United States laryn

An accessibility review flagged this for me in the Backdrop version of this module as well, prompting me to find this issue in the Drupal queue. Here's the commit that fixed it for Backdrop:

https://github.com/backdrop-contrib/back_to_top/commit/fd2e03c2227fd2c02...

I went with the nav plus the aria-label for context on the nav (and we also have it on the button -- I'm told it's correct to have it in both places).

🇺🇸United States laryn

I've made an initial alpha release for Backdrop and will work from there. I've pulled over some of the improvements you've put into the D10 version -- thanks again for all your work on this! The invitation above is a standing invitation. ;)

https://github.com/backdrop-contrib/google_translator

🇺🇸United States laryn

I've made an initial alpha release with the noted adaptations:

- https://github.com/backdrop-contrib/composer_manager/releases

🇺🇸United States laryn

Should `ConditionInterface` be `QueryConditionInterface`?

🇺🇸United States laryn

The work of porting is well underway -- and I've made an alpha release for testing.

https://github.com/backdrop-contrib/entityreference_view_widget

🇺🇸United States laryn

I've recently pulled in all the latest commits to the Backdrop version and have functional tests all green. I came to say that I'm grateful to the team here for all the work over the years and I found this issue -- I'll mark it as fixed at this point.

🇺🇸United States laryn

I'm working on the Backdrop port of this module 💬 Backdrop CMS Port? Fixed and I don't get a fatal error but the patch looks right. I've tested it and am including it there -- thanks @mvc!

https://github.com/backdrop-contrib/seckit/commit/915f914a68dc75ccf1e21a...

🇺🇸United States laryn

I am working on the Backdrop port. I should have an official release this month.

If any of the maintainers for Drupal are interested in maintaining or co-maintaining for Backdrop, you're more than welcome. Just let me know -- and thanks for all the work on this module over the years!

https://github.com/backdrop-contrib/seckit

🇺🇸United States laryn

I've started work on this port and in the next few days I hopefully will release an initial alpha version to encourage testing and continued development:

- https://github.com/backdrop-contrib/cer

🇺🇸United States laryn

I'm working on something similar for the Stripe module for Backdrop CMS (which has incorporated this module's functionality into it). The direction I'm going is that if there is a zero/empty value for the payment amount, then it skips the credit card popup and just submits the webform normally. (This zero value could be provided by one option in a selection, the results of custom processing in the provided hook, etc. and makes an optional "pay what you can/want" functionality possible.)

I have a PR that is working in early testing on Backdrop. @joelstein, if you are interested I can probably submit a substantially similar patch here. Take a look and let me know if you think it's a good direction:

- https://github.com/backdrop-contrib/stripe/pull/30/files

🇺🇸United States laryn

I've made an initial release for Backdrop, marking complete.

🇺🇸United States laryn

I needed this module in a Backdrop project and as part of porting it, I've tested and confirmed this patch, which is included in the Backdrop release:

- https://github.com/backdrop-contrib/field_collection_feeds/commit/252d7a...

Thank you both!

🇺🇸United States laryn

I'd love to hear your thoughts after you spin up an experimental site.

🇺🇸United States laryn

Sorry to see you go and wish you the best.

The situation you describe strikes many of the same chords that led to the fork of Drupal known as Backdrop. I'm curious if you heard of (or explored) that option of staying in the wider Drupal family via Backdrop, as you were deciding which direction to go?

🇺🇸United States laryn

I'm looking at this in the Backdrop version, where a contributor has made the following comment:

> I don't agree with the fix there. It makes more sense to define property $tags, since it's integral to the functioning of the class.

There is a PR on the issue to do so in Backdrop, which could easily be ported here for Drupal 7 if you agree:
https://github.com/backdrop-contrib/search_api/issues/57

🇺🇸United States laryn

I've added a MR here, and I'm attaching a screenshot to compare to the original.

🇺🇸United States laryn

Sorry, my editor "fixed" something and I didn't realize it made it into the first patch. Here's a clean version.

🇺🇸United States laryn

Here's a patch that doesn't immediately strip_tags on the result, only if it is not empty.

🇺🇸United States laryn

Agreed that the patch does what it should. I am working on the Backdrop version of this module and have merged the patch after testing there.

🇺🇸United States laryn

Thanks @gresko8! The patch looks good and applies cleanly.

@hargobind, are you able to do some testing on your sites?

🇺🇸United States laryn

Content Access is specifically mentioned in the security advisory for ACL 1.4: https://www.drupal.org/sa-contrib-2023-034

I maintain the Backdrop version and what I've done there is along the lines of what ACL has done in switching from using `serialize` to `json_encode` -- so it requires an update hook to convert any Content Access settings saved in the database from serialization to json_encoding, as well.

Here's the relevant commit: https://github.com/backdrop-contrib/content_access/commit/4a45c548414df6...

Would you consider expanding this issue and patch to include that sort of change for security hardening?

🇺🇸United States laryn

I've merged a fix for this into the Backdrop version, based on the work here. Thank you to whthat, Aaron Wolfe (awolfey), Tess Bakker, candelas, Thomas Slott (bigslott), and Esben von Buchwald (esbenvb)!

I made a few additional tweaks to the latest MR from whthat for more performance gains:

- Don't use `image_path_flush` but break out a piece of that function so we can target the specific image and a specific style in the path.
- Unset the styles that have no changes along the way so that `manualcrop_save_crop_data` is only called on the styles that need it.

You can see that commit here if interested:

- https://github.com/backdrop-contrib/manualcrop/commit/8d71b5ddf45b2ad1be...

🇺🇸United States laryn

> The main issue is that moving from v0.9 to 1.0 imgAreaSelect adds a pixel to the lower right corner in setSelection() which ultimately caused the initial selection of ManualCrop to be empty.

I am not using the Drupal 7 version anywhere so I can't fully test this patch, but I can confirm that when using v1.0.0-rc.1 of imgAreaSelect in the Backdrop version, this trick of subtracting the pixel from x2 and y2 does seem to be necessary to get the selection to show up on initial load. (Thanks @peximo!)

🇺🇸United States laryn

I took the patch from #11 and manually worked it into a PR for the Backdrop version of this module and can confirm that the basic logic works well.

🇺🇸United States laryn

I was running into this issue on a Backdrop site and have tested a slightly modified patch over there (only modified for Backdrop-specific details like config instead of variables, authmap function name change, etc.) and it seems to be working great.

I've duplicated this issue and filed the derivative PR here:
https://github.com/backdrop-contrib/simplesamlphp_auth/issues/24

One minor textual suggestion. @codebymikey on this line:

> Note that the option to allow the login and external accounts should only be used...

Should it rather be the following?

> Note that the option to allow the login and link accounts should only be used...

🇺🇸United States laryn

@candelas The Backdrop version has a stable release so if you upgrade your D7 site to Backdrop the module should continue to work. Or maybe I'm misunderstanding your question?

🇺🇸United States laryn

I installed Open Atrium locally and took a screenshot. It does seem like there's something awry here that we'll need to dig into.

Production build 0.71.5 2024