The button should be included in a landmark

Good point - while the aria-label is important (thanks for adding it!), the landmark usefulness is debatable. Screen readers usually give hte option to jump to other sections, so perhaps an aria-hidden="true" might also be considered. If the landmark is needed, I agreed that a nav would make more sense than a div.

An accessibility review flagged this for me in the Backdrop version of this module as well, prompting me to find this issue in the Drupal queue. Here's the commit that fixed it for Backdrop:

https://github.com/backdrop-contrib/back_to_top/commit/fd2e03c2227fd2c02...

I went with the nav plus the aria-label for context on the nav (and we also have it on the button -- I'm told it's correct to have it in both places).

This is fixed in 3.0.x-dev and going into 3.0.1. Thanks for the help and you are credited in the multi commit (I hope so anyway).

Cool to see that Backdrop is thriving! And thanks for the tip about

acke → closed merge request !4

Automatically closed - issue fixed for 2 weeks with no activity.