🇮🇹Italy nironan
Worked like a charm!
🇮🇹Italy nironan
I saw this got merged, thanks a lot! Marking as fixed
🇮🇹Italy nironan
Works like a charm, marking as RTBC
🇮🇹Italy nironan
Opened a MR to fix two deprecations.
🇮🇹Italy nironan
Rebased against 3.x, here is the diff: https://git.drupalcode.org/project/svg_image/-/merge_requests/18.diff
🇮🇹Italy nironan
Rerolled against 3.x.
🇮🇹Italy nironan
🇮🇹Italy nironan
Rerolled against 2.x, only with the option to set the time, as I am not really sure how to proceed with the effect - nor if it is actually of any need.
🇮🇹Italy nironan
Good point - while the aria-label is important (thanks for adding it!), the landmark usefulness is debatable. Screen readers usually give hte option to jump to other sections, so perhaps an aria-hidden="true" might also be considered. If the landmark is needed, I agreed that a nav would make more sense than a div.