Account created on 30 March 2010, almost 15 years ago
#

Recent comments

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev, going into 3.0.3.

πŸ‡ΈπŸ‡ͺSweden acke

acke β†’ created an issue.

πŸ‡ΈπŸ‡ͺSweden acke

Okay, the code was correct but should be in back_to_top.install. Thanks to Peter TΓΆrnstrand for the information.

Numbering the hook is quite tricky but it works for me.

This will go into a 3.0.2 release next week.

πŸ‡ΈπŸ‡ͺSweden acke

The warning will disappear if you add a value at:
/admin/config/user-interface/back_to_top

But I think this update hook should set a default value, but it don't seem to work:

/**
 * Implements hook_update_N().
 * 
 * Add default value to the speed config field.
 */
function back_to_top_update_91001() {
  $config = \Drupal::configFactory()->getEditable('back_to_top.settings');
  $config->set('back_to_top_speed', 1200);
  $config->save();
}

Fortunately there is a default in the javascript so it does not bug out and at installation the value is set via yml.

Any ideas why the update hook is not working? Otherwise, it may just be a matter of adding an empty check to that particular line of code and accepting that the field is empty initially when updating

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev going into 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

I tested this, and the 'Prevent on administration pages and node edit' option causes the button to disappear on the /node/[nid]/edit pages.

It may be necessary to clear the cache either via the Performance page at /admin/config/development/performance or by running drush cr.

πŸ‡ΈπŸ‡ͺSweden acke

This looks great, and I’ve incorporated a slightly revised version of the instructions into the README.md. Fixed in 3.0.x-dev and going into 3.0.1. Thanks for your input and help Bruce!

πŸ‡ΈπŸ‡ͺSweden acke

he uninstall hooks have been removed from the 2.x-dev branch. These hooks were never part of the 2.0.0 or 3.0.0 releases, but it seems some users somehow accessed the development code. The issue should now be resolved.

πŸ‡ΈπŸ‡ͺSweden acke

This has been resolved in 3.0.x-dev and will be included in the 3.0.1 release. Thank you for your assistance; you’ve been credited in the multi-issue commit. Due to the absence of a 3.0.x-dev branch and the complexity of multiple issues, it wan't possible to use the merge requests.

πŸ‡ΈπŸ‡ͺSweden acke

This has been addressed in the 3.0.x release. Thank you for the inspiration and all your hard work. In hindsight, this solution aligns closely with what we ultimately implemented and likely could have been committed earlier. You should have been credited for this, and I apologize for not recognizing that before the commit."

πŸ‡ΈπŸ‡ͺSweden acke

This was never in 2.0.0 and only in 2.x-dev. A co-maintainer commited this but it's now removed in this old dev branch. I recommend 3.0.x and the upcoming 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

Thanks Carlos! This is fixed in the multi commit https://git.drupalcode.org/project/back_to_top/-/commit/adb57d41e337b676...

I'm very sorry I missed credit you in the commit, but I will always remember your excellent patch.

Also there is a new 3.0.x-dev branch now with the code and this is going into the 3.0.1 release.

πŸ‡ΈπŸ‡ͺSweden acke

This is fixed in 3.0.x-dev and going into 3.0.1. Thanks for the help and you are credited in the multi commit (I hope so anyway).

Cool to see that Backdrop is thriving! And thanks for the tip about

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev and going into 3.0.1. Unfortunately I missed this issue in the multi commit, sorry about that but thanks for all the help.

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev with new speed parameter and going into 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

`window.scrollTo({ top: 0, behavior: 'smooth' });` don't work because it uses jquery.ui, Back To Top refactored the smooth scroll effect in js:

      easeOutQuart = function (t, b, c, d) {
	      t /= d;
	      t--;
	      return -c * (t * t * t * t - 1) + b;
      },

But it's sensible to add a speed parameter so webmasters can adjust the speed after preference and desired performance.

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev and going into 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 3.0.x-dev and going into 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

I think it's clearest to have a logo that looks like the button. Fixed in 3.0.x-dev and going into 3.0.1.

πŸ‡ΈπŸ‡ͺSweden acke

Cleaning up old issues. Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0.

πŸ‡ΈπŸ‡ͺSweden acke

Cleaning up old issues. This is possible by theming the button.

πŸ‡ΈπŸ‡ͺSweden acke

It should work in Gin with the setting for Navigation (Drupal Toolbar) "Legacy, Classic Drupal Toolbar". This is where Manage, Shortcuts and Usernamne also is found.

πŸ‡ΈπŸ‡ͺSweden acke

This was not a good solution. See issue #3403090

πŸ‡ΈπŸ‡ͺSweden acke

Correct, this should be removed. But the back_to_top_post_update_uninstall_modules is only in the 2x dev branch not 3.0.0?

πŸ‡ΈπŸ‡ͺSweden acke

Yes, I got a:

Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of /mnt/persist/www/mawtest.wallenberg.org/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php).

πŸ‡ΈπŸ‡ͺSweden acke

Confirm 1.1 don't work for D10. I think there should be an accessCheck:

$entity_id = $query->getQuery()
  ->condition('uri', substr($image_uri, 0, strrpos($image_uri, '.')) . '.', 'STARTS_WITH')
  ->accessCheck(TRUE);
  ->execute();
πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 1.0.4. Thanks!

πŸ‡ΈπŸ‡ͺSweden acke

Fixed in 1.0.4. Thanks!

πŸ‡ΈπŸ‡ͺSweden acke

acke β†’ made their first commit to this issue’s fork.

πŸ‡ΈπŸ‡ͺSweden acke

This was a bug in Drupal Media and is fixed in https://www.drupal.org/project/drupal/issues/3377562 πŸ“Œ Update CKEditor 5 to 39.0.0 Fixed

πŸ‡ΈπŸ‡ͺSweden acke

Thumbs up from me. It would be excellent with a working Drupal 10 release.

πŸ‡ΈπŸ‡ͺSweden acke

I tried this and it works in Drupal 10.

Production build 0.71.5 2024