- Issue created by @cboyden
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:33am 16 November 2023 - last update
about 1 year ago 24 pass - πΊπΈUnited States laryn
I'm looking at this in the Backdrop version, where a contributor has made the following comment:
> I don't agree with the fix there. It makes more sense to define property $tags, since it's integral to the functioning of the class.
There is a PR on the issue to do so in Backdrop, which could easily be ported here for Drupal 7 if you agree:
https://github.com/backdrop-contrib/search_api/issues/57 - last update
12 months ago 24 pass - π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for reporting this issue, and especially for already providing a patch!
However, I agree with @argiepiano in the Backdrop PR: We should just declare that property, especially if itβs already set in the constructor.
Patch attached, please test/review! - πΊπΈUnited States argiepiano
drunken monkey β credited argiepiano β .
-
drunken monkey β
committed 1209b0a6 on 7.x-1.x
Issue #3402005 by drunken monkey, argiepiano, cboyden, laryn: Fixed...
-
drunken monkey β
committed 1209b0a6 on 7.x-1.x
- Status changed to Fixed
11 months ago 9:21am 23 December 2023 - π¦πΉAustria drunken monkey Vienna, Austria
Merged. Thanks again, everyone!
Automatically closed - issue fixed for 2 weeks with no activity.