πŸ‡ΊπŸ‡ΈUnited States @argiepiano

Account created on 31 August 2013, about 11 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States argiepiano

I ported this module to Backdrop CMS. The commit history is preserved, and the D7 maintainers are given credit as well. If anybody here wishes to become co-maintainer, let me know. https://github.com/backdrop-contrib/uc_affiliate2

πŸ‡ΊπŸ‡ΈUnited States argiepiano

This patch only offer feeds support for nodes. How about other core entities like user and taxonomy terms?

πŸ‡ΊπŸ‡ΈUnited States argiepiano

argiepiano β†’ changed the visibility of the branch 7.x-3.x to active.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

argiepiano β†’ changed the visibility of the branch 7.x-3.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

I've submitted a merge request. Sorry, I haven't done patches and requests for Drupal for a few years, and I think the workflow is not different. Apologies if this was not done correctly.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

The patch in #3 doesn't solve the warning. It does set the default value to 0, which is needed, but the warning persists.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

This warning is a regression introduced by this commit, as part of this issue πŸ› Weight default value is an array, error when saving Fixed .

The problem here happens in the Manage field UI, when adding a new weight field. When you add a new field, weight_field_widget_form() receives an empty array in the $items parameters. The new (faulty) code added in the commit above doesn't check to see if the key 'value' exists.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

Hmm... this fix actually alters the behavior of other module's views forms. For example, Views Bulk Operation displays the views form even if there are no results. After the patch, the VBO views form is not shown.

While this may seem harmless (after all, you don't need a VBO form if there are no results), I don't think an individual module should make the decision to hide all views forms.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

The fix provided in this issue actually misses a couple of properties in class backup_migrate_filter_utils:

  • backup_migrate_filter_utils::saved_site_offline
  • backup_migrate_filter_utils::saved_site_offline_message
πŸ‡ΊπŸ‡ΈUnited States argiepiano

Thank you, @mradcliffe!

The module is now fully ported for Backdrop CMS and can be found at https://github.com/backdrop-contrib/agreement

Among the changes, the Backdrop version now stores all settings for agreement types in config json files, which makes them convenient for importing/exporting among sites through Backdrop's core Configuration manager.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

argiepiano β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

Patch #5 fixed it for me too.

πŸ‡ΊπŸ‡ΈUnited States argiepiano

OOPS! I just noticed this was already ported. Closing!

Production build 0.71.5 2024