Deprecation messages with PHP 8: Creation of dynamic property...

I think the best approach would be to add those properties to the backup_migrate_destination and backup_migrate_destination_filesource classes.

Here's a starting point. backup_migrate_item::to_array() looks like it demands the #[AllowDynamicProperties] attribute.

According to https://www.php.net/manual/en/language.oop5.properties.php :

Dynamic properties are deprecated as of PHP 8.2.0. It is recommended to declare the property instead. To handle arbitrary property names, the class should implement the magic methods __get() and __set(). At last resort the class can be marked with the #[\AllowDynamicProperties] attribute.

(This is response to the person who was unsure about which PHP 8 version was causing the problem and also to highlight the available and the recommended solutions.)

Thanks for the patch. Works for me.

The patch works perfectly for me.

I don't think the automated test against PHP 8.2 & MySQL 8, D7 is a representation of this patch and more than likely exposes other areas of the module that need to be updated for PHP 8.2 & MySQL 8.

I see no reason why this can't be set to Reviewed and Tested by the community so it can be rolled out but perhaps someone else can weigh in on it to see any issues.

Cheers,
Andrew

Tested patch as well in my D7 instance, worked as expected, no more warnings after this (attached screenshots), tested functionality too, moving this to RTBC.

Can confirm that patch in comment #4 fixes this with PHP 8.2.

The fix provided in this issue actually misses a couple of properties in class backup_migrate_filter_utils:

• backup_migrate_filter_utils::saved_site_offline
• backup_migrate_filter_utils::saved_site_offline_message

I created a MR from patch in #4 and addresses #10.

Would be nice to get this in to fix the PHP8.2 incompatibilities.

I applied the patch from #4 an the MR from #12 and all works fine now (php 8.2).

Thank you!

Committed. Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.