Contrib.social

Refactor event subscriber to use LocalRedirectResponse to fix GitLab CI

Open on Drupal.org →
Created on 14 October 2023, about 1 year ago
Updated 22 November 2023, 12 months ago

Problem/Motivation

GitLab CI runs the tests in a sub-directory, which fails due to using relative redirects.

Steps to reproduce

See tests

Proposed resolution

We should use LocalRedirectResponse and also pass an absolute URL. This is going to require lots of test refactor.

The EventSubscriber unit test probably needs to become a kernel test due to Drupal core.
The functional tests may no longer be asserting the correct thing.
The agreement path config entity may need to be updated to start with a slash much like all the other Drupal core path options so that we don't need to figure out the base path ourselves.

Remaining tasks

Figure it out in a merge request.

User interface changes

N/A

API changes

N/A

Data model changes

Config entity changes.

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States mradcliffe USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024