ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty

Created on 14 February 2024, 9 months ago

Problem/Motivation

When an XML feed returns an empty string, the there will be a fatal error:

ValueError: DOMDocument::loadXML(): Argument #1 ($source) [error]
must not be empty in DOMDocument->loadXML() (line 41 of
/var/www/lehrberuf/docroot/profiles/recruiter/modules/feeds_xpathparser/FeedsXPathParserXML.inc).#0
/var/www/lehrberuf/docroot/profiles/recruiter/modules/feeds_xpathparser/FeedsXPathParserXML.inc(41):

This should be a normal exception, not a fatal error.

Steps to reproduce

Try to import an XML feed that is empty.

Proposed resolution

Check if feed is empty.

Remaining tasks

PR review

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇦🇹Austria klausi 🇦🇹 Vienna

Live updates comments and jobs are added and updated live.

PHP 8.1
The issue particularly affects sites running on PHP version 8.1.0 or later.

Comments & Activities

Issue created by @klausi
Comment 9 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Status changed to Needs review 9 months ago7:47am 14 February 2024
Open on Drupal.org →
Core: 7.x + Environment: PHP 5.3 & MySQL 5.5
last update 9 months ago
Waiting for branch to pass
Comment 9 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Patch.
Comment 9 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Status changed to RTBC 9 days ago6:55pm 12 November 2024
Comment 9 days ago →
🇺🇸United States laryn
LGTM. I pulled this into the Backdrop version (and threw it into an existing test quickly too):

https://github.com/backdrop-contrib/feeds_xpathparser/commit/9de216f0474...

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024